From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.help Subject: Re: Hooks in minor modes Date: Thu, 29 Apr 2021 23:31:57 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9929"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:uuJC2q8mzekT/GQV7NkSOHPkARU= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 30 05:32:26 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lcJtC-0002UV-5q for geh-help-gnu-emacs@m.gmane-mx.org; Fri, 30 Apr 2021 05:32:26 +0200 Original-Received: from localhost ([::1]:56882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcJtB-0002f2-7b for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 29 Apr 2021 23:32:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcJsq-0002eo-NB for help-gnu-emacs@gnu.org; Thu, 29 Apr 2021 23:32:04 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:33652) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcJsp-0001d4-8E for help-gnu-emacs@gnu.org; Thu, 29 Apr 2021 23:32:04 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lcJsn-00026J-Iz for help-gnu-emacs@gnu.org; Fri, 30 Apr 2021 05:32:01 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:129202 Archived-At: > Is it acceptable to set mode hooks in a minor mode so that the minor > mode is available by default, rather than requiring the user to include > > (add-hook 'texinfo-mode-hook 'my-minor-mode)) Depends when you do that and it likely depends whom you ask. The convention that we strongly encourage to follow is that *loading* an ELisp file should not noticeably change Emacs's behavior (among other things, because files may be loaded without the user's explicit request). So doing such an `add-hook` at the top-level of your file would probably not be considered as acceptable from that point of view (unless activating `my-minor-mode` by default has no visible effect, which is definitely possible but unusual). Stefan