unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>
Cc: help-gnu-emacs@gnu.org
Subject: Re: Debugging SMIE for sh-script.el
Date: Sun, 05 Sep 2021 19:02:59 -0400	[thread overview]
Message-ID: <jwvsfyiab7d.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <c2abe862-6f9f-d310-9a25-2be1a8fb4bf3@gmail.com> (Nikolay Kudryavtsev's message of "Sun, 5 Sep 2021 21:01:08 +0300")

> I do understand that, but the default (smie-indent-calculate) cycle being
> inadequate for the current use case is where we started at.

I don't think so.

At the beginning the case for continuation lines was handled directly to
indent things like

    /usr/bin/emacs -l foo/bar.el   \
                   toto/titi.el

and

    cat food; /usr/bin/emacs -l foo/bar.el   \
                             toto/titi.el

If you remove `sh-smie--indent-continuation` you should see that indeed
the above lines are indented as shown.

Then some users came and said they didn't like this style and wanted
instead continuation lines to be indented without paying attention to
the structure of the code on the logical line (which is spread over
several lines) and just indent the subsequent lines at a fixed offset
from the first line, as in:

    /usr/bin/emacs -l foo/bar.el   \
        toto/titi.el

That's when `sh-smie--indent-continuation` was added (along with the
var `sh-indent-after-continuation`), IIRC.
Additionally, the original scheme (which pays attention to the structure
of the code) was refined to make sure that continuation lines are
indented at least a bit more than the first line,
i.e. instead of

    if grep foo    \
            files; \
    then bar;      \
    else baz;      \
    fi

we wanted to impose something like:

    if grep foo    \
            files; \
        then bar;  \
        else baz;  \
        fi

which is why `sh-smie--indent-continuation` calls
`smie-indent-calculate` first, then looks at the result and if it's less
deep than "baseline indent + offset" then it forces "baseline indent + offset".


        Stefan




  reply	other threads:[~2021-09-05 23:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 10:49 Debugging SMIE for sh-script.el Kévin Le Gouguec
2021-09-02 12:07 ` Nikolay Kudryavtsev
2021-09-02 17:19   ` Kévin Le Gouguec
2021-09-02 18:09     ` Nikolay Kudryavtsev
2021-09-02 20:29       ` Kévin Le Gouguec
2021-09-02 19:50   ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-02 21:37     ` Kévin Le Gouguec
2021-09-02 23:54       ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-03  7:09         ` Kévin Le Gouguec
2021-09-03 12:12           ` Stefan Monnier
2021-09-05 15:48       ` Nikolay Kudryavtsev
2021-09-05 16:27         ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-05 16:41           ` Nikolay Kudryavtsev
2021-09-05 17:23             ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-05 18:01               ` Nikolay Kudryavtsev
2021-09-05 23:02                 ` Stefan Monnier [this message]
2021-09-06 12:47                   ` Nikolay Kudryavtsev
2021-09-06 14:01                     ` Stefan Monnier
2021-09-06 17:24                       ` Nikolay Kudryavtsev
2021-09-06 20:23                         ` Stefan Monnier
2021-09-12 17:40                         ` Kévin Le Gouguec
2021-09-02 19:47 ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-09-02 20:39   ` Kévin Le Gouguec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvsfyiab7d.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=help-gnu-emacs@gnu.org \
    --cc=nikolay.kudryavtsev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).