From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.help Subject: Re: Reporting when keymapping stomped... best approach Date: Tue, 10 Jun 2014 15:24:02 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1402428357 28034 80.91.229.3 (10 Jun 2014 19:25:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Jun 2014 19:25:57 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Tue Jun 10 21:25:51 2014 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WuRg6-0002eC-4i for geh-help-gnu-emacs@m.gmane.org; Tue, 10 Jun 2014 21:25:50 +0200 Original-Received: from localhost ([::1]:41914 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuRg5-0005F7-Ld for geh-help-gnu-emacs@m.gmane.org; Tue, 10 Jun 2014 15:25:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuRfU-00053o-Un for help-gnu-emacs@gnu.org; Tue, 10 Jun 2014 15:25:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuRfN-0001W3-H5 for help-gnu-emacs@gnu.org; Tue, 10 Jun 2014 15:25:12 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:40394) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuRfN-0001Us-Bi for help-gnu-emacs@gnu.org; Tue, 10 Jun 2014 15:25:05 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WuRfM-00020R-65 for help-gnu-emacs@gnu.org; Tue, 10 Jun 2014 21:25:04 +0200 Original-Received: from 75.119.224.253 ([75.119.224.253]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 10 Jun 2014 21:25:04 +0200 Original-Received: from monnier by 75.119.224.253 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 10 Jun 2014 21:25:04 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 22 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 75.119.224.253 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) Cancel-Lock: sha1:pAt5CGEdGnvtgSGJiQvdKetoj40= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:98128 Archived-At: > (defadvice global-set-key (before check-keymapping activate) > (let ((key (ad-get-arg 0)) > (command (ad-get-arg 1))) > (when command > (warn (concat "Just stomped on a global keymapping bound to: " > command))))) This doesn't check whether the key was already bound. You'll probably prefer something like (defadvice global-set-key (before check-keymapping activate) (let* ((key (ad-get-arg 0)) (command (ad-get-arg 1)) (old (lookup-key global-map key))) (when old (message "Replacing %S with %S in global-map" old command)))) and you'll probably also want to advise `define-key' similarly. Stefan