unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: help-gnu-emacs@gnu.org
Subject: Re: x-clipboard-yank insert kill-ring entry instead of primary selection
Date: Mon, 02 Mar 2020 14:56:32 -0500	[thread overview]
Message-ID: <jwvlfoizg8l.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: 83lfoiy9xs.fsf@gnu.org

>> -(defun mouse-yank-primary (click)
>> -  "Insert the primary selection at the position clicked on.
>> +(defun mouse-yank-primary (&optional event)
>> +  "Insert the primary selection.
>
> A nit: a command that can be invoked not by mouse shouldn't be called
> "mouse-SOMETHING".

;-)

I had the exact same reaction while writing the code.
Then again, mouse-set-point works with non-mouse events and I'm guessing
that many/most other commands in mouse.el can work with non-mouse events.

Not sure what we should do about it.  Renaming them all seems too
much trouble.  And they were all written with the mouse as the main
use case.  And they are all in mouse.el.

So I'm thinking maybe we can keep the "mouse-" prefix not to mean "only
useful for the mouse" but "originally introduced for the mouse" or
¨found in mouse.el".


        Stefan




  reply	other threads:[~2020-03-02 19:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-28  8:31 x-clipboard-yank insert kill-ring entry instead of primary selection mickbert
2020-02-28 12:45 ` Stefan Monnier
2020-02-28 12:47 ` Eli Zaretskii
2020-03-02  9:57   ` mickbert
2020-03-02 11:34     ` Eli Zaretskii
2020-03-02 16:31     ` Stefan Monnier
2020-03-02 16:54       ` Eli Zaretskii
2020-03-02 19:56         ` Stefan Monnier [this message]
2020-03-02 20:15           ` Eli Zaretskii
2020-03-03 14:35             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvlfoizg8l.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).