From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via Users list for the GNU Emacs text editor Newsgroups: gmane.emacs.help Subject: Re: Run `window-configuration-change-hook` in Lisp code? Date: Fri, 08 Nov 2024 09:12:46 -0500 Message-ID: References: <86ttckxian.fsf@fastmail.fm> <5193f2dd-05ca-4a92-a3f9-2a069b8ad72e@jamescherti.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13130"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:ZuwaiueKH3nnWZzBAiVFrpJEkIo= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 08 15:13:23 2024 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t9Pjn-0003ET-GU for geh-help-gnu-emacs@m.gmane-mx.org; Fri, 08 Nov 2024 15:13:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t9PjT-0000hS-3U; Fri, 08 Nov 2024 09:13:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9PjR-0000e4-3c for help-gnu-emacs@gnu.org; Fri, 08 Nov 2024 09:13:01 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9PjP-0000SE-6p for help-gnu-emacs@gnu.org; Fri, 08 Nov 2024 09:13:00 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1t9PjL-0002oP-JB for help-gnu-emacs@gnu.org; Fri, 08 Nov 2024 15:12:55 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:148285 Archived-At: > The workaround to fix this issue is to call the following after the text > scale is changed (run-hooks 'window-configuration-change-hook) >From where? The way I see it, another workaround is for those packages which depend strongly on such single-size monospace text to add the relevant function to `text-scale-mode-hook`. > OP wants to know whether it is good practice or bad practice to run the > `window-configuration-change-hook` hooks from a third-party package in this > situation, as a workaround to resolve the issue described above. (Check: > https://codeberg.org/joostkremers/visual-fill-column/pulls/16 ). I'd put it in the bad practice column (especially since that hook is documented to be run in a fairly special way which `run-hooks` doesn't follow). Then again, looking at that patch I can't understand why it would work. Does it work? If so how? That code is run only when `visual-fill-mode` is enabled, AFAICT, so whether it runs `window-configuration-change-hook` won't make any difference when text-scale is used. Stefan