From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.help Subject: Re: wrong type error in local variables Date: Thu, 02 Jul 2020 13:42:41 -0400 Message-ID: References: <8270ebe2-8e9d-2bf9-fa1c-b6e968aabe5a@gmail.com> <878sg1ri0f.fsf@ebih.ebihd> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4265"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:kGlgVEcvmEHC54sYXbU8drga8hI= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 02 19:52:13 2020 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jr3Nc-00011U-LZ for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 02 Jul 2020 19:52:12 +0200 Original-Received: from localhost ([::1]:33416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jr3Nb-0002zo-Mg for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 02 Jul 2020 13:52:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jr3Ed-0002do-Pm for help-gnu-emacs@gnu.org; Thu, 02 Jul 2020 13:42:56 -0400 Original-Received: from static.214.254.202.116.clients.your-server.de ([116.202.254.214]:43248 helo=ciao.gmane.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jr3Ea-0000LE-Vq for help-gnu-emacs@gnu.org; Thu, 02 Jul 2020 13:42:55 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1jr3EW-0000Vq-D7 for help-gnu-emacs@gnu.org; Thu, 02 Jul 2020 19:42:48 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/02 11:56:35 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:123478 Archived-At: >> `find-file` should not be called from Elisp. >> Use `find-file-noselect` instead. > Oups, if so I have 15 changes to make. > Why doesn't the byte compiler say this? Because noone has added the annotation for it yet (tho there are various comments in the code that say so). FWIW, I just tried adding it (see patch below), and I see that we have many cases in Emacs's own Lisp code where we call `find-file` from Elisp. I suspect that many of them would benefit from being changed, but the need to go and update all those cases might be a reason why it hasn't been done yet :-( Stefan diff --git a/lisp/files.el b/lisp/files.el index 742fd78df1d..a29d02bf591 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -1688,6 +1688,7 @@ find-file To visit a file without any kind of conversion and without automatically choosing a major mode, use \\[find-file-literally]." + (declare (interactive-only find-file-noselect)) (interactive (find-file-read-args "Find file: " (confirm-nonexistent-file-or-buffer))) @@ -1761,15 +1762,16 @@ find-file-other-frame (switch-to-buffer-other-frame value)))) (defun find-file-existing (filename) - "Edit the existing file FILENAME. + "Edit the existing file FILENAME. Like \\[find-file], but allow only a file that exists, and do not allow file names with wildcards." - (interactive (nbutlast (find-file-read-args "Find existing file: " t))) - (if (and (not (called-interactively-p 'interactive)) - (not (file-exists-p filename))) - (error "%s does not exist" filename) - (find-file filename) - (current-buffer))) + (interactive (nbutlast (find-file-read-args "Find existing file: " t))) + (if (not (or (called-interactively-p 'interactive) + (file-exists-p filename))) + (error "%s does not exist" filename) + (with-suppressed-warnings ((interactive-only find-file)) + (find-file filename)) + (current-buffer))) (defun find-file--read-only (fun filename wildcards) (unless (or (and wildcards find-file-wildcards