From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via Users list for the GNU Emacs text editor Newsgroups: gmane.emacs.help Subject: Re: Major-mode devel: how to drop font-lock 'display when mode is disabled? Date: Mon, 11 Mar 2024 09:16:30 -0400 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20785"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:fJhTYA90u6d7QptmWZrdODz0A5Y= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 11 14:17:31 2024 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rjfX0-0005Az-BU for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 11 Mar 2024 14:17:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjfWW-0001rP-Gr; Mon, 11 Mar 2024 09:17:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjfWE-0001fo-1h for help-gnu-emacs@gnu.org; Mon, 11 Mar 2024 09:16:42 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjfWC-0003SJ-Fr for help-gnu-emacs@gnu.org; Mon, 11 Mar 2024 09:16:41 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rjfW9-00041W-3e for help-gnu-emacs@gnu.org; Mon, 11 Mar 2024 14:16:37 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:146072 Archived-At: > After some searching and experimentation I figured it's easy by making > a major mode, which basically uses a `(put-text-property start end > 'display human-redable-text)` to change the display of timestamps. > > It works fine but one problem I couldn't figure out how to get rid of > is that upon changing the major mode the custom display does not > go away. > > As a workaround I have the following call: > > (add-to-list 'font-lock-extra-managed-props 'display) You should make this change buffer-locally rather than globally. Beside this detail, this is not considered as a workaround but as the officially supported solution. > …however, I presume this will make all "display" changes disappear, > even if they been done by another mode, which isn't good. Yup, currently Emacs doesn't keep track of who a given `display` property belongs to, so that's as good as it gets. 🙁 > (defun zsh-hist-display () > (let ((start (match-beginning 0)) > (end (match-end 0))) > (put-text-property start end 'display > (zsh-hist-convert-unix-timestamp (match-string-no-properties 1))) > ;; put some highlighting > (put-text-property start end 'face '(:weight bold)) > (put-text-property start end 'zsh-hist:fontified t) > nil)) I'd do: (defun zsh-hist-display () `( face bold ;; Or `face (:weight bold)` if you insist. display ,(zsh-hist-convert-unix-timestamp (match-string-no-properties 1)) zsh-hist:fontified t)) Note that doing it this way lets font-lock know that it has set those extra properties, so *in theory* it could allow font-lock to remove those display properties (and only those) automatically. Font-lock does not do this, currently, tho. 🙁 > (define-derived-mode zsh-history-mode text-mode "Zsh History Files" > "Major mode for viewing zsh-history files." > (add-to-list 'font-lock-extra-managed-props 'zsh-hist:fontified) > ;; BUG: this may potentially remove font-lock for other modes that decided to use > ;; 'display. Unfortunately it is unclear how to make font-lock only remove 'display > ;; for our mode. > (add-to-list 'font-lock-extra-managed-props 'display) > (font-lock-add-keywords 'zsh-history-mode '(("^: \\([0-9]+\\)" (0 (zsh-hist-display)))))) Use something like: (setq-local font-lock-extra-managed-props '(zsh-hist:fontified display)) -- Stefan