From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: help-gnu-emacs@gnu.org
Subject: Re: Bookmarks in EWW
Date: Wed, 25 Mar 2020 10:06:57 -0400 [thread overview]
Message-ID: <jwv7dz87crw.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87tv2d3zii.fsf@web.de> (Michael Heerdegen's message of "Wed, 25 Mar 2020 04:05:25 +0100")
> Ok, I've thrown something together (draft!) and tested quickly:
Thanks.
> + ;; Emacs bookmarks support
> + (defvar bookmark-make-record-function)
> + (setq-local bookmark-make-record-function #'eww-bookmark-make-record)
No need for the `defvar` here.
> Does it make sense that these bookmarks save a text part? Surely makes
> sense for some cases, e.g. locally saved documentation in html, but
> makes not much sense for e.g. newspaper sites.
As you say, it's useful for pages which don't change (or not much), and
it should be harmless for those pages that change too frequently.
> Do I need to declare `bookmark-make-record-function' as special when
> setting with `setq-local' (that's what doc-view does)?
No. buffer-localness is a concept that only applies to dynamically
scoped variables anyway, so if you need it it's a sign that we should
improve something somewhere.
> Do I have to add a NEWS entry?
I think it deserves a mention, yes.
Stefan
next prev parent reply other threads:[~2020-03-25 14:06 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 11:26 Bookmarks in EWW Marcin Borkowski
2020-03-23 14:56 ` Drew Adams
2020-03-25 11:48 ` Marcin Borkowski
2020-03-23 20:41 ` Michael Heerdegen
2020-03-24 14:46 ` Stefan Monnier
2020-03-25 3:05 ` Michael Heerdegen
2020-03-25 3:45 ` `declare-function' docu (was: Re: Bookmarks in EWW) Emanuel Berg via Users list for the GNU Emacs text editor
2020-03-28 17:59 ` `declare-function' docu Bruno Félix Rezende Ribeiro
2020-03-28 18:38 ` Drew Adams
2020-04-09 12:30 ` Bruno Félix Rezende Ribeiro
2020-04-09 15:47 ` Drew Adams
2020-03-28 21:38 ` Emanuel Berg via Users list for the GNU Emacs text editor
2020-03-25 14:06 ` Stefan Monnier [this message]
2020-03-26 1:09 ` Bookmarks in EWW Michael Heerdegen
2020-03-26 4:07 ` Stefan Monnier
2020-03-27 2:07 ` Michael Heerdegen
2020-03-27 3:44 ` Stefan Monnier
2020-03-28 2:31 ` Michael Heerdegen
2020-03-28 2:55 ` Stefan Monnier
2020-04-19 3:42 ` Michael Heerdegen
2020-04-19 13:18 ` Stefan Monnier
2020-04-20 3:17 ` Michael Heerdegen
2020-04-20 13:24 ` Stefan Monnier
2020-04-21 0:59 ` Michael Heerdegen
2020-04-29 22:53 ` Michael Heerdegen
2020-04-30 1:25 ` Stefan Monnier
2020-04-30 2:08 ` Michael Heerdegen
2020-04-30 3:08 ` Stefan Monnier
2020-04-30 20:09 ` Michael Heerdegen
2020-04-27 2:43 ` Michael Heerdegen
2020-03-27 4:32 ` buffer-localness (was: Re: Bookmarks in EWW) Emanuel Berg via Users list for the GNU Emacs text editor
2020-03-25 21:48 ` Bookmarks in EWW Drew Adams
2020-03-26 2:29 ` Michael Heerdegen
2020-03-26 3:21 ` Drew Adams
2020-03-26 3:53 ` Michael Heerdegen
2020-03-26 14:02 ` Drew Adams
2020-03-26 22:33 ` Michael Heerdegen
2020-03-26 8:41 ` Marcin Borkowski
2020-03-25 11:49 ` Marcin Borkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7dz87crw.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=help-gnu-emacs@gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).