From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Gregory Heytings <gregory@heytings.org>
Cc: help-gnu-emacs@gnu.org
Subject: Re: Undo defalias
Date: Fri, 03 Mar 2023 19:05:39 -0500 [thread overview]
Message-ID: <jwv5ybhv0za.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <7c6ec4cae3090ac235da@heytings.org> (Gregory Heytings's message of "Fri, 03 Mar 2023 22:58:54 +0000")
> Should we not inhibit-quit around the unwind-form of cl-letf to avoid this?
> Otherwise the promise of cl-letf ("On exit, either normally or because of
> a `throw' or error, the PLACEs are set back to their original values.") is
> not fulfilled. (And yes, I know that, even with inhibit-quit, it is still
> possible that a C-g would be processed just before we bind inhibit-quit.)
As you point out, we can't solve it in ELisp. Note that this also
affects plain old `let` (for dynamically-scoped vars), tho the
time-window is shorter.
I think we could solve it by using `inhibit-quit` during `unbind_to`,
but that's a pretty significant change. It might be The Right Thing to
do, tho.
Stefan
prev parent reply other threads:[~2023-03-04 0:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 1:23 Undo defalias Óscar Fuentes
2023-02-28 9:17 ` Gregory Heytings
2023-02-28 15:56 ` Óscar Fuentes
2023-03-01 20:36 ` Emanuel Berg
2023-03-03 15:29 ` Stefan Monnier via Users list for the GNU Emacs text editor
2023-03-03 15:37 ` Gregory Heytings
2023-03-03 15:49 ` Stefan Monnier via Users list for the GNU Emacs text editor
2023-03-03 15:52 ` Eli Zaretskii
2023-03-03 16:01 ` Gregory Heytings
2023-03-03 16:00 ` Óscar Fuentes
2023-03-03 16:17 ` Gregory Heytings
2023-03-03 16:33 ` Stefan Monnier via Users list for the GNU Emacs text editor
2023-03-03 21:11 ` Óscar Fuentes
2023-03-05 9:32 ` Madhu
2023-03-03 22:58 ` Gregory Heytings
2023-03-04 0:05 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv5ybhv0za.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=gregory@heytings.org \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).