From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via Users list for the GNU Emacs text editor Newsgroups: gmane.emacs.help Subject: Re: eldoc-mode suspend Emacs for about 20 seconds when point moved on `pcase` Date: Sat, 01 Jun 2024 14:21:30 -0400 Message-ID: References: <665abc68.170a0220.37c58e.69e4@mx.google.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7529"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:JmZPqvnWlDqvR44HAlr0Op59nuI= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 01 20:22:25 2024 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sDTN3-0001r4-Pj for geh-help-gnu-emacs@m.gmane-mx.org; Sat, 01 Jun 2024 20:22:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sDTML-0005wt-T3; Sat, 01 Jun 2024 14:21:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDTMK-0005wV-JF for help-gnu-emacs@gnu.org; Sat, 01 Jun 2024 14:21:40 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDTMJ-0000GA-3q for help-gnu-emacs@gnu.org; Sat, 01 Jun 2024 14:21:40 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1sDTMF-0000qA-SM for help-gnu-emacs@gnu.org; Sat, 01 Jun 2024 20:21:35 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:146841 Archived-At: > When I move point on Elisp code where is `(pcase|`. (The | represent the point) > This issue happened every time when I move point on `pcase`. > Here is the profiler report of CPU and Memory: [ Can you reproduce it on purpose in a fresh Emacs session? If so, please file a bug report for it. ] > CPU Profiler Report > #+begin_example > 15205 89% - timer-event-handler > 15205 89% - apply > 15170 88% - # > 15170 88% - eldoc-print-current-symbol-info > 15170 88% - eldoc--invoke-strategy > 15170 88% - eldoc-documentation-default > 15170 88% - run-hook-wrapped > 15170 88% - # > 15170 88% - elisp-eldoc-funcall > 15159 88% - apply > 15159 88% - elisp-get-fnsym-args-string > 15158 88% - documentation > 15158 88% - pcase--make-docstring > 15042 88% - help-fns-short-filename > 15019 87% - file-relative-name > 14867 87% file-name-case-insensitive-p Hmm... There are several inefficiencies at the level of `pcase--make-docstring` (designed to generate the occasional *Help* buffer rather than the on-the-fly eldoc info) as well as `help-fns-short-filename`, but the costly operations are not supposed to be `file-name-case-insensitive-p`. If on some systems `file-name-case-insensitive-p` can be slow, maybe we should add some caching mechanism to it? Stefan