From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.help Subject: Re: Enabling a globalized-minor-mode by default Date: Thu, 10 Sep 2020 17:14:11 -0400 Message-ID: References: <87pn6tmoti.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3555"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:fy+ubCUlT3OLArC6Isqdw7I+BQQ= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 10 23:14:43 2020 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGTtz-0000o8-Eo for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 10 Sep 2020 23:14:43 +0200 Original-Received: from localhost ([::1]:42038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGTty-00035r-H7 for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 10 Sep 2020 17:14:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGTtf-00035g-Pf for help-gnu-emacs@gnu.org; Thu, 10 Sep 2020 17:14:23 -0400 Original-Received: from static.214.254.202.116.clients.your-server.de ([116.202.254.214]:54802 helo=ciao.gmane.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGTte-00035A-5p for help-gnu-emacs@gnu.org; Thu, 10 Sep 2020 17:14:23 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1kGTta-0000MS-4a for help-gnu-emacs@gnu.org; Thu, 10 Sep 2020 23:14:18 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/10 17:14:18 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:124014 Archived-At: > I'm trying to understand how to define a globalized minor mode that is > enabled by default. My goal is to make this mode's keymap available > with no configuration on the user's part, unless the user explicitly > disables the minor mode. [...] > Now, if I: > > - byte-compile this file, > - M-: (package-generate-autoloads "testautoload" default-directory) > - emacs -Q -L . > - M-: (load-file "testautoload-autoloads.el") Loading an ELisp file should not affect the visible behavior of Emacs, so according to that principle a global mode that's pre-enabled should only ever exist if it's bundled with Emacs. For the same kind of reasons merely installing a package should not affect the visible behavior of Emacs. [ And yes "affect the visible behavior" is not well defined, or at least it needs to be tempered by some tolerated exceptions. For example, it's considered normal for a package to add itself (via its autoloads) to `auto-mode-alist`, which does have a visible impact on Emacs's behavior. ] > ;;;###autoload > (progn > (require 'cl-macs) > (cl-eval-when (load eval) > (when global-testautoload-mode > (global-testautoload-mode 1)))) [ Please require `cl-lib` rather than `cl-macs`, because we want to be free to move definitions between the various internal files of `cl-lib`. ] > Is that bad form somehow, or is that the way to go? Yup. > Admittedly, maybe forcing a globalized minor mode on users by default is > bad form. For context, I am trying to make magit-file-mode work > out-of-the-box, i.e. without users having to (1) (require 'anything) in > their config or (2) customize global-magit-file-mode to t explicitly, > which should be redundant because this is the default value. `require` is definitely not needed here. Only `(global-magit-file-mode 1)` needs to be added to the init file (or do the equivalent via Customize) and it shouldn't be redundant because t shouldn't be the default value ;-) Stefan