unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Spencer Baugh <sbaugh@janestreet.com>
To: help-gnu-emacs@gnu.org
Subject: Re: Skipping installation of .el.gz files
Date: Mon, 23 Oct 2023 16:25:56 -0400	[thread overview]
Message-ID: <ierh6mhdr1n.fsf@janestreet.com> (raw)
In-Reply-To: 83ttqhmbdz.fsf@gnu.org

Eli Zaretskii <eliz@gnu.org> writes:
>> From: Spencer Baugh <sbaugh@janestreet.com>
>> Date: Mon, 23 Oct 2023 12:42:31 -0400
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> >
>> > I suggest to override find-lisp-object-file-name with a similar
>> > definition that does what you want.
>> 
>> Hm, I think what it should do is just, when looking for a Lisp file such
>> as /usr/share/emacs/29.1/lisp/files.elc, if
>> /usr/share/emacs/29.1/lisp/files.el and
>> /usr/share/emacs/29.1/lisp/files.el.gz don't exist, then also check for
>> (concat source-directory "lisp/files.el") and use that if it exists.
>> Only for Lisp files in the Emacs installation directory, of course.
>
> No, because the source directory could hold code different from the
> one which was used to install the files under /usr/share.  Think about
> Emacs installed from a Git repository that got many updates after
> that, for example.

Yes.  And this is an issue today for jumping to the definitions of
functions in C files, since those are not packaged with Emacs.  Today,
that is broken out of the box if source-directory is still around.

So if you think this behavior is bad, then should we fix it to not
happen for the case of C files?  Perhaps by clearing source-directory
when Emacs is installed, so that Emacs cannot find obsolete C files out
of the Git repository?




  reply	other threads:[~2023-10-23 20:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23  0:45 Skipping installation of .el.gz files Spencer Baugh
2023-10-23  5:55 ` Emanuel Berg
2023-10-23  6:41 ` Corwin Brust
2023-10-23 16:18   ` Spencer Baugh
2023-10-23 11:35 ` Eli Zaretskii
2023-10-23 12:28   ` Emanuel Berg
2023-10-28 10:44     ` Eli Zaretskii
2023-10-28 10:52       ` Emanuel Berg
2023-10-23 16:42   ` Spencer Baugh
2023-10-23 18:39     ` Eli Zaretskii
2023-10-23 20:25       ` Spencer Baugh [this message]
2023-10-23 20:57         ` Emanuel Berg
2023-10-24 12:35         ` Eli Zaretskii
2023-10-24 12:49           ` Emanuel Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ierh6mhdr1n.fsf@janestreet.com \
    --to=sbaugh@janestreet.com \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).