From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sergei Organov Newsgroups: gmane.emacs.help Subject: Re: Problem advising nreverse. Date: Wed, 16 Dec 2009 14:27:43 +0300 Message-ID: References: <87skbg8jww.fsf@galatea.local> <87bpi1n1z7.fsf@galatea.local> <873a3dmvef.fsf@galatea.local> <87pr6hl9s4.fsf@galatea.local> <873a3dknyz.fsf@galatea.local> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1260962938 1892 80.91.229.12 (16 Dec 2009 11:28:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Dec 2009 11:28:58 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Wed Dec 16 12:28:51 2009 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NKs3m-00061m-Ic for geh-help-gnu-emacs@m.gmane.org; Wed, 16 Dec 2009 12:28:50 +0100 Original-Received: from localhost ([127.0.0.1]:59964 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NKs3m-0004j8-CK for geh-help-gnu-emacs@m.gmane.org; Wed, 16 Dec 2009 06:28:50 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NKs3D-0004hj-4n for help-gnu-emacs@gnu.org; Wed, 16 Dec 2009 06:28:15 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NKs38-0004g6-91 for help-gnu-emacs@gnu.org; Wed, 16 Dec 2009 06:28:14 -0500 Original-Received: from [199.232.76.173] (port=37732 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NKs37-0004g3-Vb for help-gnu-emacs@gnu.org; Wed, 16 Dec 2009 06:28:10 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:40946) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NKs37-0004WS-JA for help-gnu-emacs@gnu.org; Wed, 16 Dec 2009 06:28:09 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.50) id 1NKs33-0005ks-O2 for help-gnu-emacs@gnu.org; Wed, 16 Dec 2009 12:28:05 +0100 Original-Received: from 89.175.180.246 ([89.175.180.246]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 16 Dec 2009 12:28:05 +0100 Original-Received: from osv by 89.175.180.246 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 16 Dec 2009 12:28:05 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 43 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 89.175.180.246 User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:70673 Archived-At: Barry Margolin writes: > In article , > Sergei Organov wrote: > >> > pjb@informatimago.com (Pascal J. Bourguignon) writes: >> > >> >> Sergei Organov writes: >> >>> I still wonder if it's documented somewhere in some manual when >> >>> defadvice doesn't actually work. It seems it is not there in the Elisp >> >>> manual, or did I miss it? >> >> >> >> See: (info "(elisp)Advising Primitives") >> > >> > Well, but I didn't find even single word there describing cases when >> > it does not work to advise a funciton. >> >> Sorry, my mistake. In fact, this topic does tell about when advice won't >> work, but it tells exactly opposite to what actually happens: >> >> "Calls to the primitive from Lisp code will take note of the advice, but >> calls from C code will ignore the advice." >> >> Now, in my case `nreverse' is called from Lisp code, not from C code, so >> according to the manual advice must work, right? And there is no single >> word about differences in behavior due to byte-compiling. > > Byte compiling effectively changes it to a call from C code, because the > byte code is a direct reference to the primitive. "Called from Lisp > code" means interpreting Lisp source code, since that indirects through > the function name, which is where advice is stored. I do understand what you are saying, but I can't persuade myself to believe that "calls from C code" include "calls from byte-compiled Lisp code" in general. As far as I understand, byte-compiled Lisp code is never seen by a C compiler and can't be compiled by a C compiler, so it's not C code, thus calls from byte-compiled code are not calls from C code. IMHO it should be explicitly specified in the documentation that calls to a primitive from byte-compiled Lisp code will ignore the advice, provided this is feature indeed. -- Sergei.