From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.help Subject: Re: how to deal with comment in a new lang mode Date: Thu, 30 Oct 2008 20:46:27 -0600 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1225421224 26840 80.91.229.12 (31 Oct 2008 02:47:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Oct 2008 02:47:04 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Fri Oct 31 03:48:06 2008 connect(): Connection refused Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kvk3R-0006VS-I1 for geh-help-gnu-emacs@m.gmane.org; Fri, 31 Oct 2008 03:48:05 +0100 Original-Received: from localhost ([127.0.0.1]:51270 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kvk2L-0005av-3g for geh-help-gnu-emacs@m.gmane.org; Thu, 30 Oct 2008 22:46:57 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kvk20-0005ZO-PV for help-gnu-emacs@gnu.org; Thu, 30 Oct 2008 22:46:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kvk1w-0005XB-Nx for help-gnu-emacs@gnu.org; Thu, 30 Oct 2008 22:46:36 -0400 Original-Received: from [199.232.76.173] (port=48759 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kvk1w-0005Wx-Ev for help-gnu-emacs@gnu.org; Thu, 30 Oct 2008 22:46:32 -0400 Original-Received: from main.gmane.org ([80.91.229.2]:40762 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kvk1w-0000oj-6C for help-gnu-emacs@gnu.org; Thu, 30 Oct 2008 22:46:32 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1Kvk1s-0002PV-Hg for help-gnu-emacs@gnu.org; Fri, 31 Oct 2008 02:46:28 +0000 Original-Received: from c-67-161-145-183.hsd1.co.comcast.net ([67.161.145.183]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 31 Oct 2008 02:46:28 +0000 Original-Received: from kevin.d.rodgers by c-67-161-145-183.hsd1.co.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 31 Oct 2008 02:46:28 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 48 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-67-161-145-183.hsd1.co.comcast.net User-Agent: Thunderbird 2.0.0.17 (Macintosh/20080914) In-Reply-To: X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:59281 Archived-At: Xah wrote: > when writing a new language mode, how can one make comment-dwim work? > > i can of course code my own functions dealing with comments, but i > think it is better to use the facilities provided in newcomment.el? > > right now i have: > > (defun xlsl-comment-dwim (arg) > (interactive "*P") > (let ((comment-start-orig comment-start) > (comment-end-orig comment-end)) > (setq comment-start "// ") > (setq comment-end "") > (comment-dwim arg) > > (setq comment-start comment-start-orig) > (setq comment-end comment-end-orig) > )) > > and > > (define-key xlsl-mode-map [remap comment-dwim] 'xlsl-comment-dwim) > > this works fine when typing the shortcut for comment-dwim on a empty > line to insert comment. But doesnt work as expected when the line is > already a comment. (it does nothing) > > any advice apprecated for dealing with comments in a new lang mode. I can't address your question, but I can suggest a minor simplification of your current implementation: (defun xlsl-comment-dwim (arg) (interactive "*P") (let ((comment-start "// ") (comment-end "")) (comment-dwim arg))) This is also has the advantage of restoring the original binding of the comment-start and comment-end variables, even if comment-dwim signals an error. Hope that helps, -- Kevin Rodgers Denver, Colorado, USA