From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel,gmane.emacs.help Subject: RE: bisected to commit since when this error occours (was: Re: isearch+ provoces error when starting eshell) Date: Sun, 2 Jun 2013 11:59:57 -0700 (PDT) Message-ID: References: <20130531222203.GA2380@boo.workgroup> <54634406-dce7-432b-a456-32749e186f01@default> <20130602134650.GA27694@boo.workgroup> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1370199640 5272 80.91.229.3 (2 Jun 2013 19:00:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 2 Jun 2013 19:00:40 +0000 (UTC) Cc: "emacs-devel@gnu.org Development" To: Gregor Zattler , help-gnu-emacs Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 02 21:00:39 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UjDWB-0007uS-R0 for ged-emacs-devel@m.gmane.org; Sun, 02 Jun 2013 21:00:39 +0200 Original-Received: from localhost ([::1]:52974 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjDWB-0000Cp-HJ for ged-emacs-devel@m.gmane.org; Sun, 02 Jun 2013 15:00:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjDW7-0000Ci-W9 for emacs-devel@gnu.org; Sun, 02 Jun 2013 15:00:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjDW6-0007k3-TN for emacs-devel@gnu.org; Sun, 02 Jun 2013 15:00:35 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:39763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjDW6-0007jz-Mr; Sun, 02 Jun 2013 15:00:34 -0400 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r52J0UUD027868 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 2 Jun 2013 19:00:31 GMT Original-Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r52J0TFT011800 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 2 Jun 2013 19:00:30 GMT Original-Received: from abhmt102.oracle.com (abhmt102.oracle.com [141.146.116.54]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r52J0T4C028247; Sun, 2 Jun 2013 19:00:29 GMT In-Reply-To: <20130602134650.GA27694@boo.workgroup> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 141.146.126.69 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:160001 gmane.emacs.help:91238 Archived-At: > [also to emacs-devel since it is perhaps a bug in gnu emacs] Probably not a great idea, but I've left the cc for now. If it turns out that there is an Emacs problem we can file a bug report etc. My guess, without looking (and I have no time to look now; sorry),=20 is that there is no Emacs bug here, but that I need to update Isearch+ to accommodate whatever changes were made to Emacs. I will take a look when I can (not too soon, I'm afraid).=20 > I built Emacs 24.3 from source and I confirm that this issue is not > present in Emacs 23 and Emacs 24.3. I did a git bisect then > (see below). >=20 > I bisected the Emacs version history. Result is: >=20 > ffc1d3e25cdae710e0f6057620af05c023a6e710 is the first bad commit > commit ffc1d3e25cdae710e0f6057620af05c023a6e710 > Author: Glenn Morris > Date: Tue May 7 00:57:02 2013 -0700 >=20 > * lisp/eshell/em-hist.el (eshell-isearch-map): Initialize in the defv= ar. > Remove explicit eshell-isearch-cancel-map. >=20 > This commit changes the keymap for eshell. But I have no clue of > elisp and therefore am not in the position to judge if the commit > is wrong or if it exposes some bug in isearch+ or eshell. Thanks for narrowing things down. That will help a lot, no doubt. As I say, I will take a look when I can. Perhaps someone from Emacs Dev will recognize an obvious bug introduced by the changes you cite. My guess is that there is no Emacs bug, but you never know. There might have also been some recent changes to isearch.el and `isearch-mode-map' that affect this. Dunno.