From: Drew Adams <drew.adams@oracle.com>
To: Gregor Zattler <telegraph@gmx.net>,
help-gnu-emacs <help-gnu-emacs@gnu.org>
Cc: "emacs-devel@gnu.org Development" <emacs-devel@gnu.org>
Subject: RE: bisected to commit since when this error occours (was: Re: isearch+ provoces error when starting eshell)
Date: Sun, 2 Jun 2013 11:59:57 -0700 (PDT) [thread overview]
Message-ID: <f8bcaec3-7001-44a7-ac6d-e5729172f625@default> (raw)
In-Reply-To: <20130602134650.GA27694@boo.workgroup>
> [also to emacs-devel since it is perhaps a bug in gnu emacs]
Probably not a great idea, but I've left the cc for now. If it
turns out that there is an Emacs problem we can file a bug report etc.
My guess, without looking (and I have no time to look now; sorry),
is that there is no Emacs bug here, but that I need to update Isearch+
to accommodate whatever changes were made to Emacs.
I will take a look when I can (not too soon, I'm afraid).
> I built Emacs 24.3 from source and I confirm that this issue is not
> present in Emacs 23 and Emacs 24.3. I did a git bisect then
> (see below).
>
> I bisected the Emacs version history. Result is:
>
> ffc1d3e25cdae710e0f6057620af05c023a6e710 is the first bad commit
> commit ffc1d3e25cdae710e0f6057620af05c023a6e710
> Author: Glenn Morris <rgm@gnu.org>
> Date: Tue May 7 00:57:02 2013 -0700
>
> * lisp/eshell/em-hist.el (eshell-isearch-map): Initialize in the defvar.
> Remove explicit eshell-isearch-cancel-map.
>
> This commit changes the keymap for eshell. But I have no clue of
> elisp and therefore am not in the position to judge if the commit
> is wrong or if it exposes some bug in isearch+ or eshell.
Thanks for narrowing things down. That will help a lot, no doubt.
As I say, I will take a look when I can.
Perhaps someone from Emacs Dev will recognize an obvious bug introduced
by the changes you cite. My guess is that there is no Emacs bug, but you
never know. There might have also been some recent changes to isearch.el
and `isearch-mode-map' that affect this. Dunno.
next prev parent reply other threads:[~2013-06-02 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 22:22 isearch+ provoces error when starting eshell Gregor Zattler
2013-06-01 4:42 ` Drew Adams
2013-06-02 13:46 ` bisected to commit since when this error occours (was: Re: isearch+ provoces error when starting eshell) Gregor Zattler
2013-06-02 18:59 ` Drew Adams [this message]
2013-06-02 20:45 ` Gregor Zattler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8bcaec3-7001-44a7-ac6d-e5729172f625@default \
--to=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=help-gnu-emacs@gnu.org \
--cc=telegraph@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).