From: "Juanma Barranquero" <lekktu@gmail.com>
To: z0d <peter.barabas@gmail.com>
Cc: quiet@emacsbugs.donarmstrong.com, help-gnu-emacs@gnu.org
Subject: Re: Sorting buffers with ibuffer
Date: Wed, 26 Nov 2008 11:28:39 +0100 [thread overview]
Message-ID: <f7ccd24b0811260228j713d6481i5d5d6816164a30bd@mail.gmail.com> (raw)
In-Reply-To: <b6977a80-343d-4cf6-8b81-af8c8068abb4@j32g2000yqn.googlegroups.com>
Package: emacs
Severity: minor
X-Debbugs-CC: jpw@gnu.org
On Wed, Nov 26, 2008 at 04:29, z0d <peter.barabas@gmail.com> wrote:
> shell: emacs -q .emacs .ssh/config .Emacs-lisp/init-lisp.el
>
> M-: (setq-default ibuffer-default-sorting-mode 'major-mode) <RET>
> M-x ibuffer <RET>
>
> produces:
>
> MR Name Size Mode Filename/Process
> -- ---- ---- ---- ----------------
> [ Default ]
> asdf-skeleton.el 1052 Emacs-Lisp ~/.Emacs-Lisp/asdf-
> skeleton.el
> config 488 Conf[Space] ~/.ssh/config
> .emacs 13170 Emacs-Lisp ~/.emacs
> *scratch* 191 Lisp Interaction
> * *Messages* 142 Fundamental
> % *GNU Emacs* 744 Fundamental
>
> 6 buffers 15787 3 files, no
> processes
You're right.
What's happening is that, in fact, ibuffer is not sorting at all,
because there's a variable ibuffer-sorting-functions-alist that is
null at that point. That variable is initialized by code in
ibuf-ext.el; defaulting to 'recency works because that sorting order
is special-cased in ibuffer.el.
You can workaround the issue by making sure ibuf-ext is loaded, for example:
emacs -q -l ibuf-ext .emacs .ssh/config .Emacs-lisp/init-lisp.el
but I think ibuffer should take care that the sorting functions' alist
is properly stuffed.
John, I've considered the attached patch, which checks in
ibuffer-sort-bufferlist. The alternative I see is to require 'ibuf-ext
in `ibuffer-mode' if the user modified `ibuffer-default-sorting-mode',
like
(set (make-local-variable 'ibuffer-sorting-mode)
ibuffer-default-sorting-mode)
(unless (eq ibuffer-sorting-mode 'recency)
(require 'ibuf-ext))
Are you OK with one of these changes?
Juanma
Index: lisp/ibuffer.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/ibuffer.el,v
retrieving revision 1.110
diff -u -2 -r1.110 ibuffer.el
--- lisp/ibuffer.el 8 Oct 2008 05:02:09 -0000 1.110
+++ lisp/ibuffer.el 26 Nov 2008 09:56:30 -0000
@@ -2192,4 +2192,6 @@
(defun ibuffer-sort-bufferlist (bmarklist)
+ (unless ibuffer-sorting-functions-alist
+ (require 'ibuf-ext))
(let* ((sortdat (assq ibuffer-sorting-mode
ibuffer-sorting-functions-alist))
next prev parent reply other threads:[~2008-11-26 10:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 18:07 Sorting buffers with ibuffer z0d
2008-11-21 18:36 ` z0d
2008-11-23 2:39 ` Juanma Barranquero
[not found] ` <mailman.1052.1227407986.26697.help-gnu-emacs@gnu.org>
2008-11-26 3:29 ` z0d
2008-11-26 10:28 ` Juanma Barranquero [this message]
[not found] ` <mailman.1281.1227695324.26697.help-gnu-emacs@gnu.org>
2008-11-26 18:21 ` z0d
2008-11-22 3:07 ` Kevin Rodgers
[not found] ` <mailman.990.1227323256.26697.help-gnu-emacs@gnu.org>
2008-11-23 11:45 ` z0d
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ccd24b0811260228j713d6481i5d5d6816164a30bd@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=help-gnu-emacs@gnu.org \
--cc=peter.barabas@gmail.com \
--cc=quiet@emacsbugs.donarmstrong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).