whitespace-cleanup + untabify?

whitespace-cleanup + untabify?

[dsevilla]

Dear all:

I'm a no tab person. I would like my whitespace-cleanup command to
also perform an untabify. How can this be done? I haven't found any
option that connects untabify and whitespace-cleanup. I'm using:

GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.9)

I would really appreciate the help.

Regards,
diego.

Re: whitespace-cleanup + untabify?

[Juanma Barranquero]

On Sat, Jun 14, 2008 at 12:56, dsevilla@gmail.com <dsevilla@gmail.com> wrote:

> I haven't found any
> option that connects untabify and whitespace-cleanup. I'm using:

That really depends on how do you want to do the untabify.

For example, you can defadvice `whitespace-cleanup' like so

(defadvice whitespace-cleanup (after whitespace-untabify activate compile)
  (save-restriction
    (widen)
    (untabify (point-min) (point-max))))

so when you do M-x whitespace cleanup, it first cleans up and then
untabifies. Take into account that untabify removes tabs anywhere in
the line; if you prefer only to untabify at the beginning of line, you
could use this instead:

(defadvice whitespace-cleanup (after whitespace-untabify activate compile)
  (save-restriction
    (widen)
    (let ((tabify-regexp "^\t* [ \t]+"))
      (untabify (point-min) (point-max)))))

Both examples untabify the whole buffer (that's what the
`save-restriction' and `widen' calls are for), so if you in fact only
want to untabify the region, it's even simpler:

(defadvice whitespace-cleanup (after whitespace-untabify activate compile)
  (untabify (point-min) (point-max)))

Does this help?

  Juanma

Re: whitespace-cleanup + untabify?

[Nikolaj Schumacher]

"dsevilla@gmail.com" <dsevilla@gmail.com> wrote:

> I'm a no tab person. I would like my whitespace-cleanup command to
> also perform an untabify. How can this be done? I haven't found any
> option that connects untabify and whitespace-cleanup. I'm using:

Just write your own command:

(defun my-whitespace-cleanup ()
  (interactive)
  (whitespace-cleanup)
  (untabify (point-min) (point-max)))


regards,
Nikolaj Schumacher

Re: whitespace-cleanup + untabify?

[Kevin Rodgers]

dsevilla@gmail.com wrote:
> I'm a no tab person. I would like my whitespace-cleanup command to
> also perform an untabify. How can this be done? I haven't found any
> option that connects untabify and whitespace-cleanup. I'm using:
> 
> GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.9)
> 
> I would really appreciate the help.

It's not documented, but because whitespace-global-mode is defined
via define-minor-mode there should be whitespace-global-mode-hook.
So perhaps something like this will work:

(add-hook 'whitespace-global-mode-hook
	  (lambda ()
	    (when whitespace-global-mode
	      (untabify (point-min) (point-max)))))

Alternatively, you could hook directly into find-file-hook,
write-file-functions, and kill-buffer-hook just like
whitespace-global-mode does.

-- 
Kevin Rodgers
Denver, Colorado, USA

Re: whitespace-cleanup + untabify?

[Juanma]

On Saturday 14 June 2008, dsevilla@gmail.com wrote:
> Dear all:
>
> I'm a no tab person. I would like my whitespace-cleanup command to
> also perform an untabify. How can this be done? I haven't found any
> option that connects untabify and whitespace-cleanup. I'm using:

It's easy to put things together in your own function:

(defun my-whitespace-cleanup ()
  (interactive)
  (whitespace-cleanup)
  (call-interactively 'untabify))

That's the quick&dirty-est way and you should mark a region to use it (as it
would be for 'untabify' anyway). Bind it to a key. Done.

But, does 'whitespace-cleanup' work for you? I mean, the documentation of
`whitespace-buffer' says:
+-----------------------------------------------------------------------------+
| 3. Indentation space (8 or more spaces, that should be replaced with TABS). |
+-----------------------------------------------------------------------------+

Saludos,
Juan

Re: whitespace-cleanup + untabify?

[Rupert Swarbrick]

"dsevilla@gmail.com" <dsevilla@gmail.com> writes:

> Dear all:
>
> I'm a no tab person. I would like my whitespace-cleanup command to
> also perform an untabify. How can this be done? I haven't found any
> option that connects untabify and whitespace-cleanup. I'm using:
>
> GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.9)
>
> I would really appreciate the help.
>
> Regards,
> diego.

I hope I've understood the problem correctly: it seems you want a
command to run whitespace-cleanup and untabify on the current
buffer. As far as I know such a command doesn't exist...

(defun both-cleanups ()
  (interactive)
  (untabify (point-min) (point-max))
  (whitespace-cleanup))

... well, it does now!

I must admit I've never used whitespace-cleanup before, and can't get
it to do anything! But that applies to calling it manually too, so I
presume this will work ok for you.

You probably want to give it a better name and/or a keybinding.

Rupert

Re: whitespace-cleanup + untabify?

[dsevilla]

On Jun 14, 5:02 pm, Rupert Swarbrick <rswarbr...@gmail.com> wrote:
> "dsevi...@gmail.com" <dsevi...@gmail.com> writes:
> > Dear all:
>
> > I'm a no tab person. I would like my whitespace-cleanup command to
> > also perform an untabify. How can this be done? I haven't found any
> > option that connects untabify and whitespace-cleanup. I'm using:
>
> > GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.9)
>
> > I would really appreciate the help.
>
> > Regards,
> > diego.
>
> I hope I've understood the problem correctly: it seems you want a
> command to run whitespace-cleanup and untabify on the current
> buffer. As far as I know such a command doesn't exist...
>
> (defun both-cleanups ()
>   (interactive)
>   (untabify (point-min) (point-max))
>   (whitespace-cleanup))
>
> ... well, it does now!
>
> I must admit I've never used whitespace-cleanup before, and can't get
> it to do anything! But that applies to calling it manually too, so I
> presume this will work ok for you.
>
> You probably want to give it a better name and/or a keybinding.
>
> Rupert

Really thanks, Rupert, that was it.

I thought you could configure whitespace cleanup command (that is, the
Whitespace group of Emacs) so that you could decide either if several
spaces were converted to a tab (depending on the default tab size or
the one defined locally for the buffer) or just all the tabs and
spaces were converted to just spaces.

Thanks again, I'll try this.

diego.

Re: whitespace-cleanup + untabify?

[Lennart Borgman (gmail)]

dsevilla@gmail.com wrote:
> Dear all:
> 
> I'm a no tab person. I would like my whitespace-cleanup command to
> also perform an untabify. How can this be done? I haven't found any
> option that connects untabify and whitespace-cleanup. I'm using:
> 
> GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.9)


I have never used whitespace-cleanup (I use delete-trailing-whitespace), 
  but from the doc of this function it looks like it also untabifies if 
`indent-tabs-mode' is nil. Does not that work?

Re: whitespace-cleanup + untabify?

[Nikolaj Schumacher]

Kevin Rodgers <kevin.d.rodgers@gmail.com> wrote:

> It's not documented, but because whitespace-global-mode is defined
> via define-minor-mode there should be whitespace-global-mode-hook.
> So perhaps something like this will work:
>
> (add-hook 'whitespace-global-mode-hook
> 	  (lambda ()
> 	    (when whitespace-global-mode
> 	      (untabify (point-min) (point-max)))))

That won't work.  It will probably only untabify the .emacs file.

It should instead add an `untabify' variant to
'find-file-hook, 'write-file-functions and 'kill-buffer-hook.

Of course that would ignore the setting of `whitespace-auto-cleanup',
and would stay active after the mode has been disabled.

I think the cleanest way would be a parallel mode:

(defun untabify-buffer ()
  (untabify (point-min) (point-max))
  nil ;; for write-file-functions
  )

(define-minor-mode untabify-global-mode
  :global t
  :group 'whitespace
  (if untabify-global-mode
      (progn
	(add-hook 'find-file-hook 'untabify-buffer)
	(add-hook 'write-file-functions 'untabify-buffer nil t)
	(add-hook 'kill-buffer-hook 'untabify-buffer))
    (remove-hook 'find-file-hook 'untabify-buffer)
    (remove-hook 'write-file-functions 'untabify-buffer t)
    (remove-hook 'kill-buffer-hook 'untabify-buffer)))

(Not tested.)


regards,
Nikolaj Schumacher

Re: whitespace-cleanup + untabify?

[dsevilla]

On Jun 14, 3:43 pm, Juanma <juanma_bel...@yahoo.es> wrote:
> On Saturday 14 June 2008, dsevi...@gmail.com wrote:
>
> > Dear all:
>
> > I'm a no tab person. I would like my whitespace-cleanup command to
> > also perform an untabify. How can this be done? I haven't found any
> > option that connects untabify and whitespace-cleanup. I'm using:
>
> It's easy to put things together in your own function:
>
> (defun my-whitespace-cleanup ()
>   (interactive)
>   (whitespace-cleanup)
>   (call-interactively 'untabify))
>
> That's the quick&dirty-est way and you should mark a region to use it (as it
> would be for 'untabify' anyway). Bind it to a key. Done.
>
> But, does 'whitespace-cleanup' work for you? I mean, the documentation of
> `whitespace-buffer' says:
> +-----------------------------------------------------------------------------+
> | 3. Indentation space (8 or more spaces, that should be replaced with TABS). |
> +-----------------------------------------------------------------------------+
>
> Saludos,
> Juan

Hello, Juan:

Yes, it has worked always. It does what it should do, but certain tabs
weren't converted to spaces (as I wanted) and/or it inserted tabs (I
haven't tested this one, but still). What I wanted was to remove tabs
and substitute them by spaces. The solutions of defining a new
function worked nicely.

Thanks,
diego.

Re: whitespace-cleanup + untabify?

[dsevilla]

On Jun 14, 6:24 pm, "Lennart Borgman (gmail)"
<lennart.borg...@gmail.com> wrote:
> dsevi...@gmail.com wrote:
> > Dear all:
>
> > I'm a no tab person. I would like my whitespace-cleanup command to
> > also perform an untabify. How can this be done? I haven't found any
> > option that connects untabify and whitespace-cleanup. I'm using:
>
> > GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.9)
>
> I have never used whitespace-cleanup (I use delete-trailing-whitespace),
>   but from the doc of this function it looks like it also untabifies if
> `indent-tabs-mode' is nil. Does not that work?

Hi, Lennart:

Yes, that's what I thought, but was not the case, as if I applied
whitespace-cleanup and then untabify, the file was modified (that is,
it still converted *some* tabs to spaces), so I assumed it didn't work
this way. I had indent-tabs-mode set to nil also.

Thanks,
diego.

Re: whitespace-cleanup + untabify?

[Lennart Borgman (gmail)]

dsevilla@gmail.com wrote:
> On Jun 14, 6:24 pm, "Lennart Borgman (gmail)"
> <lennart.borg...@gmail.com> wrote:
>> dsevi...@gmail.com wrote:
>>> Dear all:
>>> I'm a no tab person. I would like my whitespace-cleanup command to
>>> also perform an untabify. How can this be done? I haven't found any
>>> option that connects untabify and whitespace-cleanup. I'm using:
>>> GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.9)
>> I have never used whitespace-cleanup (I use delete-trailing-whitespace),
>>   but from the doc of this function it looks like it also untabifies if
>> `indent-tabs-mode' is nil. Does not that work?
> 
> Hi, Lennart:
> 
> Yes, that's what I thought, but was not the case, as if I applied
> whitespace-cleanup and then untabify, the file was modified (that is,
> it still converted *some* tabs to spaces), so I assumed it didn't work
> this way. I had indent-tabs-mode set to nil also.
> 
> Thanks,
> diego.

Hi diego

In that case it looks like a bug to me. Could you please send a bug report

   M-x report-emacs-bug

You need to attach an example and exact instructions (starting from 
"emacs -Q").

Thanks.

Re: whitespace-cleanup + untabify?

[Nikolaj Schumacher]

"Lennart Borgman (gmail)" <lennart.borgman@gmail.com> wrote:

>>> I have never used whitespace-cleanup (I use delete-trailing-whitespace),
>>>   but from the doc of this function it looks like it also untabifies if
>>> `indent-tabs-mode' is nil. Does not that work?
>>
>> Yes, that's what I thought, but was not the case, as if I applied
>> whitespace-cleanup and then untabify, the file was modified (that is,
>> it still converted *some* tabs to spaces), so I assumed it didn't work
>> this way. I had indent-tabs-mode set to nil also.
>
> In that case it looks like a bug to me. Could you please send a bug report

From the documentation it appears to me that it will transform 8
spaces to tabs, but not vice-versa.  So I don't think it's necessarily a
bug.  But I do think it would be a good feature to add.


regards,
Nikolaj Schumacher

Re: whitespace-cleanup + untabify?

[Lennart Borgman (gmail)]

Nikolaj Schumacher wrote:
> "Lennart Borgman (gmail)" <lennart.borgman@gmail.com> wrote:
> 
>>>> I have never used whitespace-cleanup (I use delete-trailing-whitespace),
>>>>   but from the doc of this function it looks like it also untabifies if
>>>> `indent-tabs-mode' is nil. Does not that work?
>>> Yes, that's what I thought, but was not the case, as if I applied
>>> whitespace-cleanup and then untabify, the file was modified (that is,
>>> it still converted *some* tabs to spaces), so I assumed it didn't work
>>> this way. I had indent-tabs-mode set to nil also.
>> In that case it looks like a bug to me. Could you please send a bug report
> 
>>From the documentation it appears to me that it will transform 8
> spaces to tabs, but not vice-versa.  So I don't think it's necessarily a
> bug.  But I do think it would be a good feature to add.

You might be right about the doc, I don't understand it ;-)

It looks like a simple alternative that is equivalent to untabify + 
delete-trailing-whitespace indeed is a good feature to add.

Re: whitespace-cleanup + untabify?

[Thierry Volpiatto]

"Lennart Borgman (gmail)" <lennart.borgman@gmail.com> writes:

> Nikolaj Schumacher wrote:
>> "Lennart Borgman (gmail)" <lennart.borgman@gmail.com> wrote:
>>
>>>>> I have never used whitespace-cleanup (I use delete-trailing-whitespace),
>>>>>   but from the doc of this function it looks like it also untabifies if
>>>>> `indent-tabs-mode' is nil. Does not that work?
>>>> Yes, that's what I thought, but was not the case, as if I applied
>>>> whitespace-cleanup and then untabify, the file was modified (that is,
>>>> it still converted *some* tabs to spaces), so I assumed it didn't work
>>>> this way. I had indent-tabs-mode set to nil also.
>>> In that case it looks like a bug to me. Could you please send a bug report
>>
>>>From the documentation it appears to me that it will transform 8
>> spaces to tabs, but not vice-versa.  So I don't think it's necessarily a
>> bug.  But I do think it would be a good feature to add.
>
> You might be right about the doc, I don't understand it ;-)
>
> It looks like a simple alternative that is equivalent to untabify +
> delete-trailing-whitespace indeed is a good feature to add.
>
>
Hello all,
did somebody try something like:

,----
| (add-hook 'picture-mode-hook 'untabify)
`----

Not tested but it should work.
-- 
A + Thierry
Pub key: http://pgp.mit.edu