From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.help Subject: Re: Dired shell command on file asymchronously Date: Fri, 24 Jun 2005 15:19:22 -0600 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1119648217 17069 80.91.229.2 (24 Jun 2005 21:23:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 24 Jun 2005 21:23:37 +0000 (UTC) Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Fri Jun 24 23:23:36 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DlvdT-0000oF-Ma for geh-help-gnu-emacs@m.gmane.org; Fri, 24 Jun 2005 23:22:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dlvka-0003e0-0i for geh-help-gnu-emacs@m.gmane.org; Fri, 24 Jun 2005 17:30:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DlvhG-0003Dh-0k for help-gnu-emacs@gnu.org; Fri, 24 Jun 2005 17:26:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dlvgy-00033s-6G for help-gnu-emacs@gnu.org; Fri, 24 Jun 2005 17:26:33 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dlvgy-0002zP-3u for help-gnu-emacs@gnu.org; Fri, 24 Jun 2005 17:26:28 -0400 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtp (TLS-1.0:RSA_AES_128_CBC_SHA:16) (Exim 4.34) id 1Dlvf2-0005A9-Ic for help-gnu-emacs@gnu.org; Fri, 24 Jun 2005 17:24:28 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1DlvUK-0007Xq-Eu for help-gnu-emacs@gnu.org; Fri, 24 Jun 2005 23:13:24 +0200 Original-Received: from 207.167.42.60 ([207.167.42.60]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 24 Jun 2005 23:13:24 +0200 Original-Received: from ihs_4664 by 207.167.42.60 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 24 Jun 2005 23:13:24 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: help-gnu-emacs@gnu.org Original-Lines: 28 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 207.167.42.60 User-Agent: Mozilla Thunderbird 0.9 (X11/20041105) X-Accept-Language: en-us, en In-Reply-To: X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:27641 X-Report-Spam: http://spam.gmane.org/gmane.emacs.help:27641 Josef.Bauer.NOSPAM@web.de wrote: > I just found that I added a minor improvement in the meantime. Using > 'shell-quote-argument' file names with spaces and such are working. > > Here is the new version: > > ;----------------------------------------------------------------- > (defun dired-do-shell-command-in-background (command) > "In dired, do shell command in background on the file or directory named on this line." > (interactive > (list (dired-read-shell-command (concat "& on " "%s: ") nil (list (dired-get-filename))))) > (call-process command nil 0 nil (shell-quote-argument (dired-get-filename)))) That doesn't make sense to me. call-process passes its &rest ARGS directly to PROGRAM, without any word-splitting etc. by the shell. So shell-quote-argument is unecessary, and in fact could introduce quoting characters that would be interpreted as part of the file name. If COMMAND is actually a shell command (i.e. with redirection operators etc.) then you must use shell-command instead of call-process. If it is just a program, then using call-process is fine -- but again, using shell-quote-argument with it is not. -- Kevin Rodgers