From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.help Subject: Re: Emacs 21 and w3 on Debian Date: Fri, 27 May 2005 10:35:20 -0600 Message-ID: References: <87sm0fbjx4.fsf@tiger.rapttech.com.au> <874qcvqar0.fsf@spamfoil.invalid> <87oeb2c2x5.fsf@tiger.rapttech.com.au> <87fywebcp7.fsf@tiger.rapttech.com.au> <87ll66pavk.fsf@spamfoil.invalid> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1117212315 7298 80.91.229.2 (27 May 2005 16:45:15 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 27 May 2005 16:45:15 +0000 (UTC) Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Fri May 27 18:45:08 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DbhuP-0004dn-HN for geh-help-gnu-emacs@m.gmane.org; Fri, 27 May 2005 18:42:06 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dbhyi-0003Ur-Dk for geh-help-gnu-emacs@m.gmane.org; Fri, 27 May 2005 12:46:32 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dbhxq-0002ss-TB for help-gnu-emacs@gnu.org; Fri, 27 May 2005 12:45:39 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dbhxn-0002rO-KW for help-gnu-emacs@gnu.org; Fri, 27 May 2005 12:45:37 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dbhxn-0002oo-48 for help-gnu-emacs@gnu.org; Fri, 27 May 2005 12:45:35 -0400 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtp (TLS-1.0:RSA_AES_128_CBC_SHA:16) (Exim 4.34) id 1Dbhsf-0004Pt-GS for help-gnu-emacs@gnu.org; Fri, 27 May 2005 12:40:17 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1DbhnA-0003A8-Ba for help-gnu-emacs@gnu.org; Fri, 27 May 2005 18:34:36 +0200 Original-Received: from 207.167.42.60 ([207.167.42.60]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 27 May 2005 18:34:36 +0200 Original-Received: from ihs_4664 by 207.167.42.60 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 27 May 2005 18:34:36 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: help-gnu-emacs@gnu.org Original-Lines: 53 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 207.167.42.60 User-Agent: Mozilla Thunderbird 0.9 (X11/20041105) X-Accept-Language: en-us, en In-Reply-To: X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:27024 X-Report-Spam: http://spam.gmane.org/gmane.emacs.help:27024 Klaus Straubinger wrote: > Kevin Rodgers wrote: >>How exactly is that improvement implemented? >> >>(cons redirect-uri url-callback-arguments) >> >>(if url-callback-arguments >> (cons redirect-uri (cdr url-callback-arguments)) >> (list redirect-uri)) > > I chose something like the second alternative: > > (if url-callback-arguments > (setcar url-callback-arguments redirect-uri) > (setq url-callback-arguments (list redirect-uri))) Is it necessary to destructively modify url-callback-arguments? I.e. is it used elsewhere that must reflect the redirection as well? Note that setcar does not return the modified cons, so I think that should be (asssuming setcar is indeed necessary): (if url-callback-arguments (progn (setcar url-callback-arguments redirect-uri) url-callback-arguments) (setq url-callback-arguments (list redirect-uri))) > The first would not be correct because the URL sometimes already > present as first argument in the url-callback-arguments list must be > replaced. Again: destructively, or just in this particular call to url-retrieve? > Would it work then to simply write > > (setq url-callback-arguments > (append (list redirect-uri) (cdr url-callback-arguments))) > > independent of the value of url-callback-arguments? Yes, it's not necessary to test url-callback-arguments and it's better to avoid destructive operations on lists unless you're sure of what you're doing. But (append (list x) ...) is better expressed as (cons x ...): (cons redirect-uri (cdr url-callback-arguments)) Again, why setq? Do you really need to change its global value? -- Kevin Rodgers