unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Kevin Rodgers <ihs_4664@yahoo.com>
Subject: Re: Defadvice use
Date: Mon, 18 Apr 2005 14:28:37 -0600	[thread overview]
Message-ID: <d41524$la4$1@sea.gmane.org> (raw)
In-Reply-To: <yg7hdi4gs5r.fsf@fermat.math.uvsq.fr>

Matthias wrote:
 > I have the following problem: How do I advice a function so that
 > within that function, the function `read-minibuffer' (for example)
 > calls the definition of another function, say `my-read-minibuffer'?
 >
 > I'm trying to use an advice around the function; the advice providing
 > a binding of the symbol `read-minibuffer' to the definition of
 > `my-read-minibuffer'. Like the following:
 >
 > (defadvice la-fonction
 >   (around la-fonction-extended enable compile)
 >   "Documentation"
 >    (let (f1)
 >      (fset 'f1 read-minibuffer)
 >      (fset 'read-minibuffer my-read-minibuffer)
 >      ad-do-it
 >      (fset 'read-minibuffer f1)))
 >
 > Any comment? Is it silly? Is there a better way? Any idea?

Here's how I'd do it:

(defvar la-fonction-read-minibuffer nil
   "If non-nil, the function to call instead of `read-minibuffer'.")

(defadvice read-minibuffer (around la-fonction activate)
   "If `la-fonction-read-minibuffer' is non-nil, call it and return its 
result
instead."
   (if la-fonction-read-minibuffer
       (apply la-fonction-read-minibuffer (ad-get-args 0))
     ad-do-it))

(defadvice la-fonction (around read-minibuffer activate)
   "Temporarily bind `la-fonction-read-minibuffer' to `my-read-minibuffer'."
   (let ((la-fonction-read-minibuffer 'my-read-minibuffer))
     ad-do-it))

-- 
Kevin Rodgers

      parent reply	other threads:[~2005-04-18 20:28 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-18 12:56 Defadvice use Matthias
2005-04-18 17:11 ` rgb
2005-04-18 17:25   ` Johan Bockgård
2005-04-18 19:05     ` rgb
2005-04-18 19:43       ` Stefan Monnier
2005-04-19  0:15         ` rgb
2005-04-19  0:28           ` Stefan Monnier
2005-04-19  3:48             ` Mis-features of let (was Defadvice use) rgb
2005-04-19  4:31               ` Mis-features of let Stefan Monnier
2005-04-19  6:38                 ` rgb
2005-04-19 12:21                   ` Stefan Monnier
2005-04-19 20:31                     ` rgb
2005-04-19 21:45                       ` David Kastrup
2005-04-19 12:55                   ` Barry Margolin
2005-04-19 20:31                     ` rgb
2005-04-20  4:12                       ` Barry Margolin
2005-04-19 21:10                     ` rgb
2005-04-19 21:57                       ` Kevin Rodgers
2005-04-19 22:00                       ` David Kastrup
2005-04-20  1:04                         ` rgb
2005-04-20 10:04                           ` David Kastrup
2005-04-20 11:57                             ` Stefan Monnier
2005-04-20 14:41                           ` Thien-Thi Nguyen
2005-04-19  9:41               ` Thien-Thi Nguyen
2005-04-19  5:07           ` Defadvice use Barry Margolin
2005-04-18 17:52 ` Stefan Monnier
2005-04-18 21:07   ` Matthias
2005-04-18 23:20     ` Stefan Monnier
2005-04-18 20:28 ` Kevin Rodgers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='d41524$la4$1@sea.gmane.org' \
    --to=ihs_4664@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).