From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Lowell Kirsh Newsgroups: gmane.emacs.help Subject: Re: elisp macros problem Date: Tue, 27 Jul 2004 01:10:51 -0700 Organization: Department of Computer Science, UBC Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1090915955 4798 80.91.224.253 (27 Jul 2004 08:12:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 27 Jul 2004 08:12:35 +0000 (UTC) Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Tue Jul 27 10:12:28 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BpN4V-0008Ne-00 for ; Tue, 27 Jul 2004 10:12:27 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BpN7a-0007G5-8x for geh-help-gnu-emacs@m.gmane.org; Tue, 27 Jul 2004 04:15:38 -0400 Original-Path: shelby.stanford.edu!newsfeed.stanford.edu!cyclone.bc.net!nntp.cs.ubc.ca!cs.ubc.ca!not-for-mail Original-Newsgroups: gnu.emacs.help,comp.lang.lisp Original-Lines: 82 Original-NNTP-Posting-Host: okanagan.cs.ubc.ca Original-X-Trace: mughi.cs.ubc.ca 1090915855 26678 142.103.7.18 (27 Jul 2004 08:10:55 GMT) Original-X-Complaints-To: usenet@cs.ubc.ca Original-NNTP-Posting-Date: Tue, 27 Jul 2004 08:10:55 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.1) Gecko/20040707 X-Accept-Language: en-us, en In-Reply-To: Original-Xref: shelby.stanford.edu gnu.emacs.help:124489 comp.lang.lisp:144257 Original-To: help-gnu-emacs@gnu.org X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.help:19825 X-Report-Spam: http://spam.gmane.org/gmane.emacs.help:19825 Hmmm, I was only trying to use macros because I thought what I was trying wasn't possible with functions. Would this be a more appropriate approach? (defun my-add-hook (hook &rest body) (add-hook (intern (concat (symbol-name hook) "-mode-hook")) `(lambda () ,@body))) and then call it like: (my-add-hook 'lisp-interaction '(my-translate-paren-types) '(imenu-add-to-menubar "Symbols") ) This seems a little more verbose with all the quotes, but I guess it could be the 'better' approach since it avoids using macros. Perhaps my macro approach was a crock. The only reason I defended it was becuase I thought you meant that creating the my-add-hook functionality itself was the crock. Well, I'm going with functions now, and I'm also going to get back to reading Paul Graham's 'On Lisp', the only comprehensive lisp macros book I know of (are there others?) Lowell David Kastrup wrote: > Lowell Kirsh writes: > > >>This still doesn't seem to work. With the following defun and call: >> >>(defmacro my-add-hooks (hooks &rest body) >> `(dolist (hook ',hooks) >> (my-add-hook hook ,@body))) >> >>(my-add-hooks (inferior-lisp lisp emacs-lisp lisp-interaction) >> (imenu-add-to-menubar "Symbols")) >> >>I get the following macroexpansion, which looks correct to me, but >>doesn't actually do anything: >> >>(cl-block-wrapper >> (catch (quote --cl-block-nil--) >> (let ((--dolist-temp--20870 (quote (inferior-lisp lisp emacs-lisp >> lisp-interaction))) >> hook) >> (while --dolist-temp--20870 >> (setq hook (car --dolist-temp--20870)) >> (my-add-hook hook >> (imenu-add-to-menubar "Symbols")) >> (setq --dolist-temp--20870 (cdr --dolist-temp--20870))) >> nil))) > > > That's because my-add-hook is a macro, too, and so you just add stuff > to hook-mode-hook three times. > > >>>Apart from that, I consider this sort of thing a crock. What are >>>you hoping to achieve that you would not be better off doing by a >>>proper function instead of a macro? > > > In short, I still consider this sort of thing a crock, since you'd be > better off using a function instead of a macro. You are unable to > comprehend what your macros do, and it shows. Macros are just not > sensible for this sort of thing. Use functions instead. You'll need > to use some quotes at the outer level, but you'll understand what > happens. > > To fix the above, you'd need to write something like > > (defmacro my-add-hooks (hooks &rest body) > (dolist (hook hooks) > `(my-add-hook ,hook ,@body))) > >