Trying to disable the fontification of strings in fundamental-mode

Trying to disable the fontification of strings in fundamental-mode

[Davin Pearson]

I am trying to turn off the fonfication of strings in
fundamental
mode.  The following code appears to turn it off in *all* modes,
not
just fundamental mode.  What do I need to do to restrict
the
suppressing of the fontification of strings to just fundamental
mode?

(defadvice fundamental-mode (before my-remove-strings
activate)
  (if (eq major-mode 'fundamental-
mode)
      (setq font-lock-string-face
nil)))

(defadvice fundamental-mode (after my-remove-strings
activate)
  (if (eq major-mode 'fundamental-
mode)
      (setq font-lock-string-face
nil)))

Re: Trying to disable the fontification of strings in fundamental-mode

[Nikolaj Schumacher]

Davin Pearson <davin.pearson@gmail.com> wrote:

> What do I need to do to restrict the suppressing of the fontification
> of strings to just fundamental mode?

First of all, don't use advice for this!  Use hooks, which are cleaner
and safer.

Second of all, setq changes the variable globally, so naturally it is
disabled everywhere.  You need to make the variable buffer-local.

(defun my-fundamental-mode-hook ()
  (set (make-variable-buffer-local 'font-lock-string-face) nil))

(add-hook 'fundamental-mode-hook 'my-fundamental-mode-hook)

regards,
Nikolaj Schumacher

Re: Trying to disable the fontification of strings in fundamental-mode

[Davin Pearson]

On Sep 12, 8:57 pm, Nikolaj Schumacher <m...@nschum.de> wrote:
> Davin Pearson <davin.pear...@gmail.com> wrote:
> > What do I need to do to restrict the suppressing of the fontification
> > of strings to just fundamental mode?
>
> First of all, don't use advice for this!  Use hooks, which are cleaner
> and safer.
>
> Second of all, setq changes the variable globally, so naturally it is
> disabled everywhere.  You need to make the variable buffer-local.
>
> (defun my-fundamental-mode-hook ()
>   (set (make-variable-buffer-local 'font-lock-string-face) nil))
>
> (add-hook 'fundamental-mode-hook 'my-fundamental-mode-hook)

The above code doesn't work as there is no Emacs hook called
fundamental-mode-hook

Following your advice about local variables I also tried the
following:

(defadvice fundamental-mode (before my-remove-strings
activate)
  (if (eq major-mode 'fundamental-
mode)
      (set (make-variable-buffer-local 'font-lock-string-face)
nil)))

(defadvice fundamental-mode (after my-remove-strings
activate)
  (if (eq major-mode 'fundamental-
mode)
      (set (make-variable-buffer-local 'font-lock-string-face) nil)))

and both of these don't work either.

What gives?

Re: Trying to disable the fontification of strings in fundamental-mode

[Davin Pearson]

I managed to get the following code to work:

> (defadvice fundamental-mode (after my-remove-strings
> activate)
>   (if (eq major-mode 'fundamental-
> mode)
>       (set (make-variable-buffer-local 'font-lock-string-face) nil)))

I don't see the problem about using advice.  I use advice all of the
time in Emacs.

Re: Trying to disable the fontification of strings in fundamental-mode

[Nikolaj Schumacher]

Davin Pearson <davin.pearson@gmail.com> wrote:

> I managed to get the following code to work:
>
>> (defadvice fundamental-mode (after my-remove-strings
>> activate)
>>   (if (eq major-mode 'fundamental-
>> mode)
>>       (set (make-variable-buffer-local 'font-lock-string-face) nil)))

Sorry that I missed that there's no `fundamental-mode-hook'.  You can
use `after-change-major-mode-hook' instead.  You'll still need to test
the major-mode variable the way you did.

Also the right function is `make-local-variable', not
`make-variable-buffer-local'.  Sorry, I always mix those up.

> I don't see the problem about using advice.  I use advice all of the
> time in Emacs.

Advice can certainly do the job.  But they are a very powerful tool that
can break a lot of stuff, unless you're careful.  Hooks are made for
this very purpose, however.

Some discussion about this is here:
http://www.emacswiki.org/cgi-bin/wiki/AdviceVsHooks


regards,
Nikolaj Schumacher