From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Heime Newsgroups: gmane.emacs.help Subject: Re: Introducing face in comments for various modes Date: Mon, 12 Dec 2022 14:46:49 +0000 Message-ID: References: <9ZK1Solghrmps4AarUsz2E6-mAdkrTZoXPs4RTRTd9sZ0Cd8DGhK955im1kuug-EZXU3tc5rgDDd16vQexxpFnMvMFjFqnNnh0noashyLdE=@protonmail.com> <0RJB0bPRTMAqXlUbL2kGUvJtnCNPYwPhqTNi_l9nIpQAciTZYcYCikFVqi2Nr_UZLbT1_DRtX8G0dSkgI4jln5DTYBDxLz4i7L2d9wx-kA8=@protonmail.com> <21708ec2-d908-4e91-6c0a-4b1cd253e707@gmail.com> <009361a1-4430-ac3a-f395-ce32f10b31f2@gmail.com> <2aa0cf5a-c324-6b44-6247-6a20f0be3981@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23157"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , help-gnu-emacs@gnu.org To: Thibaut Verron Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 12 15:47:29 2022 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4k5Z-0005mQ-6s for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 12 Dec 2022 15:47:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4k5C-0004mH-O3; Mon, 12 Dec 2022 09:47:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4k5A-0004k0-Cn for help-gnu-emacs@gnu.org; Mon, 12 Dec 2022 09:47:04 -0500 Original-Received: from mail-40135.protonmail.ch ([185.70.40.135]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4k58-0006M2-5C for help-gnu-emacs@gnu.org; Mon, 12 Dec 2022 09:47:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1670856419; x=1671115619; bh=ZCn1I0Myuik34BuPxVG4/gtrZp4l8qTwGxEh8zUxoYo=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=d70pVQrOsAHV1vXXQU+kaR8Op1BJMvLjV7gWMGCX637zu9GP3Y0Rp5/K5af9ZNntn CxBRK9HGoucAIJSrVx8++ypFl9dl6m89JjW043ab6RXJZz2TlRGrZwwwK0WrbxTrJy FC8trfXww12Rij3UDQpkZ5sEHDFl8xskep6NtfYtDbXI45qirqzWKqXDyUQ06shPDS 1vWwAudo882kfpX0gt56qE35mrrrnAVv6Dwv3zz9Em0e19pci39GoBb0uoBgMC9Bpd bPpkrgmqCwUWUW5r+py2b+ZRBdNG3bmicq/0W6q+dk4VGuBJRzgvhJSOop2fl572hQ uu2WxDkiO8TTg== In-Reply-To: <2aa0cf5a-c324-6b44-6247-6a20f0be3981@gmail.com> Feedback-ID: 57735886:user:proton Received-SPF: pass client-ip=185.70.40.135; envelope-from=heimeborgia@protonmail.com; helo=mail-40135.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:141674 Archived-At: Returning back to the code presented. Do you know how I could use a generi= c variable for the different programming languages for the comment characte= r ? So I won't have to hardwire ";;" inside the regex.=20 ------- Original Message ------- On Monday, December 12th, 2022 at 12:17 PM, Thibaut Verron wrote: > On 12/12/2022 12:55, Heime wrote: >=20 > > ------- Original Message ------- > > On Monday, December 12th, 2022 at 10:50 AM, Thibaut Verron thibaut.verr= on@gmail.com wrote: > >=20 > > > On 12/12/2022 11:20, Heime wrote: > > >=20 > > > > ------- Original Message ------- > > > > On Monday, December 12th, 2022 at 9:58 AM, Thibaut Verronthibaut.ve= rron@gmail.com wrote: > > > >=20 > > > > > On 12/12/2022 10:21, Heime wrote: > > > > >=20 > > > > > > ------- Original Message ------- > > > > > > On Monday, December 12th, 2022 at 8:49 AM, Thibaut Verron > > > > > > thibaut.verron@gmail.com wrote: > > > > > >=20 > > > > > > > Le lun. 12 d=C3=A9c. 2022 =C3=A0 04:01, Heimeheimeborgia@prot= onmail.com a > > > > > > > =C3=A9crit : > > > > > > >=20 > > > > > > > ------- Original Message ------- > > > > > > > On Monday, December 12th, 2022 at 2:24 AM, Heime > > > > > > > heimeborgia@protonmail.com wrote: > > > > > > >=20 > > > > > > > > The colors of the standard themes are chosen with its (ligh= t) > > > > > > > > background in mind. If you change that background, it is no= t > > > > > > > > surprising that things fall apart. > > > > > > > > Choosing colours with a light background in mind is the wro= ng approach > > > > > > > > because colours produce far greater visual > > > > > > > > impact. > > > > > > > > There is no right or wrong approach, but individual prefere= nces. > > > > > > > > Standard metrics exist. The Gnu Project like many others, d= oes not > > > > > > > > want to use them. > > > > > > > > You're moving the goalpost: the sentence I quoted claimed t= hat "focusing > > > > > > > > on a light background is the wrong approach". > > > > > > > > Having worked with modus-themes, it was concluded that ther= e exist greater > > > > > > > > variations in possibilities with a dark background that wit= h a light one. >=20 >=20 > Great for themes with a black background. >=20 > That doesn't make it "wrong" for a theme to have a light background. >=20 > > > It's already bad enough now with some packages defining their own fac= es > > > without at least inheriting from the standard ones. > > > Right. My focus has been to provide colours with good metrics so that > > > people inherit from the standard ones. >=20 >=20 > That's called designing a theme. Aka the current approach. Which you > have been arguing is wrong. >=20 > > > There are currently 5330 packages on Melpa. Do you plan to contact th= e > > > authors of all of them individually to get them to implement your > > > preferred colors? > > > To start using actual standards. Absolutely, they should learn more a= nd change > > > their packages. >=20 >=20 > Great. Good luck with that. >=20 > On the other hand, the current recommended approach is to inherit from > existing faces and let theme designers (or users, if they choose to) > populate those with suitable colors. >=20 > No need for package developers to implement standards, no need to learn > about theme design, no need to change things to accommodate for > user-preferred colors, and if you have a problem, only one bug report to > file -- with the theme. >=20 > > > > > You shouldn't think of themes as "fixing the default choices" > > > > > (especially considering that you are the one "breaking" them by > > > > > insisting to use them with a background they weren't designed for= ). > > > > > Their purpose is to implement different choices in a consistent w= ay. > > > > > Good design in much more important that consistency. > > > > > It's also much easier to achieve in a consistent system. > > > > > The argument is to design separately for light and also for dark = background. > > > > > Emacs does have light and dark checks. >=20 >=20 > That's again, moving the point. >=20 > Yes, Emacs does have those checks, but it's just a different way of > providing two themes for light and dark backgrounds. If done for full > themes, it's only a formal change, between two separate theme > definitions, or one with interleaved conditionals. >=20 > If done for only a subset of faces, leaving the others untouched, it's a > poor-person's way to try to accommodate everything, but it's imperfect > and it might be unreadable on themes which are far from the standard > white or black (not to mention terminal users). For that use-case, it is > usually preferred to find an existing face to inherit from, trusting the > theme designers for this face to be rendered in a readable way. >