Re: completion-ui.el question: my vimpulse-show-completion-menu function always gives me an empty menu

Re: completion-ui.el question: my vimpulse-show-completion-menu function always gives me an empty menu

[Jason Spiro]

Hi list, hello Toby,

As you may know, I am working on vimpulse[1] which extends viper-mode
to emulate the most useful Vim keys in Emacs.  I am hoping to add C-n
and C-p completion to vimpulse, and I am wondering how to do so.

I am hoping to use hippie-expand because it can complete:

- words,
- filenames, and
- entire buffer lines

among other things.[2]  Dabbrev seems to basically only complete
words.  I am trying to emulate Vim's completion behavior, and Vim can
complete all those things and more.[3]

> As an Elisp coder, you're not supposed to invoke *any* completion
> interface explicitly, as you've tried to do. Deciding which combination
> of user-interfaces to use is the user's business, not the package
> writer's. Maybe some users want to use menu completion, but others
> prefer to see a list in the echo area, whilst still others just want a
> tooltip to popup after a delay, etc. etc. Completion-UI offloads those
> choices onto the user, which is where they should be.

OK.  I will tell vimpulse users they should set certain Completion-UI
settings themselves to get something closer to Vim completion.  But
meanwhile, I still have a question about the code I am writing myself
for testing purposes.

;; Begin code {{{

(require 'completion-ui)

;; Note: This code has an additional bug in addition to the problem I
;; am asking about in this mailing list message:
;; When called with a MAXNUM of nil, this func sometimes fails.  (Seems
;; to work the first time, then fail all times after, in such cases.
;; To fix, call with a normal MAXNUM.)
(defun vimpulse-try-hippie-expand-listed-functions (prefix &optional maxnum)
;  (interactive "*MString to expand:
;nMaximum number of expansions, or nil for unlimited: ")
 (setq expansions nil)
 (with-temp-buffer
   (insert-string prefix)
   (hippie-expand nil)
   (unless (string-equal (current-message) "No expansion found")
     (while (and
             (not (string-equal
                   (current-message)
                   "No further expansions found"))
             (if maxnum (not (= (length expansions) maxnum))))
       ;; Hippie-expand was designed to be run interactively.  If
       ;; this-command and last-command are equal, it assumes it's
       ;; being called as a "repeated use" (additional call without
       ;; moving the point) and searches for additional expansions
       ;; with the same prefix.  So, make this-command and
       ;; last-command equal.
       (setq this-command last-command)
       (hippie-expand nil)
       (add-to-list 'expansions (buffer-string))
       (buffer-string)
     ))
   expansions))

(defun jason-problem-demo ()
 (interactive)
 (setq-default completion-function
'vimpulse-try-hippie-expand-listed-functions)
 (setq completion-function 'vimpulse-try-hippie-expand-listed-functions)
 ;; is this always necessary?  Am I even ever supposed to call it?
 (completion-setup-overlay 'prefix)
 (completion-show-menu))

;; }}} End code

Whenever I start typing a word then run
M-x jason-problem-demo I get an empty menu.  Why?

Am I using
completion-show-menu wrong?  It errors on me if I don't call
completion-setup-overlay first, so I call it first.  Should I?

Cheers,
Jason[5]

[1] http://www.emacswiki.org/cgi-bin/wiki/vimpulse.el

[2] Unfortunately hippie-expand can't complete multiple-word sequences
like dabbrev can when you press M-/ SPC M-/ SPC M-/.  Vim can do it:
just press CTRL-X CTRL-P repeatedly.  But I hope I'll eventually fix
that.

Then again, maybe I'll never have time to make that change to
hippie-expand.  So maybe I should have Completion-UI call
dabbrev-expand instead.

[3] e.g. CTRL-X CTRL-T for thesaurus completion, or many other[4] things.

[4] http://ianua.initd.org/vimit/vim63/html/insert.html#ins-completion

[5] P.S. You may want to mention in the completion-ui documentation at
the top of the file that
http://www.emacswiki.org/cgi-bin/wiki/CompletionUI#toc2 has examples
of how to use completion-ui with dabbrev and etags.  If I knew that
info, it would have saved me time. :-)

-- 
Jason Spiro: computer consulting with a smile.
I provide software development and training services to clients worldwide.
Contact me for a FREE consultation. Satisfaction guaranteed.
+1 (416) 781-5938 / Email: info@jspiro.com / MSN: jasonspiro@hotmail.com

Re: Fwd: completion-ui.el question: my vimpulse-show-completion-menu function always gives me an empty menu

[Toby Cubitt]

Jason A. Spiro wrote:
>> As an Elisp coder, you're not supposed to invoke *any* completion
>> interface explicitly, as you've tried to do. Deciding which combination
>> of user-interfaces to use is the user's business, not the package
>> writer's. Maybe some users want to use menu completion, but others
>> prefer to see a list in the echo area, whilst still others just want a
>> tooltip to popup after a delay, etc. etc. Completion-UI offloads those
>> choices onto the user, which is where they should be.
> 
> OK.  I will tell vimpulse users they should set certain Completion-UI
> settings themselves to get something closer to Vim completion.  But
> meanwhile, I still have a question about the code I am writing myself
> for testing purposes.

I now understand a bit better what you're trying to do. I guess in the 
special case of trying to emulate vim, my arguments are specious, since 
you *want* to make user-interface choices for the user. So I guess 
vimpulse-mode could set the completion-ui customization variables 
appropriately. However, the main point still stands: you shouldn't be 
calling any internal completion-ui functions (such as completion-menu) 
from your own code.


> ;; Begin code {{{
> 
> (require 'completion-ui)
> 
> ;; Note: This code has an additional bug in addition to the problem I
> ;; am asking about in this mailing list message:
> ;; When called with a MAXNUM of nil, this func sometimes fails.  (Seems
> ;; to work the first time, then fail all times after, in such cases.
> ;; To fix, call with a normal MAXNUM.)

This might cause problems later, since completion-UI occasionally needs 
to call it with a nil MAXNUM. The function is then supposed to return a 
list of all possible completions.

BTW, I realise that setting up a temporary buffer and simulating an 
interactive call to hippie-expand is a simple way to get what you want, 
but it also seems a bit ugly to me. Hippie-expand contains a lot of code 
that deals with user-interface issues, and you're using completion-UI 
for that. Wouldn't it be better to read through the hippie-expand code, 
work out which internal function returns the list of completions as its 
return value, and call that instead? It's more work, but also less ugly, 
more efficient, and I suspect more robust.


> (defun vimpulse-try-hippie-expand-listed-functions (prefix &optional 
> maxnum)
> ;  (interactive "*MString to expand:
> ;nMaximum number of expansions, or nil for unlimited: ")
> (setq expansions nil)
> (with-temp-buffer
>   (insert-string prefix)
>   (hippie-expand nil)
>   (unless (string-equal (current-message) "No expansion found")
>     (while (and
>             (not (string-equal
>                   (current-message)
>                   "No further expansions found"))
>             (if maxnum (not (= (length expansions) maxnum))))
>       ;; Hippie-expand was designed to be run interactively.  If
>       ;; this-command and last-command are equal, it assumes it's
>       ;; being called as a "repeated use" (additional call without
>       ;; moving the point) and searches for additional expansions
>       ;; with the same prefix.  So, make this-command and
>       ;; last-command equal.
>       (setq this-command last-command)
>       (hippie-expand nil)
>       (add-to-list 'expansions (buffer-string))
>       (buffer-string)
>     ))
>   expansions))

This is almost OK. Completion-UI expects the completion-function to 
return a list of completion strings *without* the prefix. So you need to 
change "expansions" in the last line to:

   (mapcar (lambda (str) (substring str 1)) expansions)


> (defun jason-problem-demo ()
> (interactive)
> (setq-default completion-function
> 'vimpulse-try-hippie-expand-listed-functions)
> (setq completion-function 'vimpulse-try-hippie-expand-listed-functions)
> ;; is this always necessary?  Am I even ever supposed to call it?
> (completion-setup-overlay 'prefix)
> (completion-show-menu))
 > ;; }}} End code
 >
 > Whenever I start typing a word then run
 > M-x jason-problem-demo I get an empty menu.  Why?
 >
 > Am I using
 > completion-show-menu wrong?  It errors on me if I don't call
 > completion-setup-overlay first, so I call it first.  Should I?

This won't work, because you're *still* fighting completion-UI rather 
than working harmoniously with it :) What you should be doing is setting 
'completion-function' to 'vimpulse-try-hippie-expand-listed-functions, 
and then going off to make a cup of tea, have a bite to eat, watch a 
movie, and then spend the weekend fishing and contemplating whether you 
really want to spend so much of your life at a desk hacking Emacs :) 
Because setting 'completion-function' is *all* you have to do!

Once 'completion-function' is set, when you type some characters and 
then call 'complete-word-at-point' (bound to M-TAB by default), 
everything should work. (At least, it did when I just tested it!) By 
default, you can bring up the menu using 'completion-show-menu' (bound 
to M-down by default). Given that you seem to want to show the menu 
immediately, in your case you might want to set 
'completion-auto-show-menu' to non-nil, so that the menu is displayed 
immediately after calling 'complete-word-at-point'. (Again, setting the 
'completion-auto-show-menu' customization option should normally be left 
to the user to customize, but in your case I can see why you might want 
vimpulse-mode to do the customization itself.)


> Cheers,
> Jason[5]
> 
> [1] http://www.emacswiki.org/cgi-bin/wiki/vimpulse.el
> 
> [2] Unfortunately hippie-expand can't complete multiple-word sequences
> like dabbrev can when you press M-/ SPC M-/ SPC M-/.  Vim can do it:
> just press CTRL-X CTRL-P repeatedly.  But I hope I'll eventually fix
> that.
> 
> Then again, maybe I'll never have time to make that change to
> hippie-expand.  So maybe I should have Completion-UI call
> dabbrev-expand instead.

How exactly does this multiple-word completion work? I don't follow.


> [3] e.g. CTRL-X CTRL-T for thesaurus completion, or many other[4] things.
> 
> [4] http://ianua.initd.org/vimit/vim63/html/insert.html#ins-completion
> 
> [5] P.S. You may want to mention in the completion-ui documentation at
> the top of the file that
> http://www.emacswiki.org/cgi-bin/wiki/CompletionUI#toc2 has examples
> of how to use completion-ui with dabbrev and etags.  If I knew that
> info, it would have saved me time. :-)

Ah, I kind of assumed you'd already seen them. I should probably include 
the examples in the documentation at the top of the file. Or better 
still, get round to writing some texinfo documentation for 
completion-UI. There are a lot of features I suspect only I know about 
at the moment :)


Toby

Re: Fwd: completion-ui.el question: my vimpulse-show-completion-menu function always gives me an empty menu

[Jason Spiro]

2007/4/13, Toby Cubitt <tsc25@cantab.net> wrote:
[snip]
Thank you kindly for your detailed reply.  I will print it out and
read through it carefully.

> How exactly does this multiple-word completion work? I don't follow.

For example, type:  The quick brown fox jumped over the lazy dog. My
favorite foM-/ SPC M-/ SPC M-/ SPC M-/ SPC M-/ SPC M-/

It should write: The quick brown fox jumped over the lazy dog. My
favorite fox jumped over the lazy dog"

-- 
Jason Spiro: computer consulting with a smile.
I provide software development and training services to clients worldwide.
Contact me for a FREE consultation. Satisfaction guaranteed.
+1 (416) 781-5938 / Email: info@jspiro.com / MSN: jasonspiro@hotmail.com

Re: Fwd: completion-ui.el question: my vimpulse-show-completion-menu function always gives me an empty menu

[Toby Cubitt]

Jason Spiro wrote:
> 2007/4/13, Toby Cubitt <tsc25@cantab.net> wrote:
 >> (defun vimpulse-try-hippie-expand-listed-functions
 >>        (prefix &optional maxnum)
 >> ;  (interactive "*MString to expand:
 >> ;nMaximum number of expansions, or nil for unlimited: ")
 >> (setq expansions nil)
 >> (with-temp-buffer
 >>   (insert-string prefix)
 >>   (hippie-expand nil)
 >>   (unless (string-equal (current-message) "No expansion found")
 >>     (while (and
 >>             (not (string-equal
 >>                   (current-message)
 >>                   "No further expansions found"))
 >>             (if maxnum (not (= (length expansions) maxnum))))
 >>       ;; Hippie-expand was designed to be run interactively.  If
 >>       ;; this-command and last-command are equal, it assumes it's
 >>       ;; being called as a "repeated use" (additional call without
 >>       ;; moving the point) and searches for additional expansions
 >>       ;; with the same prefix.  So, make this-command and
 >>       ;; last-command equal.
 >>       (setq this-command last-command)
 >>       (hippie-expand nil)
 >>       (add-to-list 'expansions (buffer-string))
 >>       (buffer-string)
 >>     ))
 >>   expansions))

 > This is almost OK. Completion-UI expects the completion-function to
 > return a list of completion strings *without* the prefix. So you need
 > to change "expansions" in the last line to:
 >   (mapcar (lambda (str) (substring str 1)) expansions)

Sorry, this isn't quite correct. It should of course be:

   (mapcar (lambda (str) (substring str (length prefix))) expansions)


>> How exactly does this multiple-word completion work? I don't follow.
> 
> For example, type:  The quick brown fox jumped over the lazy dog. My
> favorite foM-/ SPC M-/ SPC M-/ SPC M-/ SPC M-/ SPC M-/
> 
> It should write: The quick brown fox jumped over the lazy dog. My
> favorite fox jumped over the lazy dog"

I see. This relies on the fact that the first dabbrev expansion is the 
one that is closest in the buffer. If you're completion function (or 
rather, hippie-expand's) returned the completions in this order, you 
could get the same behaviour using completion-UI. My personal favourite 
is to enable 'completion-use-dynamic', so that you don't even need to 
type the M-/ equivalent (M-TAB).

Toby

completion-ui.el question: my vimpulse-show-completion-menu function always gives me an empty menu

[Jason Spiro]

Hi all,

I am trying to get menu completion working for Alessandro Piras'
vimpulse.el, available on EmacsWiki.  (Menu completion is an
ultra-nice feature.  Instead of having to press M-/ over and over
until you get what you want, you get a drop-down menu listing the
completion options.  To see what menu completion looks like in Vim,
see http://en.wikibooks.org/wiki/Learning_the_vi_editor/Vim/Useful_things_for_programmers_to_know)

If you have Toby Cubitt's predictive completion from
http://www.dr-qubit.org/emacs.php installed (incidentally, it's a very
cool package), I would appreciate if you could run this code so you
can answer my question 1 below:

;; Begin code {{{

(require 'completion-ui)

;; Note: This code has an additional bug in addition to the problem I
;; am asking about in this mailing list message:
;; When called with a MAXNUM of nil, this func sometimes fails.  (Seems
;; to work the first time, then fail all times after, in such cases.
;; To fix, call with a normal MAXNUM.)
(defun vimpulse-try-hippie-expand-listed-functions (prefix &optional maxnum)
;  (interactive "*MString to expand:
;nMaximum number of expansions, or nil for unlimited: ")
  (setq expansions nil)
  (with-temp-buffer
    (insert-string prefix)
    (hippie-expand nil)
    (unless (string-equal (current-message) "No expansion found")
      (while (and
              (not (string-equal
                    (current-message)
                    "No further expansions found"))
              (if maxnum (not (= (length expansions) maxnum))))
        ;; Hippie-expand was designed to be run interactively.  If
        ;; this-command and last-command are equal, it assumes it's
        ;; being called as a "repeated use" (additional call without
        ;; moving the point) and searches for additional expansions
        ;; with the same prefix.  So, make this-command and
        ;; last-command equal.
        (setq this-command last-command)
        (hippie-expand nil)
        (add-to-list 'expansions (buffer-string))
        (buffer-string)
      ))
    expansions))

(defun vimpulse-show-completion-menu ()
  (interactive)
  (setq-default completion-function
'vimpulse-try-hippie-expand-listed-functions)
  (setq completion-function 'vimpulse-try-hippie-expand-listed-functions)
  ;; is this always necessary?  Am I even ever supposed to call it?
  (completion-setup-overlay 'prefix)
  (completion-show-menu))

;; }}} End code

1. Whenever I start typing a word then run
vimpulse-show-completion-menu I get an empty menu.  Why?  (Am I using
completion-show-menu wrong?  It errors on me if I don't call
completion-setup-overlay first, so I call it first.  Should I?  In
general, what is the proper way to use completion-show-menu?  It's not
perfectly documented.

2. Should menu completion really be part of vimpulse.el, or should I
try to get it into the hippie-expand source base?  Or, alternatively,
would someone like to take over maintainership of my attempt to get
menu completion working in Emacs?

Thanks in advance,
Jason

P.S. I am using GNU Emacs 22.0.50.1 (i486-pc-linux-gnu, GTK+ Version
2.10.3) of 2006-09-19 on rothera, modified by Debian.  That's 6 months
old.  I am using predictive 0.16.2; I downloaded it today.

-- 
Jason Spiro: computer consulting with a smile.
I also provide training and spyware removal services for homes and businesses.
Call or email for a FREE 5-minute consultation. Satisfaction guaranteed.
+1 (416) 781-5938 / Email: info@jspiro.com / MSN: jasonspiro@hotmail.com

Re: completion-ui.el question: my vimpulse-show-completion-menu function always gives me an empty menu

[Toby Cubitt]

Hi,

I'm not surprised it doesn't work, because you're using completion-UI in 
completely the wrong way. (Excusable, since documentation is currently 
fairly non-existent :-) Instead, set 'completion-function' to a function 
that returns a list of possible completions, and leave completion-UI to 
do its job.

Your comment 2. is along the right lines: menu completion shouldn't be 
implemented in the vimpulse code base, or indeed in the code base of any 
other completion package. It should indeed be in something like the 
hippie-expand package. But that's precisely what completion-UI is! All 
the hippie-expand features, plus tooltips, menu-completion, 
auto-completion, hotkey completion etc. etc. Completion-UI is supposed 
to supersede hippie-expand, at least for in-buffer completion. So using 
completion-UI and hippie-expand at the same time is unlikely to work 
very well.

As an Elisp coder, you're not supposed to invoke *any* completion 
interface explicitly, as you've tried to do. Deciding which combination 
of user-interfaces to use is the user's business, not the package 
writer's. Maybe some users want to use menu completion, but others 
prefer to see a list in the echo area, whilst still others just want a 
tooltip to popup after a delay, etc. etc. Completion-UI offloads those 
choices onto the user, which is where they should be.

I hope that makes things a bit clearer. I fully appreciate that using 
completion-UI will be confusing until it's properly documented, although 
the commentary at the beginning of completion-ui.el does tersely explain 
how it should be used. (Setting 'completion-function' really is all 
there is to it, I promise!)

Toby


Jason Spiro wrote:
> Hi all,
> 
> I am trying to get menu completion working for Alessandro Piras'
> vimpulse.el, available on EmacsWiki.  (Menu completion is an
> ultra-nice feature.  Instead of having to press M-/ over and over
> until you get what you want, you get a drop-down menu listing the
> completion options.  To see what menu completion looks like in Vim,
> see 
> http://en.wikibooks.org/wiki/Learning_the_vi_editor/Vim/Useful_things_for_programmers_to_know) 
> 
> 
> If you have Toby Cubitt's predictive completion from
> http://www.dr-qubit.org/emacs.php installed (incidentally, it's a very
> cool package), I would appreciate if you could run this code so you
> can answer my question 1 below:
> 
> ;; Begin code {{{
> 
> (require 'completion-ui)
> 
> ;; Note: This code has an additional bug in addition to the problem I
> ;; am asking about in this mailing list message:
> ;; When called with a MAXNUM of nil, this func sometimes fails.  (Seems
> ;; to work the first time, then fail all times after, in such cases.
> ;; To fix, call with a normal MAXNUM.)
> (defun vimpulse-try-hippie-expand-listed-functions (prefix &optional 
> maxnum)
> ;  (interactive "*MString to expand:
> ;nMaximum number of expansions, or nil for unlimited: ")
>  (setq expansions nil)
>  (with-temp-buffer
>    (insert-string prefix)
>    (hippie-expand nil)
>    (unless (string-equal (current-message) "No expansion found")
>      (while (and
>              (not (string-equal
>                    (current-message)
>                    "No further expansions found"))
>              (if maxnum (not (= (length expansions) maxnum))))
>        ;; Hippie-expand was designed to be run interactively.  If
>        ;; this-command and last-command are equal, it assumes it's
>        ;; being called as a "repeated use" (additional call without
>        ;; moving the point) and searches for additional expansions
>        ;; with the same prefix.  So, make this-command and
>        ;; last-command equal.
>        (setq this-command last-command)
>        (hippie-expand nil)
>        (add-to-list 'expansions (buffer-string))
>        (buffer-string)
>      ))
>    expansions))
> 
> (defun vimpulse-show-completion-menu ()
>  (interactive)
>  (setq-default completion-function
> 'vimpulse-try-hippie-expand-listed-functions)
>  (setq completion-function 'vimpulse-try-hippie-expand-listed-functions)
>  ;; is this always necessary?  Am I even ever supposed to call it?
>  (completion-setup-overlay 'prefix)
>  (completion-show-menu))
> 
> ;; }}} End code
> 
> 1. Whenever I start typing a word then run
> vimpulse-show-completion-menu I get an empty menu.  Why?  (Am I using
> completion-show-menu wrong?  It errors on me if I don't call
> completion-setup-overlay first, so I call it first.  Should I?  In
> general, what is the proper way to use completion-show-menu?  It's not
> perfectly documented.
> 
> 2. Should menu completion really be part of vimpulse.el, or should I
> try to get it into the hippie-expand source base?  Or, alternatively,
> would someone like to take over maintainership of my attempt to get
> menu completion working in Emacs?
> 
> Thanks in advance,
> Jason
> 
> P.S. I am using GNU Emacs 22.0.50.1 (i486-pc-linux-gnu, GTK+ Version
> 2.10.3) of 2006-09-19 on rothera, modified by Debian.  That's 6 months
> old.  I am using predictive 0.16.2; I downloaded it today.
> 

Re: completion-ui.el question: my vimpulse-show-completion-menu function always gives me an empty menu

[Jason Spiro]

Hi Toby,

2007/3/14, Toby Cubitt <t.s.cubitt.98-dated-1174279006.800fd7@cantab.net> wrote:
> I'm not surprised it doesn't work, because you're using completion-UI in
> completely the wrong way. (Excusable, since documentation is currently
> fairly non-existent :-) Instead, set 'completion-function' to a function
> that returns a list of possible completions, and leave completion-UI to
> do its job.
>
Will try it - thanks for the explanation.

> Your comment 2. is along the right lines: menu completion shouldn't be
> implemented in the vimpulse code base, or indeed in the code base of any
> other completion package. It should indeed be in something like the
> hippie-expand package. But that's precisely what completion-UI is! All
> the hippie-expand features, plus tooltips, menu-completion,
> auto-completion, hotkey completion etc. etc. Completion-UI is supposed
> to supersede hippie-expand, at least for in-buffer completion. So using
> completion-UI and hippie-expand at the same time is unlikely to work
> very well.
>
I decided on hippie-expand because it can complete:

- words (like dabbrev does)
- filenames
- entire buffer lines.

and more.  I am trying to emulate Vim's completion behavior, and Vim
can complete all those things and more.  Unfortunately it can't
complete multiple-word sequences like dabbrev can when you press M-/
SPC M-/ SPC M-/ but I hope someone else or I will add that later.

> As an Elisp coder, you're not supposed to invoke *any* completion
> interface explicitly, as you've tried to do. Deciding which combination
> of user-interfaces to use is the user's business, not the package
> writer's. Maybe some users want to use menu completion, but others
> prefer to see a list in the echo area, whilst still others just want a
> tooltip to popup after a delay, etc. etc. Completion-UI offloads those
> choices onto the user, which is where they should be.
>
I want Vimpulse to emulate Vim's completion behavior: when you press
C-n, C-p, or any of the other completion keys in Insert mode: it shows
a menu.  Is there a way to programmatically change a Customize
variable's default so that my change will take effect if and only if
the user does not customize that variable themselves?

> I hope that makes things a bit clearer. I fully appreciate that using
> completion-UI will be confusing until it's properly documented, although
> the commentary at the beginning of completion-ui.el does tersely explain
> how it should be used. (Setting 'completion-function' really is all
> there is to it, I promise!)
>
I eagerly await that future day when it'll be better documented then :-)

Till then, do you know of any code examples that call completion-ui
that I could look at?

Cheers,
Jason

-- 
Jason Spiro: computer consulting with a smile.
I provide software development and training services to clients worldwide.
Contact me for a FREE consultation. Satisfaction guaranteed.
+1 (416) 781-5938 / Email: info@jspiro.com / MSN: jasonspiro@hotmail.com