unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: help-gnu-emacs@gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: RE: Bookmarks in EWW
Date: Thu, 26 Mar 2020 07:02:05 -0700 (PDT)	[thread overview]
Message-ID: <bfcb7ca2-9c16-43ca-adc6-e4e1201eaa62@default> (raw)
In-Reply-To: <87d08z93fx.fsf@web.de>

> I meant the other locations where a special
> `bookmark-make-record-function' is implemented, e.g. "doc-view".  I
> only had a quick look but most places don't care the features your code
> provides.  I didn't want to say your code would not work, I also didn't
> want to say that those features aren't useful.  But if we add them, we
> should add them in a uniform way for all implementations of
> `bookmark-make-record-function', not only for eww.  This is something I
> don't want to do.

FWIW -

The stuff that's in that make-record function is only for EWW.
In Bookmark+, the make-record functions for other kinds of
bookmarks don't have such things.  They're specifically about
renaming the EWW buffer, etc.

So no, I don't think such things apply "in a uniform way for
all implementations" of a make-record function.  They're only
for EWW.

(BTW, there's nothing about "sessions" in the Bookmark+ code,
AFAIK; I haven't understood that part either, of your and
Marcin's messages.)

There is an Emacs Dev thread about this stuff.  See

https://lists.gnu.org/archive/html/emacs-devel/2018-04/msg00622.html

Note that that thread was started by someone requesting to be
able to do, for EWW, some of the kinds of things that Bookmark+
offers.

And this part of that thread speaks to the use of EWW "bookmarks"
versus regular bookmarks, and to the use of different make-record
functions for different kinds of bookmarks:

https://lists.gnu.org/archive/html/emacs-devel/2018-04/msg00660.html

'Nuff said.  I'm not pushing anyone to use code similar to what
I offered.  My point is that those particular features were
added specifically for use with EWW - they're not Bookmark+
features used for any other kinds of bookmarks.  The latter kind
of feature I didn't provide the code for here, though such things
(e.g. tags) were requested in the original Emacs Dev thread.  I
didn't provide them in the code I offered here because they do
require more of Bookmark+.



  reply	other threads:[~2020-03-26 14:02 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23 11:26 Bookmarks in EWW Marcin Borkowski
2020-03-23 14:56 ` Drew Adams
2020-03-25 11:48   ` Marcin Borkowski
2020-03-23 20:41 ` Michael Heerdegen
2020-03-24 14:46   ` Stefan Monnier
2020-03-25  3:05     ` Michael Heerdegen
2020-03-25  3:45       ` `declare-function' docu (was: Re: Bookmarks in EWW) Emanuel Berg via Users list for the GNU Emacs text editor
2020-03-28 17:59         ` `declare-function' docu Bruno Félix Rezende Ribeiro
2020-03-28 18:38           ` Drew Adams
2020-04-09 12:30             ` Bruno Félix Rezende Ribeiro
2020-04-09 15:47               ` Drew Adams
2020-03-28 21:38           ` Emanuel Berg via Users list for the GNU Emacs text editor
2020-03-25 14:06       ` Bookmarks in EWW Stefan Monnier
2020-03-26  1:09         ` Michael Heerdegen
2020-03-26  4:07           ` Stefan Monnier
2020-03-27  2:07             ` Michael Heerdegen
2020-03-27  3:44               ` Stefan Monnier
2020-03-28  2:31                 ` Michael Heerdegen
2020-03-28  2:55                   ` Stefan Monnier
2020-04-19  3:42                     ` Michael Heerdegen
2020-04-19 13:18                       ` Stefan Monnier
2020-04-20  3:17                         ` Michael Heerdegen
2020-04-20 13:24                           ` Stefan Monnier
2020-04-21  0:59                             ` Michael Heerdegen
2020-04-29 22:53                             ` Michael Heerdegen
2020-04-30  1:25                               ` Stefan Monnier
2020-04-30  2:08                                 ` Michael Heerdegen
2020-04-30  3:08                                   ` Stefan Monnier
2020-04-30 20:09                                     ` Michael Heerdegen
2020-04-27  2:43                         ` Michael Heerdegen
2020-03-27  4:32         ` buffer-localness (was: Re: Bookmarks in EWW) Emanuel Berg via Users list for the GNU Emacs text editor
2020-03-25 21:48       ` Bookmarks in EWW Drew Adams
2020-03-26  2:29         ` Michael Heerdegen
2020-03-26  3:21           ` Drew Adams
2020-03-26  3:53             ` Michael Heerdegen
2020-03-26 14:02               ` Drew Adams [this message]
2020-03-26 22:33                 ` Michael Heerdegen
2020-03-26  8:41           ` Marcin Borkowski
2020-03-25 11:49   ` Marcin Borkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfcb7ca2-9c16-43ca-adc6-e4e1201eaa62@default \
    --to=drew.adams@oracle.com \
    --cc=help-gnu-emacs@gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).