unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Barry Margolin <barmar@alum.mit.edu>
To: help-gnu-emacs@gnu.org
Subject: Re: Problem advising nreverse.
Date: Tue, 15 Dec 2009 16:12:08 -0500	[thread overview]
Message-ID: <barmar-641196.16120815122009@nothing.attdns.com> (raw)
In-Reply-To: mailman.13027.1260909564.2239.help-gnu-emacs@gnu.org

In article <mailman.13027.1260909564.2239.help-gnu-emacs@gnu.org>,
 Sergei Organov <osv@javad.com> wrote:

> > pjb@informatimago.com (Pascal J. Bourguignon) writes:
> >
> >> Sergei Organov <osv@javad.com> writes:
> >>> I still wonder if it's documented somewhere in some manual when
> >>> defadvice doesn't actually work. It seems it is not there in the Elisp
> >>> manual, or did I miss it?
> >>
> >> See: (info "(elisp)Advising Primitives")
> >
> > Well, but I didn't find even single word there describing cases when
> > it does not work to advise a funciton.
> 
> Sorry, my mistake. In fact, this topic does tell about when advice won't
> work, but it tells exactly opposite to what actually happens:
> 
> "Calls to the primitive from Lisp code will take note of the advice, but
> calls from C code will ignore the advice."
> 
> Now, in my case `nreverse' is called from Lisp code, not from C code, so
> according to the manual advice must work, right? And there is no single
> word about differences in behavior due to byte-compiling.

Byte compiling effectively changes it to a call from C code, because the 
byte code is a direct reference to the primitive.  "Called from Lisp 
code" means interpreting Lisp source code, since that indirects through 
the function name, which is where advice is stored.

-- 
Barry Margolin, barmar@alum.mit.edu
Arlington, MA
*** PLEASE post questions in newsgroups, not directly to me ***
*** PLEASE don't copy me on replies, I'll read them in the group ***


  parent reply	other threads:[~2009-12-15 21:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.12764.1260538816.2239.help-gnu-emacs@gnu.org>
2009-12-12 12:18 ` Problem advising nreverse Pascal J. Bourguignon
2009-12-14 11:07   ` Sergei Organov
     [not found]   ` <mailman.12932.1260788943.2239.help-gnu-emacs@gnu.org>
2009-12-14 13:01     ` Pascal J. Bourguignon
2009-12-14 15:05       ` Sergei Organov
2009-12-15  8:19         ` Kevin Rodgers
2009-12-15 12:02           ` Sergei Organov
     [not found]       ` <mailman.12940.1260803316.2239.help-gnu-emacs@gnu.org>
2009-12-14 15:23         ` Pascal J. Bourguignon
2009-12-14 16:01           ` Sergei Organov
     [not found]           ` <mailman.12941.1260806509.2239.help-gnu-emacs@gnu.org>
2009-12-14 17:56             ` Pascal J. Bourguignon
2009-12-14 19:59               ` Sergei Organov
     [not found]               ` <mailman.12952.1260820780.2239.help-gnu-emacs@gnu.org>
2009-12-15  1:47                 ` Pascal J. Bourguignon
2009-12-15 12:06                   ` Sergei Organov
     [not found]                   ` <mailman.13009.1260879016.2239.help-gnu-emacs@gnu.org>
2009-12-15 19:54                     ` Pascal J. Bourguignon
2009-12-15 20:38                   ` Sergei Organov
     [not found]                   ` <mailman.13027.1260909564.2239.help-gnu-emacs@gnu.org>
2009-12-15 21:12                     ` Barry Margolin [this message]
2009-12-16 11:27                       ` Sergei Organov
     [not found]                       ` <mailman.13051.1260962896.2239.help-gnu-emacs@gnu.org>
2009-12-17 16:52                         ` Barry Margolin
2009-12-11 13:22 Sergei Organov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=barmar-641196.16120815122009@nothing.attdns.com \
    --to=barmar@alum.mit.edu \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).