unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Barry Margolin <barmar@alum.mit.edu>
To: help-gnu-emacs@gnu.org
Subject: Re: defmacro and defface problems
Date: Fri, 21 Mar 2008 16:19:26 -0400	[thread overview]
Message-ID: <barmar-32F1B9.16192521032008@newsgroups.comcast.net> (raw)
In-Reply-To: mailman.9284.1206066601.18990.help-gnu-emacs@gnu.org

In article <mailman.9284.1206066601.18990.help-gnu-emacs@gnu.org>,
 tsgatesv <tsgatesv@gmail.com> wrote:

> hi, all!
> 
> I met a problem about defining macro with defface!
> 
> It looks extremely strange to me, help! 
> 
> 1. define macro "git--face" in order to short my codes
> --------------------------------------------------------------------------
> (defmacro git--face (name fore1 prop1 fore2 prop2)
>   `(defface ,(make-symbol (concat "git--" (symbol-name name) "-face"))

Use intern, not make-symbol.  Make-symbol creates uninterned symbols, so 
when you later type (facep 'git--wow-face), you're not using the same 
symbol that you defined.

>      '((((class color) (background light)) (:foreground ,fore1 ,@prop1))
>        (((class color) (background dark)) (:foreground ,fore2 ,@prop2)))
>     ,(concat "git " (symbol-name name) " face in status buffer mode")
>     :group 'git))
> --------------------------------------------------------------------------
> 
> 2. seems like work,
> --------------------------------------------------------------------------
> (git--face wow       "red"    (:bold t) "tomato" (:bold t))
> git--wow-face
> --------------------------------------------------------------------------
> 
> 3. but not defined (but, there is 'git--wow-face in "list-faces-display)
> --------------------------------------------------------------------------
> (facep 'git--wow-face)
> nil
> --------------------------------------------------------------------------
> 
> 4. this is what I want to eval
> --------------------------------------------------------------------------
> (defface git--wow-face
>   '((((class color) (background light)) (:foreground "gray" :bold
> t :italic t))
>     (((class color) (background dark)) (:foreground "gray" :bold
> t :italic t)))
>   "git wow face in status buffer mode"
>   :group 'git)
> git--wow-face
> 
> 
> (facep 'git--wow-face)
> [face unspecified unspecified unspecified unspecified unspecified
> unspecified unspecified unspecified unspecified unspecified
> unspecified ...]
> --------------------------------------------------------------------------
> 
> 5. Actually, the expanded macro of 1 and 4 is exactly same like under
> --------------------------------------------------------------------------
> 
> (macroexpand '(git--face wow       "red"    (:bold t) "tomato" (:bold
> t)))
> (custom-declare-face (quote git--wow-face) (quote ((... ...) (... ...)))
> "git wow face in status buffer mode" :group (quote git))
> 
> (macroexpand
> '(defface git--wow-face
>   '((((class color) (background light)) (:foreground "gray" :bold
> t :italic t))
>     (((class color) (background dark)) (:foreground "gray" :bold
> t :italic t)))
>   "git wow face in status buffer mode"
>   :group 'git))
> (custom-declare-face (quote git--wow-face) (quote ((... ...) (... ...)))
> "git wow face in status buffer mode" :group (quote git))
> --------------------------------------------------------------------------
> 
> Thank you for reading and please help me!

-- 
Barry Margolin, barmar@alum.mit.edu
Arlington, MA
*** PLEASE don't copy me on replies, I'll read them in the group ***


       reply	other threads:[~2008-03-21 20:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.9284.1206066601.18990.help-gnu-emacs@gnu.org>
2008-03-21 20:19 ` Barry Margolin [this message]
2008-03-21  0:26 defmacro and defface problems tsgatesv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=barmar-32F1B9.16192521032008@newsgroups.comcast.net \
    --to=barmar@alum.mit.edu \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).