From: Drew Adams <drew.adams@oracle.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>, help-gnu-emacs@gnu.org
Subject: RE: Reverting but keeping undo
Date: Tue, 28 May 2013 20:09:24 -0700 (PDT) [thread overview]
Message-ID: <ba0ae878-2f1f-4ab5-b5e6-512f794ceceb@default> (raw)
In-Reply-To: <jwvk3mibliz.fsf-monnier+gmane.emacs.help@gnu.org>
> > `revert-buffer' discards undo history.
>
> FWIW, I just installed a patch in Emacs's trunk which makes that
> revert-buffer doesn't discard undo history any more.
Hm. So `revert-buffer' no longer removes undo? That has always been a part of what reverting means. And it is clearly intended in the code, not just an unfortunate accident or oversight.
If some code or user has a use for not removing undo, fine. But why not make this removal optional, controlled, e.g., by a variable or a parameter? Why willy nilly remove something clearly intended from the beginning to be an integral part of reverting (at least by default)?
And why no discussion beforehand? I can't think of a great reason why undo should *always* be removed as part of reverting (as it always has been). But just maybe there is a good reason for doing that, at least some or even most of the time. Why not give Richard et al the benefit of the doubt (30 years of "classic" reverting) and make undo removal optional, at least for a while? (Or is doubt a no-no?)
Let's not forget either that `revert-buffer' is used both in code and interactively. Those two uses are sometimes quite different.
next prev parent reply other threads:[~2013-05-29 3:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 10:38 Reverting but keeping undo Óscar Fuentes
2013-05-16 5:29 ` W. Greenhouse
2013-05-16 15:10 ` Óscar Fuentes
2013-05-29 1:52 ` Stefan Monnier
2013-05-29 3:09 ` Drew Adams [this message]
2013-05-29 3:27 ` Dmitry Gutov
2013-05-29 5:13 ` Drew Adams
2013-05-29 12:26 ` Dmitry Gutov
2013-05-29 13:55 ` Drew Adams
2013-05-29 15:21 ` Dmitry Gutov
2013-05-29 16:33 ` Drew Adams
2013-05-29 17:51 ` Dmitry Gutov
[not found] ` <mailman.605.1369845207.22516.help-gnu-emacs@gnu.org>
2013-05-29 18:42 ` Dan Espen
2013-05-29 13:48 ` Stefan Monnier
[not found] ` <mailman.562.1369804408.22516.help-gnu-emacs@gnu.org>
2013-05-29 13:25 ` Dan Espen
2013-05-29 16:26 ` Drew Adams
2013-05-30 18:48 ` Michael Heerdegen
2013-05-30 18:41 ` Michael Heerdegen
2013-05-30 19:19 ` Óscar Fuentes
2013-05-30 21:26 ` Stefan Monnier
2013-05-30 22:05 ` Michael Heerdegen
[not found] ` <mailman.728.1369951538.22516.help-gnu-emacs@gnu.org>
2013-05-30 23:59 ` Dan Espen
2013-05-31 0:58 ` Stefan Monnier
[not found] ` <mailman.738.1369961954.22516.help-gnu-emacs@gnu.org>
2013-05-31 1:21 ` Dan Espen
2013-05-31 2:28 ` Drew Adams
2013-05-31 16:05 ` Michael Heerdegen
2013-05-31 18:29 ` Óscar Fuentes
[not found] ` <mailman.767.1370016367.22516.help-gnu-emacs@gnu.org>
2013-05-31 17:22 ` Dan Espen
2013-05-31 18:08 ` Barry Margolin
[not found] ` <mailman.699.1369939338.22516.help-gnu-emacs@gnu.org>
2013-05-30 18:45 ` Barry Margolin
-- strict thread matches above, loose matches on Subject: below --
2013-05-31 16:49 Barry OReilly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba0ae878-2f1f-4ab5-b5e6-512f794ceceb@default \
--to=drew.adams@oracle.com \
--cc=help-gnu-emacs@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).