From: Drew Adams <drew.adams@oracle.com>
To: Emanuel Berg <embe8573@student.uu.se>, help-gnu-emacs@gnu.org
Subject: RE: systemd @ in filenames not supported by thing-at-point
Date: Fri, 29 Jul 2016 22:41:14 -0700 (PDT) [thread overview]
Message-ID: <b2028b14-a4ce-4962-8a38-abcad5579967@default> (raw)
In-Reply-To: <86bn1fzzau.fsf@student.uu.se>
> However, with the lambasted systemd, files are
> sometimes include an "@", as in
> /lib/systemd/system/getty@.service
>
> I just now noticed that my function, or rather
> `thing-at-point', breaks on such paths because
> of this setting:
> (defvar thing-at-point-file-name-chars "-~/[:alnum:]_.${}#%,:"
> "Characters allowable in filenames.")
>
> Because "@" isn't included, it is considered
> a file name delimiter and the path returned is
> incorrectly /lib/systemd/system/getty - with this:
>
> (setq thing-at-point-file-name-chars "@-~/[:alnum:]_.${}#%,:")
> it works as expected.
> But I don't know if that will break something else?
Looking at the code, it shouldn't break anything. What's more,
I'd say that this variable should be a user option. For one
thing, that would make clear to users that it won't break
anything to change the value. ;-)
next prev parent reply other threads:[~2016-07-30 5:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-30 1:31 systemd @ in filenames not supported by thing-at-point Emanuel Berg
2016-07-30 5:41 ` Drew Adams [this message]
2016-07-30 6:07 ` Emanuel Berg
2016-07-30 6:43 ` Drew Adams
2016-07-30 17:29 ` Stefan Monnier
2016-07-30 18:01 ` Emanuel Berg
2016-07-30 6:48 ` Yuri Khan
2016-07-30 7:58 ` Emanuel Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2028b14-a4ce-4962-8a38-abcad5579967@default \
--to=drew.adams@oracle.com \
--cc=embe8573@student.uu.se \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).