From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Tim Johnson Newsgroups: gmane.emacs.help Subject: Adding an `or condition without changing code Date: Sun, 12 Jan 2020 14:29:34 -0900 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="29707"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 To: MLEmacs Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 13 00:33:07 2020 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iqmiU-00134z-Qa for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 13 Jan 2020 00:32:23 +0100 Original-Received: from localhost ([::1]:42912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqmiT-0005fv-6A for geh-help-gnu-emacs@m.gmane-mx.org; Sun, 12 Jan 2020 18:32:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60706) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqmhw-0005eK-Uk for help-gnu-emacs@gnu.org; Sun, 12 Jan 2020 18:31:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iqmhv-00064f-Op for help-gnu-emacs@gnu.org; Sun, 12 Jan 2020 18:31:48 -0500 Original-Received: from gateway20.websitewelcome.com ([192.185.44.20]:45204) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iqmhv-0005NC-Ct for help-gnu-emacs@gnu.org; Sun, 12 Jan 2020 18:31:47 -0500 Original-Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 33ED2400C4A45 for ; Sun, 12 Jan 2020 16:17:34 -0600 (CST) Original-Received: from host2075.hostmonster.com ([67.20.113.97]) by cmsmtp with SMTP id qmfoiTBVzW4frqmfoiiGFQ; Sun, 12 Jan 2020 17:29:36 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tj49.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Date: Message-ID:Subject:From:To:Sender:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=efLNdzB9zTJP/XNRvXas/XUW5tTOBp45cYJYAZjMCmQ=; b=MU9Iht7o+Pvu2XLO/Cj47ZAqYg P4VHrwT9FPEe3sHMVU9E4UDGFju3Y0zWFn8mENHEzI4VrmLnHrxSZFWFsss6ecJ2DRG7PmUU7ciwm SJdlmcvxloWgzRF3HsfBl49P0; Original-Received: from tjohnson.mtaonline.net ([64.4.232.191]:56226 helo=[192.168.1.6]) by host2075.hostmonster.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1iqmfn-0035B7-Pg for Help-gnu-emacs@gnu.org; Sun, 12 Jan 2020 16:29:35 -0700 Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2075.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - akwebsoft.com X-BWhitelist: no X-Source-IP: 64.4.232.191 X-Source-L: No X-Exim-ID: 1iqmfn-0035B7-Pg X-Source-Sender: tjohnson.mtaonline.net ([192.168.1.6]) [64.4.232.191]:56226 X-Source-Auth: tim@tj49.com X-Email-Count: 1 X-Source-Cap: bW9sZG92YXM7bW9sZG92YXM7aG9zdDIwNzUuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 192.185.44.20 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.org gmane.emacs.help:122213 Archived-At: Using emacs 26.1 on ubuntu I'm implementing dired-single-buffer The function of the same name has the following `let initialization (let ((name (or default-dirname (dired-get-filename nil t)))) ;;=20 default-dirname is an optional argument to dired-single-buffer The two conditions to `or are not sufficient if I call=20 dired-single-buffer from an unvisited buffer. The result is that `name=20 is nil and a string-p, nil error is thrown. A simple hack is to add a third condition to `or (let ((name (or default-dirname (dired-get-filename nil t) "~/")))=C2=A0 = ;;=20 fall-back to /home/user But, it IS a hack and means I have altered some good citizen's code. How can that be resolved? Might the solution be a customization of dired? From the documentation of dired-get-filename I don't grok a solution.... thanks --=20 Tim tj49.com