~/.../emacs/lib-src/blessmail owned by root?

~/.../emacs/lib-src/blessmail owned by root?

[Michael Heerdegen]

Hello,

I'm using a standard build of master: I do autogen,
configure --with-x-toolkit=no --with-native-compilation=no
and then make and sudo make install.

After that, emacs/lib-src/blessmail (in my home dir!) is owned by root.
Note: not something installed, the file in the repository. Is this
expected?

I always see a warning popping up when rsyncing my home dir to my backup
drive...  On Debian Gnu/Linux should it matter.


TIA,

Michael.

Re: ~/.../emacs/lib-src/blessmail owned by root?

[tomas]

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

On Thu, Aug 22, 2024 at 03:49:18AM +0200, Michael Heerdegen wrote:
> Hello,
> 
> I'm using a standard build of master: I do autogen,
> configure --with-x-toolkit=no --with-native-compilation=no
> and then make and sudo make install.
> 
> After that, emacs/lib-src/blessmail (in my home dir!) is owned by root.
> Note: not something installed, the file in the repository. Is this
> expected?

Hm. Git doesn't know about file ownerships (permissions, yes). All the
files are owned by the user invoking the git commands (clone, fetch,
you name it).

Are you sure the file is coming from the repo? Perhaps, then, you
invoked some git command as root?

Cheers
-- 
t

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: ~/.../emacs/lib-src/blessmail owned by root?

[Eli Zaretskii]

> Date: Thu, 22 Aug 2024 06:46:10 +0200
> From: <tomas@tuxteam.de>
> 
> On Thu, Aug 22, 2024 at 03:49:18AM +0200, Michael Heerdegen wrote:
> > 
> > I'm using a standard build of master: I do autogen,
> > configure --with-x-toolkit=no --with-native-compilation=no
> > and then make and sudo make install.
> > 
> > After that, emacs/lib-src/blessmail (in my home dir!) is owned by root.
> > Note: not something installed, the file in the repository. Is this
> > expected?
> 
> Hm. Git doesn't know about file ownerships (permissions, yes). All the
> files are owned by the user invoking the git commands (clone, fetch,
> you name it).
> 
> Are you sure the file is coming from the repo? Perhaps, then, you
> invoked some git command as root?

The file is not in the repository, it is built as part of the Emacs
build procedure (see lib-src/Makefile.in) and only if needed, as
decided from the system configuration details (see configure.ac).

Thus, Git has nothing to do with this.

Re: ~/.../emacs/lib-src/blessmail owned by root?

[Michael Heerdegen via Users list for the GNU Emacs text editor]

Eli Zaretskii <eliz@gnu.org> writes:

> The file is not in the repository, it is built as part of the Emacs
> build procedure (see lib-src/Makefile.in) and only if needed, as
> decided from the system configuration details (see configure.ac).

Sorry, I didn't want to imply that there is a problem with the
repository.

But why is this file put in my build directory but owned by root?  It is
the only one I ever saw.  It must be related to sudo make install, the
only sudo'ed command involved.  But it doesn't make sense to install
files to my home dir where other users don't have access.

And I as user can't delete the file unless I use administrator
privileges.

Don't you find this odd?


Michael.

Re: ~/.../emacs/lib-src/blessmail owned by root?

[Eli Zaretskii]

> Date: Thu, 22 Aug 2024 07:36:57 +0200
> From:  Michael Heerdegen via Users list for the GNU Emacs text editor <help-gnu-emacs@gnu.org>
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > The file is not in the repository, it is built as part of the Emacs
> > build procedure (see lib-src/Makefile.in) and only if needed, as
> > decided from the system configuration details (see configure.ac).
> 
> Sorry, I didn't want to imply that there is a problem with the
> repository.

I didn't say you did.  I was replying to tomas's message.

> But why is this file put in my build directory but owned by root?

I don't know.  This file is not installed on my system, so I couldn't
compare.  Does lib/src/blessmail in the build tree have the right
ownership and attributes?  If so, you need to look into the
installation procedure and see which command there changes the owner.

> It is
> the only one I ever saw.  It must be related to sudo make install, the
> only sudo'ed command involved.  But it doesn't make sense to install
> files to my home dir where other users don't have access.
> 
> And I as user can't delete the file unless I use administrator
> privileges.
> 
> Don't you find this odd?

It might be a bug of some sort, but then why only this file is owned
by root?  AFAICT, "make install" installs it together with other
files, so I don't understand ATM why only this file got its owner
changed by sudo.

Re: ~/.../emacs/lib-src/blessmail owned by root?

[Robert Pluim]

>>>>> On Thu, 22 Aug 2024 13:10:03 +0300, Eli Zaretskii <eliz@gnu.org> said:
    >> It is
    >> the only one I ever saw.  It must be related to sudo make install, the
    >> only sudo'ed command involved.  But it doesn't make sense to install
    >> files to my home dir where other users don't have access.
    >> 
    >> And I as user can't delete the file unless I use administrator
    >> privileges.
    >> 
    >> Don't you find this odd?

    Eli> It might be a bug of some sort, but then why only this file is owned
    Eli> by root?  AFAICT, "make install" installs it together with other
    Eli> files, so I don't understand ATM why only this file got its owner
    Eli> changed by sudo.

The top-level Makefile has:

install: actual-all install-arch-indep install-etcdoc install-arch-dep install-$(NTDIR) blessmail install-eln install-gsettings-schemas

and

blessmail: Makefile src
	$(MAKE) -C lib-src maybe-blessmail

so blessmail is built as part of running the 'install' target, but the
lib-src Makefile only does that when itʼs needed, which is why it ends
up as owned by root.

Itʼs not installed, but the lib-src Makefile will tell you if it needs
to be run via the maybe-blessmail and need-blessmail targets.

Robert
-- 

Re: ~/.../emacs/lib-src/blessmail owned by root?

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: help-gnu-emacs@gnu.org
> Date: Thu, 22 Aug 2024 13:49:50 +0200
> 
> >>>>> On Thu, 22 Aug 2024 13:10:03 +0300, Eli Zaretskii <eliz@gnu.org> said:
>     >> It is
>     >> the only one I ever saw.  It must be related to sudo make install, the
>     >> only sudo'ed command involved.  But it doesn't make sense to install
>     >> files to my home dir where other users don't have access.
>     >> 
>     >> And I as user can't delete the file unless I use administrator
>     >> privileges.
>     >> 
>     >> Don't you find this odd?
> 
>     Eli> It might be a bug of some sort, but then why only this file is owned
>     Eli> by root?  AFAICT, "make install" installs it together with other
>     Eli> files, so I don't understand ATM why only this file got its owner
>     Eli> changed by sudo.
> 
> The top-level Makefile has:
> 
> install: actual-all install-arch-indep install-etcdoc install-arch-dep install-$(NTDIR) blessmail install-eln install-gsettings-schemas
> 
> and
> 
> blessmail: Makefile src
> 	$(MAKE) -C lib-src maybe-blessmail
> 
> so blessmail is built as part of running the 'install' target, but the
> lib-src Makefile only does that when itʼs needed, which is why it ends
> up as owned by root.
> 
> Itʼs not installed, but the lib-src Makefile will tell you if it needs
> to be run via the maybe-blessmail and need-blessmail targets.

Thanks, so the solution seems to be to change the Makefile's so that
blessmail is produce at build time, not "make install" time.

Re: ~/.../emacs/lib-src/blessmail owned by root?

[Robert Pluim]

>>>>> On Thu, 22 Aug 2024 15:16:37 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> so blessmail is built as part of running the 'install' target, but the
    >> lib-src Makefile only does that when itʼs needed, which is why it ends
    >> up as owned by root.
    >> 
    >> Itʼs not installed, but the lib-src Makefile will tell you if it needs
    >> to be run via the maybe-blessmail and need-blessmail targets.

    Eli> Thanks, so the solution seems to be to change the Makefile's so that
    Eli> blessmail is produce at build time, not "make install" time.

This seems to DTRT, although I donʼt have any systems that require
blessmail. I think this results in the 'need-blessmail' message being
output at build time rather than install time, which could be seen as
a problem.

diff --git a/Makefile.in b/Makefile.in
index 1b6c7eb05dc..30a762ed03b 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -381,7 +381,7 @@ bootstrap-all:
 
 .PHONY: bootstrap-all actual-all advice-on-failure sanity-check
 
-actual-all: ${SUBDIR} info $(gsettings_SCHEMAS:.xml=.valid) src-depending-on-lisp
+actual-all: ${SUBDIR} info $(gsettings_SCHEMAS:.xml=.valid) src-depending-on-lisp blessmail
 
 # ADVICE-ON-FAILURE-BEGIN:all
 # You could try to:
@@ -602,7 +602,7 @@ .PHONY:
 ## don't have to duplicate the list of utilities to install in
 ## this Makefile as well.
 
-install: actual-all install-arch-indep install-etcdoc install-arch-dep install-$(NTDIR) blessmail install-eln install-gsettings-schemas
+install: actual-all install-arch-indep install-etcdoc install-arch-dep install-$(NTDIR) install-eln install-gsettings-schemas
 	@true
 
 ## Ensure that $subdir contains a subdirs.el file.



Robert
-- 

Re: ~/.../emacs/lib-src/blessmail owned by root?

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: help-gnu-emacs@gnu.org
> Date: Thu, 22 Aug 2024 15:47:17 +0200
> 
> >>>>> On Thu, 22 Aug 2024 15:16:37 +0300, Eli Zaretskii <eliz@gnu.org> said:
> 
>     >> so blessmail is built as part of running the 'install' target, but the
>     >> lib-src Makefile only does that when itʼs needed, which is why it ends
>     >> up as owned by root.
>     >> 
>     >> Itʼs not installed, but the lib-src Makefile will tell you if it needs
>     >> to be run via the maybe-blessmail and need-blessmail targets.
> 
>     Eli> Thanks, so the solution seems to be to change the Makefile's so that
>     Eli> blessmail is produce at build time, not "make install" time.
> 
> This seems to DTRT, although I donʼt have any systems that require
> blessmail. I think this results in the 'need-blessmail' message being
> output at build time rather than install time, which could be seen as
> a problem.

Maybe we can move the messages as well.

Michael, does this change solve the problem with ownership?

Re: ~/.../emacs/lib-src/blessmail owned by root?

[Michael Heerdegen via Users list for the GNU Emacs text editor]

Eli Zaretskii <eliz@gnu.org> writes:

> Michael, does this change solve the problem with ownership?

Yes, it does solve it.

Thanks to Robert for the suggestion.


Michael.

Re: ~/.../emacs/lib-src/blessmail owned by root?

[Eli Zaretskii]

> Date: Fri, 23 Aug 2024 03:00:16 +0200
> From:  Michael Heerdegen via Users list for the GNU Emacs text editor <help-gnu-emacs@gnu.org>
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Michael, does this change solve the problem with ownership?
> 
> Yes, it does solve it.
> 
> Thanks to Robert for the suggestion.

Robert, feel free to install such a change on the master branch, and
thanks.

Re: : ~/.../emacs/lib-src/blessmail owned by root?

[Robert Pluim]

>>>>> On Fri, 23 Aug 2024 10:03:06 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> Date: Fri, 23 Aug 2024 03:00:16 +0200
    >> From:  Michael Heerdegen via Users list for the GNU Emacs text editor <help-gnu-emacs@gnu.org>
    >> 
    >> Eli Zaretskii <eliz@gnu.org> writes:
    >> 
    >> > Michael, does this change solve the problem with ownership?
    >> 
    >> Yes, it does solve it.
    >> 
    >> Thanks to Robert for the suggestion.

    Eli> Robert, feel free to install such a change on the master branch, and
    Eli> thanks.

Done as 7f97cf31dc3.

Robert
--