From: <tomas@tuxteam.de>
To: Joshua Lambert <jlambert.lis.tech@gmail.com>
Cc: Platon Pronko <platon7pronko@gmail.com>, help-gnu-emacs@gnu.org
Subject: Re: Iterating over buffer lines
Date: Sat, 17 Jun 2023 06:48:24 +0200 [thread overview]
Message-ID: <ZI07GELOjRlAYgHb@tuxteam.de> (raw)
In-Reply-To: <CAGGu9j1F1iDCWsF6q+-HwV2=g4SwU=myWT=m4YCC8=bpRZoBYA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2422 bytes --]
On Fri, Jun 16, 2023 at 10:28:45PM -0500, Joshua Lambert wrote:
> OK. See below. I'm trying to avoid reusing most of the code in
> function my-act-on-region-by-line. There are multiple functions that
> correct data errors in a csv file and I want to be able to
> interactively run one of those corrections at a time. The resulting
> string will be inserted at the beginning of each line. That all works,
> I'm just trying not to have so much code repetition.
>
> (defun my-act-on-region-by-line (some-function &optional beg end)
> "Perform a function on the current line or each line of the region.
> Each SOME-FUNCTION must return a string."
> (let ((beg2 (if (region-active-p)
> beg
> (line-beginning-position)))
> (end2 (if (region-active-p)
> end
> (line-end-position))))
> (save-excursion
> (save-restriction
> (narrow-to-region beg2 end2)
> (goto-char (point-min))
> (while (not (eobp))
> (goto-char (line-beginning-position))
> (insert some-chosen-function) ;; Inserts text after a
> function transforms it.
> (insert my-separator)
The above means that you are inserting stuff at the beginning of the
current line, right?
> (forward-line)))))
... and this assumes that your `some-chosen-function' doesn't mess
"too much" with point.
>
> (defun my-paste-corrected-spacing (&optional field-num beg end)
> "Correct spacing in a string and paste it at the beginning of a line.
> Interactively, BEG and END are the region."
> (interactive "*p\nr")
> (my-act-on-region-by-line (some-function-to-correct-spacing field-num)
> beg
> end))
>
> (defun some-function-to-correct-spacing (field-num)
> "Function that creates a correctly spaced string."
> ........
I can't /see/ it, but I have a hunch that this function expects
to /replace/ the line by something else. The was it is called
above, its result is /inserted/ in front of the line in question,
right?
Perhaps it's clear to you, but if yes, it doesn't come across:
what is the exact interface between your outer function and
the one called by it?
I.e.: do you need to (save-excursion ...) around `some-chosen-function'?
What do you do with its result? That kind of things.
Cheers
--
t
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-06-17 4:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 22:19 Iterating over buffer lines Joshua Lambert
2023-06-17 0:10 ` Platon Pronko
2023-06-17 3:28 ` Joshua Lambert
2023-06-17 4:48 ` tomas [this message]
[not found] ` <CAGGu9j1gub_8kb92kkD30QmxLmZz8XJrwhyAPtYONE3OLe_zew@mail.gmail.com>
2023-06-17 19:17 ` tomas
2023-06-18 1:17 ` Platon Pronko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZI07GELOjRlAYgHb@tuxteam.de \
--to=tomas@tuxteam.de \
--cc=help-gnu-emacs@gnu.org \
--cc=jlambert.lis.tech@gmail.com \
--cc=platon7pronko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).