From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.help Subject: Re: (interactive) and &optional Date: Thu, 30 Mar 2023 22:04:29 +0300 Message-ID: References: <25628.42021.832534.376361@woitok.gmail.com> <87sfdt6feg.fsf@posteo.net> <87o7ogpbl6.fsf@dataswamp.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28628"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/2.2.9+54 (af2080d) (2022-11-21) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 30 21:30:24 2023 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phxyZ-000792-Ar for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 30 Mar 2023 21:30:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phxxo-0007jO-7t; Thu, 30 Mar 2023 15:29:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phxxm-0007j4-Im for help-gnu-emacs@gnu.org; Thu, 30 Mar 2023 15:29:34 -0400 Original-Received: from stw1.rcdrun.com ([217.170.207.13]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phxxk-0002HJ-T0 for help-gnu-emacs@gnu.org; Thu, 30 Mar 2023 15:29:34 -0400 Original-Received: from localhost ([::ffff:197.239.12.108]) (AUTH: PLAIN admin, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 00000000000F5D11.000000006425E31E.00003D7E; Thu, 30 Mar 2023 12:29:34 -0700 Mail-Followup-To: help-gnu-emacs@gnu.org Content-Disposition: inline In-Reply-To: <87o7ogpbl6.fsf@dataswamp.org> Received-SPF: pass client-ip=217.170.207.13; envelope-from=bugs@gnu.support; helo=stw1.rcdrun.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:143163 Archived-At: * Emanuel Berg [2023-03-27 08:05]: > > (defun search-something (&optional query) > > "Search something by using QUERY." > > (interactive) > > (let ((query (or query (read-from-minibuffer "Query: ")))) > > (message query))) > > This has the same problem as before, it should look something > like this: > > ;;; -*- lexical-binding: t -*- > ;; > ;; this file: > ;; https://dataswamp.org/~incal/emacs-init/geh.el > > (defun search-something (&optional query) > "Search something by using QUERY." > (interactive "sQuery: ") > (unless (and (stringp query) > (not (string= "" query)) ) > (setq query "default search") ) > (message query) ) > > ;; (search-something "love") ; love > ;; (search-something) ; default search > ;; M-x search-something RET RET ; default search > ;; M-x search-something RET love RET ; love That is your design opinion that it should look like that as related to `interactive', and my design is that I avoid putting questions within `interactive' declaration. I find it simpler, more visible, easier to understand, readable, and freeer. For example I can remove (interactive) from function for function still to work, without restructuring, sometimes I find I do not want function any more to be a command. -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns In support of Richard M. Stallman https://stallmansupport.org/