From: <tomas@tuxteam.de>
To: help-gnu-emacs@gnu.org
Subject: Re: [External] : Passing buffers to function in elisp
Date: Wed, 8 Mar 2023 06:38:54 +0100 [thread overview]
Message-ID: <ZAgfbuTosFeP8wRh@tuxteam.de> (raw)
In-Reply-To: <jwvwn3srxoa.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]
On Tue, Mar 07, 2023 at 05:45:49PM -0500, Stefan Monnier wrote:
> >> This is a typical a source of unnecessary O(N²) complexity: the above
> >> line takes O(N) time, so if you do it O(N) times, you got your
> >> N² blowup. You're usually better off doing
> >>
> >> (push (plist-get page :stream) stream-chunks)
> >>
> >> and then at the end get the `stream` with
> >>
> >> (mapconcat #'identity (nreverse stream-chunks) nil)
> >> or
> >> (apply #'vconcat (nreverse stream-chunks))
> >
> > Right, I see. Stream chunks are in this case byte vectors, so
> > just reversing those chunks does not do the trick.
> > But surely I can get from an order of N² to 2N or so.
>
> I'm suggesting to build a list of chunks backward and to reverse *the
> list*, not the chunks. So the end result should still be the same.
Judging by the "2N instead of N^2" I guess Petteri had the right
mental model, though.
> > Okay, this is something I did not foresee. But what about eval-defun
> > and eval-... in general? They are very convenient when trying out
> > things.
>
> It's OK to use them, of course. It usually means you still have 98% of
> your code compiled.
>
> >> The compiler is your friend. He can help you get the code in good
> >> shape :-)
> > I'm afraid that even the compiler cannot help against quadratic
> > complexity blunders.
>
> :-)
>
> It's just a friend, yes.
:-)
Cheers
--
t
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-03-08 5:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 21:18 Passing buffers to function in elisp Petteri Hintsanen
2023-02-21 23:21 ` [External] : " Drew Adams
2023-02-22 5:35 ` tomas
2023-02-24 20:08 ` Petteri Hintsanen
2023-02-25 6:40 ` tomas
2023-02-25 11:23 ` Michael Heerdegen
2023-02-25 13:45 ` tomas
2023-02-25 18:31 ` Michael Heerdegen
2023-02-25 19:05 ` tomas
2023-02-25 23:52 ` Stefan Monnier via Users list for the GNU Emacs text editor
2023-02-27 20:44 ` Petteri Hintsanen
2023-02-28 5:37 ` tomas
2023-03-03 15:19 ` Stefan Monnier via Users list for the GNU Emacs text editor
2023-03-07 21:48 ` Petteri Hintsanen
2023-03-07 22:45 ` Stefan Monnier
2023-03-08 5:38 ` tomas [this message]
2023-09-06 19:05 ` Petteri Hintsanen
2023-09-06 21:12 ` Stefan Monnier
2023-02-22 5:30 ` tomas
2023-02-23 9:34 ` Michael Heerdegen
2023-02-23 9:51 ` tomas
2023-02-23 16:19 ` Marcin Borkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAgfbuTosFeP8wRh@tuxteam.de \
--to=tomas@tuxteam.de \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).