From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.help Subject: Re: Printf and quoting in general, SQL injection in particular [was: Emacs Modular Configuration: the preferable way] Date: Mon, 28 Jun 2021 09:59:22 +0300 Message-ID: References: <20210621211547.GA12274@tuxteam.de> <87pmwevjbs.fsf@zoho.eu> <83bl7yumh1.fsf@gnu.org> <8335taujt6.fsf@gnu.org> <83y2b1ubqt.fsf@gnu.org> <87im212kep.fsf@zoho.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3096"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/2.0.7+183 (3d24855) (2021-05-28) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 28 09:03:23 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lxlIg-0000ba-Gl for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 28 Jun 2021 09:03:22 +0200 Original-Received: from localhost ([::1]:46370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxlIf-0000XA-Hp for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 28 Jun 2021 03:03:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxlHz-0000X1-Rr for help-gnu-emacs@gnu.org; Mon, 28 Jun 2021 03:02:40 -0400 Original-Received: from stw1.rcdrun.com ([217.170.207.13]:47339) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxlHx-0005rv-N7 for help-gnu-emacs@gnu.org; Mon, 28 Jun 2021 03:02:39 -0400 Original-Received: from localhost ([::ffff:41.210.146.17]) (AUTH: PLAIN admin, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 0000000000055D5B.0000000060D9740B.000061FB; Mon, 28 Jun 2021 00:02:35 -0700 Mail-Followup-To: help-gnu-emacs@gnu.org Content-Disposition: inline In-Reply-To: <87im212kep.fsf@zoho.eu> Received-SPF: permerror client-ip=217.170.207.13; envelope-from=bugs@gnu.support; helo=stw1.rcdrun.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:131322 Archived-At: * Emanuel Berg [2021-06-26 02:50]: > Jean Louis wrote: > > > To summarize, it is better to use file related functions > > whenever possible, checking if it is directory, using > > functions like `file-name-as-directory' and so on. > > Yes, of course. > > > (format "%s/%s/" (rcd-crm-directory-by-id) id)) > > (concat (rcd-crm-directory) "/" (cadr (rcd-crm-directory-data)))) > > (concat (rcd-crm-directory) "/" (cadr (rcd-crm-directory-data)))) > > Is this what you are not allowed to do? > > I ask because it looks similar to mine, only not as good, > perhaps. Ha. > > OK, how is it suppose to look then? I think by using file- related functions: (defun doi-file-find (md5) "Return existing MD5 file for Double Opt-In.confirmation or NIL." (let ((file (concat (file-name-as-directory doi-directory) (file-name-as-directory (substring md5 0 doi-substring-to)) md5))) (if (file-exists-p file) file nil))) in that case `file-name-as-directory' is protecting the case of vraiable `doi-directory' not to have slash on the and. Before I have used my function: (defun slash-add (path) "Adds slash `/` quickly on the end of string" (if (string= path "") "/" (let ((last (substring (reverse path) 0 1))) (if (string= last "/") path (concat path "/"))))) Or (defun string-add (string add) "Returns string 'add' on the end of the string if there is none" (let* ((string (replace-regexp-in-string " *" "" string)) (added (string-match (format "%s$" add) string))) (if added string (concat string add)))) When concatenating directory names it is important to take care of slashes. -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns In support of Richard M. Stallman https://stallmansupport.org/