unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Jean Louis <bugs@gnu.support>
To: help-gnu-emacs@gnu.org
Subject: Re: Printf and quoting in general, SQL injection in particular [was: Emacs Modular Configuration: the preferable way]
Date: Mon, 28 Jun 2021 09:59:22 +0300	[thread overview]
Message-ID: <YNlzSvS9GPgCim0h@protected.localdomain> (raw)
In-Reply-To: <87im212kep.fsf@zoho.eu>

* Emanuel Berg <moasenwood@zoho.eu> [2021-06-26 02:50]:
> Jean Louis wrote:
> 
> > To summarize, it is better to use file related functions
> > whenever possible, checking if it is directory, using
> > functions like `file-name-as-directory' and so on.
> 
> Yes, of course.
> 
> > (format "%s/%s/" (rcd-crm-directory-by-id) id))
> > (concat (rcd-crm-directory) "/" (cadr (rcd-crm-directory-data))))
> > (concat (rcd-crm-directory) "/" (cadr (rcd-crm-directory-data))))
> 
> Is this what you are not allowed to do?
> 
> I ask because it looks similar to mine, only not as good,
> perhaps. Ha.
> 
> OK, how is it suppose to look then?

I think by using file- related functions:

(defun doi-file-find (md5)
  "Return existing MD5 file for Double Opt-In.confirmation or NIL."
  (let ((file (concat (file-name-as-directory doi-directory)
		      (file-name-as-directory (substring md5 0 doi-substring-to))
		      md5)))
    (if (file-exists-p file) file nil)))

in that case `file-name-as-directory' is protecting the case of
vraiable `doi-directory' not to have slash on the and.

Before I have used my function:

(defun slash-add (path)
  "Adds slash `/` quickly on the end of string"
  (if (string= path "")
      "/"
    (let ((last (substring (reverse path) 0 1)))
      (if (string= last "/") path
	(concat path "/")))))

Or

(defun string-add (string add)
  "Returns string 'add' on the end of the string if there is none"
  (let* ((string (replace-regexp-in-string " *" "" string))
	 (added (string-match (format "%s$" add) string)))
    (if added string (concat string add))))

When concatenating directory names it is important to take care of slashes.

-- 
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/



  parent reply	other threads:[~2021-06-28  6:59 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21  1:40 Emacs Modular Configuration: the preferable way Hongyi Zhao
2021-06-21  2:56 ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-21  6:40   ` Jean Louis
2021-06-21 16:31     ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-21 19:55       ` Jean Louis
2021-06-22  0:06         ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-21 10:14   ` Arthur Miller
2021-06-21 16:40     ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-21 18:25       ` [External] : " Drew Adams
2021-06-26  0:17         ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-26  0:31           ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-21 18:38       ` Arthur Miller
2021-06-22  0:03         ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-22  0:17           ` Jean Louis
2021-06-22  7:52           ` Arthur Miller
2021-06-26  6:58             ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-21 11:29   ` Eli Zaretskii
2021-06-21 12:45     ` Philip Kaludercic
2021-06-21 12:55       ` Eli Zaretskii
2021-06-21 13:59         ` [External] : " Drew Adams
2021-06-21 16:51           ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-21 18:08             ` Eli Zaretskii
2021-06-21 18:26             ` FW: " Drew Adams
2021-06-26  0:06               ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-21 14:11       ` tomas
2021-06-21 16:47         ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-21 18:06           ` Eli Zaretskii
2021-06-21 21:09             ` Jean Louis
2021-06-22 11:45               ` Eli Zaretskii
2021-06-22 12:29                 ` Jean Louis
2021-06-22 13:07                   ` Eli Zaretskii
2021-06-21 20:05           ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-06-22  0:16             ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-21 21:07           ` Jean Louis
2021-06-22  0:33             ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-22  0:52               ` Printf and quoting in general, SQL injection in particular Jean Louis
2021-06-26  6:50                 ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-26  7:30                   ` Yuri Khan
2021-06-26  7:57                     ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-26  9:37                     ` tomas
2021-06-28  7:02                   ` Jean Louis
2021-07-06  2:12                     ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-07-06  2:46                       ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-21 20:36         ` Emacs Modular Configuration: the preferable way Jean Louis
2021-06-21 21:15           ` Printf and quoting in general, SQL injection in particular [was: Emacs Modular Configuration: the preferable way] tomas
2021-06-21 21:29             ` Jean Louis
2021-06-22  0:31               ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-22  0:47                 ` Jean Louis
2021-06-26  6:31                   ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-28  6:56                     ` Jean Louis
2021-07-06  1:57                       ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-07-06 20:04                         ` Jean Louis
2021-07-06 20:19                           ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-22  0:23             ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-22 12:12               ` Eli Zaretskii
2021-06-22 12:37                 ` Jean Louis
2021-06-22 13:10                   ` Eli Zaretskii
2021-06-22 15:45                     ` Jean Louis
2021-06-22 16:04                       ` Eli Zaretskii
2021-06-22 18:01                         ` Jean Louis
2021-06-22 18:25                           ` Eli Zaretskii
2021-06-26  6:46                           ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-26  7:15                             ` Eli Zaretskii
2021-06-28  7:04                               ` Jean Louis
2021-07-06  2:05                                 ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-07-06 20:09                                   ` Jean Louis
2021-07-06 20:23                                     ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-07-07  0:00                                       ` Jean Louis
2021-06-28  6:59                             ` Jean Louis [this message]
2021-07-06  2:02                               ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-07-06 20:06                                 ` Jean Louis
2021-07-06 20:20                                   ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-26  6:41                       ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-26  6:39                   ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-21 16:42       ` Emacs Modular Configuration: the preferable way Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-22 12:50       ` Lars Ingebrigtsen
2021-06-26  8:05         ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-21 20:02   ` Jean Louis
2021-06-22  0:11     ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-06-22  0:19       ` Jean Louis
2021-06-21  6:37 ` Jean Louis
2021-06-21  7:00   ` Hongyi Zhao
2021-06-21 10:06     ` Arthur Miller
2021-06-21 10:26       ` Hongyi Zhao
2021-06-21 11:10         ` Arthur Miller
2021-06-23  2:17           ` Hongyi Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNlzSvS9GPgCim0h@protected.localdomain \
    --to=bugs@gnu.support \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).