From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.help Subject: Re: Example use of macro to minimize and generalize the code Date: Tue, 1 Jun 2021 19:33:36 +0300 Message-ID: References: <87a6oad81r.fsf@zoho.eu> <87y2buscef.fsf@web.de> <87k0nes9s0.fsf@web.de> <878s3us8le.fsf@web.de> <87fsy1y97e.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12118"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/2.0.7+183 (3d24855) (2021-05-28) Cc: help-gnu-emacs@gnu.org To: Michael Heerdegen Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 01 18:38:58 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lo7Pt-0002vy-PV for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 01 Jun 2021 18:38:57 +0200 Original-Received: from localhost ([::1]:35488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lo7Ps-0000pU-KM for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 01 Jun 2021 12:38:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo7Oj-0007r9-DJ for help-gnu-emacs@gnu.org; Tue, 01 Jun 2021 12:37:45 -0400 Original-Received: from stw1.rcdrun.com ([217.170.207.13]:42321) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo7Oh-0000te-Kl for help-gnu-emacs@gnu.org; Tue, 01 Jun 2021 12:37:45 -0400 Original-Received: from localhost ([::ffff:197.157.0.35]) (AUTH: PLAIN admin, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 00000000000AE2D9.0000000060B66252.00006E69; Tue, 01 Jun 2021 09:37:37 -0700 Mail-Followup-To: Michael Heerdegen , help-gnu-emacs@gnu.org Content-Disposition: inline In-Reply-To: <87fsy1y97e.fsf@web.de> Received-SPF: pass client-ip=217.170.207.13; envelope-from=bugs@gnu.support; helo=stw1.rcdrun.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_SORBS_WEB=1.5, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:130462 Archived-At: * Michael Heerdegen [2021-06-01 17:03]: > Jean Louis writes: > > > (defmacro when-tabulated-id (table &rest body) > > (declare (indent 2) (debug t)) > > ;;(ignore id) > > `(if id > > (progn > > ,@body) > > (if (or (eq ,table 'any) > > (string-equal ,table rcd-current-table)) > > (let ((id (tabulated-list-get-id))) > > (if id > > (progn ,@body) > > (message "Did not get ID"))) > > (message "This function is for table `%s' only" ,table)))) > > Yes, better. > > The downside now is that using the macro hides the fact that the code > depends on the id, and the resulting code is (still) hard to understand. > Why don't you consider to make the id a real argument? I wish I could fully understand but I don't, and I consider your advises important. How would I make the ID a real argument? Each of those functions has &optional id as if function is not capturing ID from tabulated-list-mode then it may receive it programmatically. Example: (defun hyperscope-new-appointment (&optional id) "Add new `Appointment' hyperdocument." (interactive) (when-tabulated-id "hyobjects" (let ((parent (hlink-parent id))) (hyperscope-add-new-appointment-hyperdocument parent)))) -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns Sign an open letter in support of Richard M. Stallman https://stallmansupport.org/