From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.help Subject: Re: Example use of macro to minimize and generalize the code Date: Tue, 1 Jun 2021 04:25:33 +0300 Message-ID: References: <87mtsbd31w.fsf@zoho.eu> <87a6oad81r.fsf@zoho.eu> <87y2buscef.fsf@web.de> <87k0nes9s0.fsf@web.de> <878s3us8le.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1571"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/2.0.7+183 (3d24855) (2021-05-28) Cc: help-gnu-emacs@gnu.org To: Michael Heerdegen Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 01 03:28:04 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lntCO-0000Ca-O2 for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 01 Jun 2021 03:28:04 +0200 Original-Received: from localhost ([::1]:37892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lntCN-00020z-O9 for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 31 May 2021 21:28:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lntC2-00020q-Pc for help-gnu-emacs@gnu.org; Mon, 31 May 2021 21:27:42 -0400 Original-Received: from stw1.rcdrun.com ([217.170.207.13]:54647) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lntC1-0001JH-1v for help-gnu-emacs@gnu.org; Mon, 31 May 2021 21:27:42 -0400 Original-Received: from localhost ([::ffff:197.157.0.35]) (AUTH: PLAIN admin, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 00000000000ADF27.0000000060B58D0A.00000E33; Mon, 31 May 2021 18:27:37 -0700 Mail-Followup-To: Michael Heerdegen , help-gnu-emacs@gnu.org Content-Disposition: inline In-Reply-To: <878s3us8le.fsf@web.de> Received-SPF: pass client-ip=217.170.207.13; envelope-from=bugs@gnu.support; helo=stw1.rcdrun.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_SORBS_WEB=1.5, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:130425 Archived-At: * Michael Heerdegen [2021-06-01 04:00]: > Jean Louis writes: > > > - ID is necessary; > > Your macro calls always ignore what you specify at that argument's > position. Instead, the macros refer to a (free) variable `id'. AFAICT, > with your current implementation nothing would change if you would > remove the macro argument (and the `ignore' call) and simply don't use > it. > > Typically, the backquote expression in the macro body would have ",id" > instead of "id" to include the value specified by the ID argument. The > compiler warning is not just noise. I do believe you see it what you say, but I didn't see what you say... (✿╹◡╹) -- so yes, now it works, thanks. I have removed `id' and `ignore' and there are no compiler warnings and there is for now no impact how I see that. That comes due to various testing, I have actually started it that way, there was no ID, then I messed something up and addedd ID and now you see more, and I removed it from bunch of functions. For now it works. (defmacro when-tabulated-id (table &rest body) (declare (indent 2) (debug t)) ;;(ignore id) `(if id (progn ,@body) (if (or (eq ,table 'any) (string-equal ,table rcd-current-table)) (let ((id (tabulated-list-get-id))) (if id (progn ,@body) (message "Did not get ID"))) (message "This function is for table `%s' only" ,table)))) -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns Sign an open letter in support of Richard M. Stallman https://stallmansupport.org/