From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.help Subject: Re: Example use of macro to minimize and generalize the code Date: Tue, 1 Jun 2021 03:39:25 +0300 Message-ID: References: <87k0nfesns.fsf@zoho.eu> <87mtsbd31w.fsf@zoho.eu> <87a6oad81r.fsf@zoho.eu> <87y2buscef.fsf@web.de> <87k0nes9s0.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="327"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/2.0.7+183 (3d24855) (2021-05-28) Cc: help-gnu-emacs@gnu.org To: Michael Heerdegen Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 01 02:43:02 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnsUn-000AQ4-4q for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 01 Jun 2021 02:43:01 +0200 Original-Received: from localhost ([::1]:58162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnsUm-0002ji-4d for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 31 May 2021 20:43:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnsUT-0002jI-8U for help-gnu-emacs@gnu.org; Mon, 31 May 2021 20:42:41 -0400 Original-Received: from stw1.rcdrun.com ([217.170.207.13]:45477) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnsUR-0007HO-Ix for help-gnu-emacs@gnu.org; Mon, 31 May 2021 20:42:41 -0400 Original-Received: from localhost ([::ffff:197.157.0.35]) (AUTH: PLAIN admin, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 00000000000ADF01.0000000060B5827D.00000B21; Mon, 31 May 2021 17:42:37 -0700 Mail-Followup-To: Michael Heerdegen , help-gnu-emacs@gnu.org Content-Disposition: inline In-Reply-To: <87k0nes9s0.fsf@web.de> Received-SPF: pass client-ip=217.170.207.13; envelope-from=bugs@gnu.support; helo=stw1.rcdrun.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_SORBS_WEB=1.5, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:130420 Archived-At: * Michael Heerdegen [2021-06-01 03:35]: > Jean Louis writes: > > > [...] > > That is why `ignore' is there. Ignore is there to suppress the byte > > compiler warning just as you guessed it. > > > > Otherwise: > > > > In when-tabulated-id: > > rcd-cf.el:165:45: Warning: Unused lexical argument `id' > > Sure - but why do you add an argument to that macro that it (or its > expansion) doesn't use at all? That's very confusing, it would be > better to remove the argument. Or - could the macro be rewritten to not > ignore that argument? I would like to improve but I have to understand what you mean. This is the macro, arguments are table, id and body. I need all of them. - table is there as I don't want my functions invoked in other tables, it could cause havoc; - ID is necessary; - functions can be then invoked programmatically and interactively with less arguments: So help me understand... (defmacro when-tabulated-id (table id &rest body) (declare (indent 2) (debug t)) (ignore id) `(if id (progn ,@body) (if (or (eq ,table 'any) (string-equal ,table rcd-current-table)) (let ((id (tabulated-list-get-id))) (if id (progn ,@body) (message "Did not get ID"))) (message "This function is for table `%s' only" ,table)))) -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns Sign an open letter in support of Richard M. Stallman https://stallmansupport.org/