From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.help Subject: Re: Maybe we can improve this function call-process-to-string? Date: Thu, 8 Apr 2021 21:33:57 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2064"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/2.0.6 (2021-03-06) Cc: help-gnu-emacs@gnu.org To: Stefan Monnier Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 08 20:37:07 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUZWc-0000QP-8m for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 08 Apr 2021 20:37:06 +0200 Original-Received: from localhost ([::1]:53478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUZWb-000208-AE for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 08 Apr 2021 14:37:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUZVA-0000ot-8J for help-gnu-emacs@gnu.org; Thu, 08 Apr 2021 14:35:36 -0400 Original-Received: from stw1.rcdrun.com ([217.170.207.13]:54767) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUZV8-00035F-Cw for help-gnu-emacs@gnu.org; Thu, 08 Apr 2021 14:35:35 -0400 Original-Received: from localhost ([::ffff:41.202.241.27]) (AUTH: PLAIN securesender, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 000000000001DF56.00000000606F4CF3.000014E3; Thu, 08 Apr 2021 11:35:31 -0700 Mail-Followup-To: Stefan Monnier , help-gnu-emacs@gnu.org Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=217.170.207.13; envelope-from=bugs@gnu.support; helo=stw1.rcdrun.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:128908 Archived-At: * Stefan Monnier [2021-04-08 20:50]: > > (defun call-process-to-string (program &optional infile display &rest args) > > (let* ((buffer-name "Output") > > (buffer (generate-new-buffer buffer-name)) > > (status (apply #'call-process program infile buffer display args)) > > (current-buffer (current-buffer)) > > (output (if status > > (progn > > (switch-to-buffer buffer) > > (buffer-string)) > > ""))) > > (switch-to-buffer current-buffer) > > output)) > > The docstring of `switch-to-buffer` is fairly long, but the first > 5 lines are recommended reading: > > Display buffer BUFFER-OR-NAME in the selected window. > > WARNING: This is NOT the way to work on another buffer temporarily > within a Lisp program! Use `set-buffer' instead. That avoids > messing with the window-buffer correspondences. Oh, that is right, thanks. > Also the above code forgot to kill the buffer you created. > I recommend `with-temp-buffer` here instead: > > (with-temp-buffer > (apply #'call-process program infile t display args) > (buffer-string)) > > > -- Stefan That looks perfect, thank you. -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns Sign an open letter in support of Richard M. Stallman https://rms-support-letter.github.io/