From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.help Subject: Re: Better way to make sure external command exists in the system? Date: Tue, 23 Mar 2021 11:02:32 +0300 Message-ID: References: <87y2ego29q.fsf@zoho.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23721"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/2.0.6 (2021-03-06) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 23 09:05:15 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOc2M-00063d-UD for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 23 Mar 2021 09:05:14 +0100 Original-Received: from localhost ([::1]:53108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOc2L-0006jE-Vo for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 23 Mar 2021 04:05:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOc1s-0006iw-OO for help-gnu-emacs@gnu.org; Tue, 23 Mar 2021 04:04:44 -0400 Original-Received: from stw1.rcdrun.com ([217.170.207.13]:42027) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOc1q-00037y-6V for help-gnu-emacs@gnu.org; Tue, 23 Mar 2021 04:04:44 -0400 Original-Received: from localhost ([::ffff:41.202.241.53]) (AUTH: PLAIN securesender, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 000000000001E082.000000006059A0E0.0000499D; Tue, 23 Mar 2021 01:03:43 -0700 Mail-Followup-To: help-gnu-emacs@gnu.org Content-Disposition: inline In-Reply-To: <87y2ego29q.fsf@zoho.eu> Received-SPF: pass client-ip=217.170.207.13; envelope-from=bugs@gnu.support; helo=stw1.rcdrun.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:128516 Archived-At: * Emanuel Berg via Users list for the GNU Emacs text editor [2021-03-21 20:18]: > Jean Louis wrote: > > > I would not like later invoking functions that don't work. > > But I do the checks in the functions. Sometimes majority of > > functions belong in the same domain that uses > > external commands. > > > > (defun rcd-which-list (command-list) > > "Verifies that list of shell commands COMMAND-LIST exist in > > user's $PATH" > > (let ((all-exist t)) > > (dolist (command command-list all-exist) > > (unless (executable-find command) > > (setq all-exist nil) > > (rcd-warning-message "Shell command `%s' does not exist" command))))) > > > > [and much more Elisp] > > I'll read it, if you fix all this first... > > byte compiler: > > geh.el: > In image-resize-dired: > geh.el:324:32: Warning: reference to free variable > ‘*image-default-resize-size*’ ;;; image-resize-dired.el --- Function to resize images in Dired ;; dired-get-marked-files is in dired ;;; Commentary: ;; ;;; Code: (require 'dired) (defvar *image-default-resize-size* 1536) (defvar *image-resize-sizes* '("1536" "1024" "800" "1200" "640")) ;; Place your warning sound file yourself (defcustom rcd-warning-message-sound-file nil "The sound file for warning messages." :group 'rcd :type 'string) (defun image-resize (file &optional size) "Resizes the JPG image with default SIZE. Argument FILE is image to be resized." (if (rcd-which-list '("mogrify")) (let ((extension (file-name-extension file))) (when (or (equal (downcase extension) "jpg") (equal (downcase extension) "png")) (let* ((file (shell-double-quote file)) (command (format "mogrify -resize %s \"%s\"" size file))) (message command) (call-process-shell-command command)))) (rcd-warning-message "RCD ERROR: `mogrify' not found in `$PATH'"))) (defun image-resize-dired () "Resizes images." (interactive) (let ((files (dired-get-marked-files)) (size (read-number "Size: " *image-default-resize-size* '(*image-resize-sizes*)))) (dolist (file files) (image-resize file size)) (revert-buffer))) (defun shell-double-quote (s) "Double quotes for the string that shall be fed to shell command. Argument S is string." (replace-regexp-in-string "\"" "\\\\\"" s)) (provide 'image-resize-dired) ;;; image-resize-dired.el ends here