From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.help Subject: Re: How to avoid compiler warning `unused lexical variable' for `dolist' or `dotimes'? Date: Thu, 7 Jan 2021 14:00:56 +0300 Message-ID: References: <878s95qd1p.fsf@zoho.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26976"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/2.0 (3d08634) (2020-11-07) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 07 12:04:03 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxT5H-0006tq-9H for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 07 Jan 2021 12:04:03 +0100 Original-Received: from localhost ([::1]:45608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxT5G-0003La-9g for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 07 Jan 2021 06:04:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxT4k-0003LI-Du for help-gnu-emacs@gnu.org; Thu, 07 Jan 2021 06:03:30 -0500 Original-Received: from stw1.rcdrun.com ([217.170.207.13]:35775) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxT4i-0000Fa-5T for help-gnu-emacs@gnu.org; Thu, 07 Jan 2021 06:03:29 -0500 Original-Received: from localhost ([::ffff:41.210.154.95]) (AUTH: PLAIN securesender, TLS: TLS1.2,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 000000000029543E.000000005FF6EA7D.000054F6; Thu, 07 Jan 2021 04:03:24 -0700 Mail-Followup-To: help-gnu-emacs@gnu.org Content-Disposition: inline In-Reply-To: <878s95qd1p.fsf@zoho.eu> Received-SPF: pass client-ip=217.170.207.13; envelope-from=bugs@gnu.support; helo=stw1.rcdrun.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:127043 Archived-At: * Emanuel Berg via Users list for the GNU Emacs text editor [2021-01-07 13:07]: > Jean Louis wrote: > > > (defun db/table-id-plist (table id pg) > > "Returns plist for table by its table_id" > > (let* ((columns (db/table-columns table pg)) > > (sql (db/sql-by-columns table columns id)) > > (values (rcd-sql-first sql pg)) > > (values (append values nil)) > > (length (length columns)) > > (plist '())) > > (dotimes (i length plist) > > (setf plist (plist-put plist (intern (elt columns i)) (elt values i)))))) > > > > What is proper way to avoid this warning in `dolist' or > > `dotimes': > > > > rcd-db.el:841:1: Warning: Unused lexical variable ‘i’ > > > > Declaring variable `i' in `let' before `dolist' or `dotimes' > > did not help. > > Right. Let's just say it is a `dotimes' thing, see line > 309-310, /usr/local/share/emacs/28.0.50/lisp/subr.el > > ;; FIXME: This let often leads to "unused var" warnings. > `((let ((,(car spec) ,counter)) ,@(cddr spec)))))) > > (require 'cl-lib) > > (defun db/table-id-plist (table id pg) > "Do something with TABLE, ID and PG." > (let*((cols (db/table-columns table pg)) > (sql (db/sql-by-columns table cols id)) > (vals (rcd-sql-first sql pg)) > (plist) ) > (cl-loop for c in cols > for v in vals > do (setf plist (plist-put plist (intern c) v)) ))) Thank you. cl-loop I have used all times in Common Lisp, fine, but not so nice. So instead of `dolist' I can use mapcar or similar function with lambda and there is no complaint. I would rather like to solve `dolist' compiler complain, and not change to more complex `cl-loop' and avoid changing to `mapcar' usage. Jean