How to stop all edebug?

How to stop all edebug?

[Zhang Haijun]

I edebug(use edebug-defun) some functions in file.el and then close file.el. When I open a new file, emacs aborts and show a buffer with edebug error(It can’t find the original buffer to debug).

And I event can’t quit emacs because there are functions in kill-emacs-hook  which try to open file and save data(such as recentf).

Is it possible to cleanup all edebug sessions?

Re: How to stop all edebug?

[Michael Heerdegen]

Zhang Haijun <ccsmile2008@outlook.com> writes:

> I edebug(use edebug-defun) some functions in file.el and then close
> file.el. When I open a new file, emacs aborts and show a buffer with
> edebug error(It can’t find the original buffer to debug).
>
> And I event can’t quit emacs because there are functions in
> kill-emacs-hook which try to open file and save data(such as recentf).
>
> Is it possible to cleanup all edebug sessions?

There has been a commit to the master branch some days ago that makes
`cancel-edebug-on-entry' do that by default (confirm with an empty
prompt).  If you don't use the master branch, this is the code that does
what you want:

(dolist (function (edebug--edebug-on-entry-functions))
  (put function 'edebug-on-entry nil))


Michael.

Re: How to stop all edebug?

[Lars Magne Ingebrigtsen]

Michael Heerdegen <michael_heerdegen@web.de> writes:

> There has been a commit to the master branch some days ago that makes
> `cancel-edebug-on-entry' do that by default (confirm with an empty
> prompt).  If you don't use the master branch, this is the code that does
> what you want:
>
> (dolist (function (edebug--edebug-on-entry-functions))
>   (put function 'edebug-on-entry nil))

That doesn't remove the edebugging, though -- it just removes the "stop"
instrumentation on those functions.  (So edebug-on-entry isn't analogous
to debug-on-entry, confusingly enough.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: How to stop all edebug?

[Stefan Monnier]

> I edebug(use edebug-defun) some functions in file.el and then close
> file.el. When I open a new file, emacs aborts and show a buffer with edebug
> error(It can’t find the original buffer to debug).
>
> And I event can’t quit emacs because there are functions in kill-emacs-hook
> which try to open file and save data(such as recentf).

Could you make a bug report for that?

If the source buffer is not available any more (as in your case above),
it's OK for Edebug to complain loudly, but it shouldn't prevent you from
using Emacs normally enough to exit or restore sanity.

E.g. after "aborts and show a buffer with edebug error" it could/should
offer to either cancel the "edebug on entry" or to de-instrument the function.


        Stefan

Re: How to stop all edebug?

[Eli Zaretskii]

> From: Zhang Haijun <ccsmile2008@outlook.com>
> Date: Wed, 23 Oct 2019 04:56:28 +0000
> 
> I edebug(use edebug-defun) some functions in file.el and then close file.el. When I open a new file, emacs aborts and show a buffer with edebug error(It can’t find the original buffer to debug).
> 
> And I event can’t quit emacs because there are functions in kill-emacs-hook  which try to open file and save data(such as recentf).
> 
> Is it possible to cleanup all edebug sessions?

I usually "M-x load-library" each file where I instrumented some
functions.

Re: How to stop all edebug?

[HaiJun Zhang]

在 2019年10月23日 +0800 PM2:47，Michael Heerdegen <michael_heerdegen@web.de>，写道：
 If you don't use the master branch, this is the code that does
what you want:

(dolist (function (edebug--edebug-on-entry-functions))
(put function 'edebug-on-entry nil))

I eval the form. Emacs(26.3 on macOS) shows error like this:

Debugger entered--Lisp error: (void-function edebug--edebug-on-entry-functions)
 (edebug--edebug-on-entry-functions)
 (let ((--dolist-tail-- (edebug--edebug-on-entry-functions)) function) (while --dolist-tail-- (setq function (car --dolist-tail--)) (put function (quote edebug-on-entry) nil) (setq --dolist-tail-- (cdr --dolist-tail--))))
 eval((let ((--dolist-tail-- (edebug--edebug-on-entry-functions)) function) (while --dolist-tail-- (setq function (car --dolist-tail--)) (put function (quote edebug-on-entry) nil) (setq --dolist-tail-- (cdr --dolist-tail--)))) nil)
 elisp--eval-last-sexp(nil)
 eval-last-sexp(nil)
 funcall-interactively(eval-last-sexp nil)
 call-interactively(eval-last-sexp nil nil)
 command-execute(eval-last-sexp)

Re: How to stop all edebug?

[HaiJun Zhang]

在 2019年10月23日 +0800 PM8:43，Stefan Monnier <monnier@iro.umontreal.ca>，写道：

Could you make a bug report for that?

Done. mailto:37899@debbugs.gnu.org

Re: How to stop all edebug?

[HaiJun Zhang]

在 2019年10月24日 +0800 AM12:09，Eli Zaretskii <eliz@gnu.org>，写道：

I usually "M-x load-library" each file where I instrumented some
functions.

Is it possible to add a command to do all these work?

Re: How to stop all edebug?

[Michael Heerdegen]

HaiJun Zhang <netjune@outlook.com> writes:

> 在 2019年10月23日 +0800 PM2:47，Michael Heerdegen
> <michael_heerdegen@web.de>，写道：
>  If you don't use the master branch, this is the code that does
> what you want:
>
> (dolist (function (edebug--edebug-on-entry-functions))
> (put function 'edebug-on-entry nil))
>
> I eval the form. Emacs(26.3 on macOS) shows error like this:

Correct - my mistake.  The missing function had been added in the same
commit some days ago.  Here it is the complete code:

#+begin_src emacs-lisp
(defun edebug--edebug-on-entry-functions ()
  (let ((functions nil))
    (mapatoms
     (lambda (symbol)
       (when (and (fboundp symbol)
                  (get symbol 'edebug-on-entry))
         (push symbol functions)))
     obarray)
    functions))

(dolist (function (edebug--edebug-on-entry-functions))
  (put function 'edebug-on-entry nil))
#+end_src

That should work now.


Michael.

Re: How to stop all edebug?

[Michael Heerdegen]

Lars Magne Ingebrigtsen <lmi@gnus.org> writes:

> > (dolist (function (edebug--edebug-on-entry-functions))
> >   (put function 'edebug-on-entry nil))
>
> That doesn't remove the edebugging, though -- it just removes the "stop"
> instrumentation on those functions.  (So edebug-on-entry isn't analogous
> to debug-on-entry, confusingly enough.)

Yes, and you already have added a command
`edebug-remove-instrumentation' ("Remove Edebug instrumentation from all
functions.") to master 4 days ago which does the other part.

Michael.

Re: How to stop all edebug?

[HaiJun Zhang]

在 2019年10月24日 +0800 PM7:05，Michael Heerdegen <michael_heerdegen@web.de>，写道：

Correct - my mistake. The missing function had been added in the same
commit some days ago. Here it is the complete code:

#+begin_src emacs-lisp
(defun edebug--edebug-on-entry-functions ()
(let ((functions nil))
(mapatoms
(lambda (symbol)
(when (and (fboundp symbol)
(get symbol 'edebug-on-entry))
(push symbol functions)))
obarray)
functions))

(dolist (function (edebug--edebug-on-entry-functions))
(put function 'edebug-on-entry nil))
#+end_src

That should work now.

I tried and it didn’t work. I eval `(edebug--edebug-on-entry-functions)` and it returns nil.

Re: How to stop all edebug?

[HaiJun Zhang]

在 2019年10月24日 +0800 PM8:45，HaiJun Zhang <netjune@outlook.com>，写道：

I tried and it didn’t work. I eval `(edebug--edebug-on-entry-functions)` and it returns nil.


I see the new command `edebug-remove-instrumentation` in emacs 27. I copied the source code of the command and tried it in emacs 26.3. It worked.

Thanks.

Re: How to stop all edebug?

[Michael Heerdegen]

HaiJun Zhang <netjune@outlook.com> writes:

> I tried and it didn’t work. I eval
> `(edebug--edebug-on-entry-functions)` and it returns nil.

Oh well, correct again, that doesn't work as well, sorry for wasting
your time.

Ok, now I have tested that Lars' new `edebug-remove-instrumentation':

#+begin_src emacs-lisp
(defun edebug-remove-instrumentation ()
  "Remove Edebug instrumentation from all functions."
  (interactive)
  (let ((functions nil))
    (mapatoms
     (lambda (symbol)
       (when (and (functionp symbol)
                  (get symbol 'edebug))
         (let ((unwrapped (edebug-unwrap* (symbol-function symbol))))
           (unless (equal unwrapped (symbol-function symbol))
             (push symbol functions)
             (setf (symbol-function symbol) unwrapped)))))
     obarray)
    (if (not functions)
        (message "Found no functions to remove instrumentation from")
      (message "Remove edebug instrumentation from %s"
               (mapconcat #'symbol-name functions ", ")))))
#+end_src

works for me at least in 26.1.  Can you please try that?  Just M-x
edebug-remove-instrumentation.

Regards,

Michael.

Re: How to stop all edebug?

[HaiJun Zhang]

在 2019年10月24日 +0800 PM9:13，Michael Heerdegen <michael_heerdegen@web.de>，写道：
HaiJun Zhang <netjune@outlook.com> writes:

I tried and it didn’t work. I eval
`(edebug--edebug-on-entry-functions)` and it returns nil.

Oh well, correct again, that doesn't work as well, sorry for wasting
your time.

Ok, now I have tested that Lars' new `edebug-remove-instrumentation':

#+begin_src emacs-lisp
(defun edebug-remove-instrumentation ()
"Remove Edebug instrumentation from all functions."
(interactive)
(let ((functions nil))
(mapatoms
(lambda (symbol)
(when (and (functionp symbol)
(get symbol 'edebug))
(let ((unwrapped (edebug-unwrap* (symbol-function symbol))))
(unless (equal unwrapped (symbol-function symbol))
(push symbol functions)
(setf (symbol-function symbol) unwrapped)))))
obarray)
(if (not functions)
(message "Found no functions to remove instrumentation from")
(message "Remove edebug instrumentation from %s"
(mapconcat #'symbol-name functions ", ")))))
#+end_src

works for me at least in 26.1. Can you please try that? Just M-x
edebug-remove-instrumentation.

Regards,

Michael.

I tried. It works in 26.3.

Thanks.