:family and :height in set-face-attribute

:family and :height in set-face-attribute

[Heime]

I have the following command working

(buffer-face-mode-invoke
  `(:family ,face-family :height ,(string-to-number face-height)) t)

But this one does not

(set-face-attribute 'default nil
  :family face-family :height (string-to-number face-height))




Sent with Proton Mail secure email.

Re: :family and :height in set-face-attribute

[Eli Zaretskii]

> Date: Mon, 24 Jun 2024 10:32:25 +0000
> From: Heime <heimeborgia@protonmail.com>
> 
> 
> I have the following command working
> 
> (buffer-face-mode-invoke
>   `(:family ,face-family :height ,(string-to-number face-height)) t)
> 
> But this one does not
> 
> (set-face-attribute 'default nil
>   :family face-family :height (string-to-number face-height))

Works for me.  But since you haven't shown the values of face-family
and face-height, it's hard to tell whether I reproduced what you do.

Re: :family and :height in set-face-attribute

[Heime]

Sent with Proton Mail secure email.

On Monday, June 24th, 2024 at 12:54 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> > Date: Mon, 24 Jun 2024 10:32:25 +0000
> > From: Heime heimeborgia@protonmail.com
> > 
> > I have the following command working
> > 
> > (buffer-face-mode-invoke
> > `(:family ,face-family :height ,(string-to-number face-height)) t)
> > 
> > But this one does not
> > 
> > (set-face-attribute 'default nil
> > :family face-family :height (string-to-number face-height))
> 
> 
> Works for me. But since you haven't shown the values of face-family
> and face-height, it's hard to tell whether I reproduced what you do.

This is it

(defvar monatt nil
  "A boolean variable that is true by default.")

(defun monfont (face-family face-height)

  (interactive

    (list

      (let ( (cseq '("Wargames" "URW Chancery L" "Century Schoolbook L" "Bold Oblique")) )

        (completing-read " Family Name: " cseq nil t "Bold Oblique"))


      (let ( (hseq '("340" "300" "260" "220" "180")) )

        (completing-read " Face Height: " hseq nil t "180")) ))

  (if monatt

      (buffer-face-mode-invoke

        `(:family ,face-family :height ,(string-to-number face-height)) t)

    (set-face-attribute 'default nil

      :family face-family :height (string-to-number face-height)) ))

Re: :family and :height in set-face-attribute

[Eli Zaretskii]

> Date: Mon, 24 Jun 2024 14:57:09 +0000
> From: Heime <heimeborgia@protonmail.com>
> Cc: help-gnu-emacs@gnu.org
> 
> On Monday, June 24th, 2024 at 12:54 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> > > Date: Mon, 24 Jun 2024 10:32:25 +0000
> > > From: Heime heimeborgia@protonmail.com
> > > 
> > > I have the following command working
> > > 
> > > (buffer-face-mode-invoke
> > > `(:family ,face-family :height ,(string-to-number face-height)) t)
> > > 
> > > But this one does not
> > > 
> > > (set-face-attribute 'default nil
> > > :family face-family :height (string-to-number face-height))
> > 
> > 
> > Works for me. But since you haven't shown the values of face-family
> > and face-height, it's hard to tell whether I reproduced what you do.
> 
> This is it
> 
> (defvar monatt nil
>   "A boolean variable that is true by default.")
> 
> (defun monfont (face-family face-height)
> 
>   (interactive
> 
>     (list
> 
>       (let ( (cseq '("Wargames" "URW Chancery L" "Century Schoolbook L" "Bold Oblique")) )
> 
>         (completing-read " Family Name: " cseq nil t "Bold Oblique"))
> 
> 
>       (let ( (hseq '("340" "300" "260" "220" "180")) )
> 
>         (completing-read " Face Height: " hseq nil t "180")) ))
> 
>   (if monatt
> 
>       (buffer-face-mode-invoke
> 
>         `(:family ,face-family :height ,(string-to-number face-height)) t)
> 
>     (set-face-attribute 'default nil
> 
>       :family face-family :height (string-to-number face-height)) ))

Come on, can't you just show the values you use in the
set-face-attribute call?

Also, is the value of face-family with which you call
set-face-attribute one of the families returned by font-family-list?

Re: :family and :height in set-face-attribute

[Heime]

Sent with Proton Mail secure email.

On Monday, June 24th, 2024 at 3:34 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> > Date: Mon, 24 Jun 2024 14:57:09 +0000
> > From: Heime heimeborgia@protonmail.com
> > Cc: help-gnu-emacs@gnu.org
> > 
> > On Monday, June 24th, 2024 at 12:54 PM, Eli Zaretskii eliz@gnu.org wrote:
> > 
> > > > Date: Mon, 24 Jun 2024 10:32:25 +0000
> > > > From: Heime heimeborgia@protonmail.com
> > > > 
> > > > I have the following command working
> > > > 
> > > > (buffer-face-mode-invoke
> > > > `(:family ,face-family :height ,(string-to-number face-height)) t)
> > > > 
> > > > But this one does not
> > > > 
> > > > (set-face-attribute 'default nil
> > > > :family face-family :height (string-to-number face-height))
> > > 
> > > Works for me. But since you haven't shown the values of face-family
> > > and face-height, it's hard to tell whether I reproduced what you do.
> > 
> > This is it
> > 
> > (defvar monatt nil
> > "A boolean variable that is true by default.")
> > 
> > (defun monfont (face-family face-height)
> > 
> > (interactive
> > 
> > (list
> > 
> > (let ( (cseq '("Wargames" "URW Chancery L" "Century Schoolbook L" "Bold Oblique")) )
> > 
> > (completing-read " Family Name: " cseq nil t "Bold Oblique"))
> > 
> > (let ( (hseq '("340" "300" "260" "220" "180")) )
> > 
> > (completing-read " Face Height: " hseq nil t "180")) ))
> > 
> > (if monatt
> > 
> > (buffer-face-mode-invoke
> > 
> > `(:family ,face-family :height ,(string-to-number face-height)) t)
> > 
> > (set-face-attribute 'default nil
> > 
> > :family face-family :height (string-to-number face-height)) ))
> 
> 
> Come on, can't you just show the values you use in the
> set-face-attribute call?

I use the strings in cseq
 
> Also, is the value of face-family with which you call
> set-face-attribute one of the families returned by font-family-list?
 
Yes they are.  Calling buffer-face-mode-invoke does what is expected to happen.  But not for set-face-attribute.

Re: :family and :height in set-face-attribute

[Eli Zaretskii]

> Date: Mon, 24 Jun 2024 15:39:07 +0000
> From: Heime <heimeborgia@protonmail.com>
> Cc: help-gnu-emacs@gnu.org
> 
> > > (set-face-attribute 'default nil
> > > 
> > > :family face-family :height (string-to-number face-height)) ))
> > 
> > 
> > Come on, can't you just show the values you use in the
> > set-face-attribute call?
> 
> I use the strings in cseq
>  
> > Also, is the value of face-family with which you call
> > set-face-attribute one of the families returned by font-family-list?
>  
> Yes they are.  Calling buffer-face-mode-invoke does what is expected to happen.  But not for set-face-attribute.

Then I don't know why it didn't work for you, sorry.  It did work for
me (but with font families I have, not with yours, which I don't
have).

Re: :family and :height in set-face-attribute

[Heime]

Sent with Proton Mail secure email.

On Monday, June 24th, 2024 at 4:29 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> > Date: Mon, 24 Jun 2024 15:39:07 +0000
> > From: Heime heimeborgia@protonmail.com
> > Cc: help-gnu-emacs@gnu.org
> > 
> > > > (set-face-attribute 'default nil
> > > > 
> > > > :family face-family :height (string-to-number face-height)) ))
> > > 
> > > Come on, can't you just show the values you use in the
> > > set-face-attribute call?
> > 
> > I use the strings in cseq
> > 
> > > Also, is the value of face-family with which you call
> > > set-face-attribute one of the families returned by font-family-list?
> > 
> > Yes they are. Calling buffer-face-mode-invoke does what is expected to happen. But not for set-face-attribute.
> 
> 
> Then I don't know why it didn't work for you, sorry. It did work for
> me (but with font families I have, not with yours, which I don't
> have).

The only instance that works is 

(set-face-attribute 'default nil :font "Wargames")