Re: How to bring previous-buffer to cycle through the full list of buffers

Re: How to bring previous-buffer to cycle through the full list of buffers

[martin rudalics]

 > After the windows history is exhausted by repetitively applying
 > previous-buffer, the cycling continues with all the other buffers in the
 > global buffer list, but this time unconditionally skipping those of them that
 > are visible in other windows--regardless of the setting in
 > switch-to-visible-buffer.

Try to replace the line

	  (if (get-buffer-window buffer frame)

with

	  (if (and (not switch-to-visible-buffer)
		   (get-buffer-window new-buffer frame))

in both `switch-to-prev-buffer' and `switch-to-next-buffer' (move these
functions to your .emacs if you cannot rebuild Emacs).

I didn't test this and don't know whether it has any adversary effect,
so you may have to play around with it ;-)

martin

[Solved] RE: How to bring previous-buffer to cycle through the full list of buffers

[Jürgen Hartmann]

Thank you, Martin Rudalics, for your solution:

>> After the windows history is exhausted by repetitively applying
>> previous-buffer, the cycling continues with all the other buffers in the
>> global buffer list, but this time unconditionally skipping those of them that
>> are visible in other windows--regardless of the setting in
>> switch-to-visible-buffer.
>
> Try to replace the line
>
>       (if (get-buffer-window buffer frame)
>
> with
>
>       (if (and (not switch-to-visible-buffer)
>            (get-buffer-window new-buffer frame))
>
> in both `switch-to-prev-buffer' and `switch-to-next-buffer' (move these
> functions to your .emacs if you cannot rebuild Emacs).
>
> I didn't test this and don't know whether it has any adversary effect,
> so you may have to play around with it ;-)
>
> martin

(It should read "buffer" instead of "new-buffer".)

This is exactly the solution I looked for. And more than that, it fully
respects the setting in switch-to-visible-buffer. Perfect!

In the tests I performed up to now I could not find any adversary effects. If
there are some, they are well hidden and will hardly be traced back to this
modification. :-)

Thank you very much for that.

Juergen

 		 	   		  

Re: [Solved] RE: How to bring previous-buffer to cycle through the full list of buffers

[martin rudalics]

 > (It should read "buffer" instead of "new-buffer".)

I was blindly pasting from another part of the function.

 > In the tests I performed up to now I could not find any adversary effects. If
 > there are some, they are well hidden and will hardly be traced back to this
 > modification. :-)

We could make this the default behavior.  If you see no problems within
a month or so, write up a patch (fixing the documentations accordingly)
and post it in a bug report.

Thanks, martin

RE: [Solved] RE: How to bring previous-buffer to cycle through the full list of buffers

[Jürgen Hartmann]

Martin Rudalics wrote:

>> (It should read "buffer" instead of "new-buffer".)
>
> I was blindly pasting from another part of the function.

With resounding success.

>> In the tests I performed up to now I could not find any adversary
>> effects. If there are some, they are well hidden and will hardly be
>> traced back to this modification. :-)
>
> We could make this the default behavior.  If you see no problems within
> a month or so, write up a patch (fixing the documentations accordingly)
> and post it in a bug report.

I will do so. Concerning the documentation, it is that of the variable
switch-to-visible-buffer that would need a minor change on account of this
modification. I will take this into account in the patch.

Thank you very much again.

Juergen