delete-trailing-whitespace behavior change?

delete-trailing-whitespace behavior change?

[Skip Montanaro]

I've defined this hook in ~/.emacs for ages (a decade or so, I suspect):

(add-hook 'before-save-hook 'delete-trailing-whitespace)

Recently, I've noticed that the last newline of files seems to be deleted.
Not always, but pretty frequently. I'm running 25.2.2 at home and 25.3.2 at
work. I think I switched from 24 to 25 in the past few months. I can't seem
to quickly lay my hands on Emacs 24 without going through a
download/install cycle, but I wonder if delete-trailing-whitespace might
have changed between 24 and 25?

Any insight would be appreciated...

Skip Montanaro

Re: delete-trailing-whitespace behavior change?

[Kaushal Modi]

On Wed, Dec 12, 2018 at 7:25 AM Skip Montanaro <skip.montanaro@gmail.com> wrote:
> Recently, I've noticed that the last newline of files seems to be deleted.
> Not always, but pretty frequently.

I don't know how this would cause randomness in deleting the final
newline, but do you have the variable require-final-newline set to nil
(default) by any chance.

If it is nil, a final newline is not auto-inserted. But if set to t,
that final newline is auto inserted on saving a file.

Re: delete-trailing-whitespace behavior change?

[Loris Bennett]

Skip Montanaro <skip.montanaro@gmail.com> writes:

> I've defined this hook in ~/.emacs for ages (a decade or so, I suspect):
>
> (add-hook 'before-save-hook 'delete-trailing-whitespace)
>
> Recently, I've noticed that the last newline of files seems to be deleted.
> Not always, but pretty frequently. I'm running 25.2.2 at home and 25.3.2 at
> work. I think I switched from 24 to 25 in the past few months. I can't seem
> to quickly lay my hands on Emacs 24 without going through a
> download/install cycle, but I wonder if delete-trailing-whitespace might
> have changed between 24 and 25?
>
> Any insight would be appreciated...

I have this setting too and my Emacs 25.1.1 deletes all empty newlines
at the end of a file, which it is what it says on the tin:

  If this command acts on the entire buffer (i.e. if called
  interactively with the mark inactive, or called from Lisp with END
  nil), it also deletes all trailing lines at the end of the buffer if
  the variable ‘delete-trailing-lines’ is non-nil.

The 24.5.1 tins say the same thing.

Cheers,

Loris

-- 
This signature is currently under construction.

Re: delete-trailing-whitespace behavior change?

[Skip Montanaro]

> I have this setting too and my Emacs 25.1.1 deletes all empty newlines
> at the end of a file, ...

Sorry, I probably wasn't clear in my original message. What I see is
that the newline at the end of the last non-empty line is deleted. So,
consider that I have this buffer (using C/Python/etc string notation
to make clear what I have):

"abc\ndef\nghi\n"

When written, it sometimes (maybe always, but I'm not certain of that)
results in

"abc\ndef\nghi"

That doesn't seem correct to me.

Skip

Re: delete-trailing-whitespace behavior change?

[Javier]

Loris Bennett <loris.bennett@fu-berlin.de> wrote:
> I have this setting too and my Emacs 25.1.1 deletes all empty newlines
> at the end of a file, which it is what it says on the tin:
> 
>   If this command acts on the entire buffer (i.e. if called
>   interactively with the mark inactive, or called from Lisp with END
>   nil), it also deletes all trailing lines at the end of the buffer if
>   the variable ‘delete-trailing-lines’ is non-nil.
> 
> The 24.5.1 tins say the same thing.

The option delete-trailing-lines appeared in version 24.3.
So there may be a change of behaviour between 24.1, 24.2 and 25.x

From /usr/share/emacs/*/etc/NEWS*

    * Editing Changes in Emacs 24.3
    ** New option `delete-trailing-lines' specifies whether
    M-x delete-trailing-whitespace should delete trailing lines at the end
    of the buffer.  It defaults to t.

Re: delete-trailing-whitespace behavior change?

[Skip Montanaro]

Thanks for the responses. This has been going on for awhile now, and
precisely because of that randomness Kaushal mentioned, I've been
hesitant to report the problem before. I can't say that it happens
only at work, or at work and at home. I'm not even certain it's an
Emacs issue. It's possible some something injected into the toolchain
(maybe a git hook?) has been wreaking havoc with final newlines. Alas,
most other people at work are vim users (and don't write much Python
code) and could care less about extra whitespace, so my
before-write-hook often deletes a few spaces.

Regarding variables, both delete-trailing-lines and
require-final-newline are t. Neither is tweaked in ~/.emacs.

Skip