From: Skip Montanaro <skip.montanaro@gmail.com>
To: Krishnakant <krmane@openmailbox.org>
Cc: help-gnu-emacs@gnu.org
Subject: Re: how to highlight block end in Python-mode indentation
Date: Sun, 21 May 2017 07:40:57 -0500 [thread overview]
Message-ID: <CANc-5Uw1ZEFJNW56sKhuUjvLbnnhycmw5U0NwWm2H=Myafw34g@mail.gmail.com> (raw)
In-Reply-To: <6624ae5f-ff47-ebd4-2c0f-871c9845d29b@openmailbox.org>
Do you have some solution?
I think Yuri summarized the places to start quite well. In general, it
sounds like a fair amount of code refactoring is in order.
I would caution against trying to do it all at once, however. Assuming you
have unit tests or even just some regression tests you can run, make sure
everything passes, do a little refactoring, verify your tests still pass
(and that they exercise the modified code - if not, write more test cases),
check in the changes, then it's a process of lather, rinse, repeat.
One mistake I make repeatedly, is mixing changes in a commit. Suppose I
want to refactor a chunk of code into a separate function. While doing
that, I notice something unrelated which needs doing too, and do that. Now
my next commit mixes two functional changes to the code base, making it
difficult to back out just one of them later. Small, precise commits are
preferable to big, rambling commits. Such problematic commits are more
tempting to make when you know you have a fair amount of work to do.
Sorry, this is off-topic from your original request. Hopefully these few
posts give you a bit different way to think about the problem you face.
Skip Montanaro
prev parent reply other threads:[~2017-05-21 12:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 12:01 how to highlight block end in Python-mode indentation Krishnakant
2017-05-19 12:18 ` Joost Kremers
2017-05-19 12:30 ` Krishnakant
2017-05-20 6:37 ` Krishnakant
2017-05-20 8:49 ` Joost Kremers
2017-05-19 19:18 ` Tomas Nordin
2017-05-19 19:43 ` Joost Kremers
2017-05-21 11:16 ` Krishnakant
2017-05-21 11:27 ` Skip Montanaro
2017-05-21 11:38 ` Krishnakant
2017-05-21 12:04 ` Yuri Khan
2017-05-21 13:46 ` Krishnakant
2017-05-21 14:16 ` Skip Montanaro
2017-05-21 14:45 ` Yuri Khan
2017-05-21 15:58 ` Krishnakant
2017-05-21 12:40 ` Skip Montanaro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANc-5Uw1ZEFJNW56sKhuUjvLbnnhycmw5U0NwWm2H=Myafw34g@mail.gmail.com' \
--to=skip.montanaro@gmail.com \
--cc=help-gnu-emacs@gnu.org \
--cc=krmane@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).