unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
* Help adding a package to NonGNU Elpa
@ 2021-11-02 20:57 Stephen Meister
  2021-11-02 22:19 ` Stefan Monnier via Users list for the GNU Emacs text editor
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Meister @ 2021-11-02 20:57 UTC (permalink / raw)
  To: help-gnu-emacs

I'm having some trouble following the directions in README.org from the
main branch of https://git.savannah.gnu.org/git/emacs/nongnu.git

I've followed the sections for 'Initial Setup' and Building (i.e. make and
make build-all).

Following the 'Adding a package' section, I've made my addition to the
elpa-packages file and attempted to run: make fetch/MyPackageNameHere .
This command fails telling me the package hasn't been pushed to the origin
yet.  That's certainly true as I haven't pushed anything to the origin (I'm
not actually sure if I'm able to do that).

Is there a step I missing?  My goal is to add
https://gitlab.com/steve-emacs-stuff/cpupower-el

-steve


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Help adding a package to NonGNU Elpa
  2021-11-02 20:57 Stephen Meister
@ 2021-11-02 22:19 ` Stefan Monnier via Users list for the GNU Emacs text editor
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Monnier via Users list for the GNU Emacs text editor @ 2021-11-02 22:19 UTC (permalink / raw)
  To: help-gnu-emacs

> Following the 'Adding a package' section, I've made my addition to the
> elpa-packages file and attempted to run: make fetch/MyPackageNameHere .
> This command fails telling me the package hasn't been pushed to the origin
> yet.  That's certainly true as I haven't pushed anything to the origin (I'm
> not actually sure if I'm able to do that).

IIUC you're just seeing some error messages, but the command does do
what you asked (i.e. the error messages are "noise" that you can
ignore).

If not, then please tell us what in the result is actually different
from what you expected (at which point, the potential error messages
that came along the way may prove useful, of course).


        Stefan




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Help adding a package to NonGNU Elpa
@ 2021-11-03 14:57 Stephen Meister
  2021-11-03 19:01 ` Stefan Monnier via Users list for the GNU Emacs text editor
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Meister @ 2021-11-03 14:57 UTC (permalink / raw)
  To: help-gnu-emacs

[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]

> IIUC you're just seeing some error messages, but the command does do
> what you asked (i.e. the error messages are "noise" that you can
> ignore).

Yep, you're correct.  I misunderstood that output.

I'm now at the point where the README
(https://git.savannah.gnu.org/cgit/emacs/nongnu.git/tree/README.org#n241)
tells me to git push which is failing because I don't have
permissions.  I don't think I have such permissions so that makes
sense.  I asked in the emacs IRC channel and the suggestion was to
mail the patch to the emacs-devel mailing list.  Is this the correct
way to submit code?  I don't mind mailing a patch but it's a process
I've never worked with before.

I've noted https://www.gnu.org/software/emacs/manual/html_node/emacs/Sending-Patches.html
as well, which suggests sending patches to the bug-gnu-emacs mailing
list.  That list appears to only be applicable to existing bugs
though, which I don't currently have.

Any suggestions for how to continue?  I've tried to attach my patch
here for reference.

-steve

[-- Attachment #2: 0001-elpa-packages-cpupower-New-package.patch --]
[-- Type: text/x-patch, Size: 774 bytes --]

From f3e158645ebfbd84c40c2610e6a22f86860c3bdd Mon Sep 17 00:00:00 2001
From: smeister <pallagun@gmail.com>
Date: Wed, 3 Nov 2021 08:16:29 -0400
Subject: [PATCH] * elpa-packages (cpupower): New package

---
 elpa-packages | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index 0de123b1dc..4b0a2b1340 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -40,6 +40,9 @@
   :ignored-files ("clojure-mode-extra-font-locking.el" "doc" "test" "test.clj")
   :news "CHANGELOG.md")
 
+ ("cpupower"            :url "https://gitlab.com/steve-emacs-stuff/cpupower-el.git"
+  :ignored-files ("README.md" "COPYING"))
+
  ("crux"		:url "https://github.com/bbatsov/crux")
 
  ("cyberpunk-theme"	:url "https://github.com/n3mo/cyberpunk-theme.el"
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: Help adding a package to NonGNU Elpa
  2021-11-03 14:57 Help adding a package to NonGNU Elpa Stephen Meister
@ 2021-11-03 19:01 ` Stefan Monnier via Users list for the GNU Emacs text editor
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Monnier via Users list for the GNU Emacs text editor @ 2021-11-03 19:01 UTC (permalink / raw)
  To: help-gnu-emacs

> sense.  I asked in the emacs IRC channel and the suggestion was to
> mail the patch to the emacs-devel mailing list.  Is this the correct
> way to submit code?  I don't mind mailing a patch but it's a process
> I've never worked with before.

Yes, sending the patch is the better way.  These patches are so trivial,
so even if they get botched by the mailer it doesn't matter because
they're easy to apply by hand, so you can copy&paste the patch into your
MUA and that will be good enough.


        Stefan




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-03 19:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-03 14:57 Help adding a package to NonGNU Elpa Stephen Meister
2021-11-03 19:01 ` Stefan Monnier via Users list for the GNU Emacs text editor
  -- strict thread matches above, loose matches on Subject: below --
2021-11-02 20:57 Stephen Meister
2021-11-02 22:19 ` Stefan Monnier via Users list for the GNU Emacs text editor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).