From: Kaushal Modi <kaushal.modi@gmail.com>
To: Help Gnu Emacs mailing list <help-gnu-emacs@gnu.org>
Subject: Re: Help setting nadvice for indent-region
Date: Sat, 06 Feb 2016 00:00:12 +0000 [thread overview]
Message-ID: <CAFyQvY2pH9yMhfMdr0MN7Px6nQwRUs+8FnVMq2ZC9emPa84OFw@mail.gmail.com> (raw)
In-Reply-To: <CAFyQvY1sP=6kNX2Fvb_pZZG_SZhZTtFOMy94SphV9PRTVPb5vQ@mail.gmail.com>
Neat, I hit a brick-wall there.
Advising interactive gives: "advice--normalize: Advice impossible:
interactive is a special form"
On Fri, Feb 5, 2016 at 6:58 PM Kaushal Modi <kaushal.modi@gmail.com> wrote:
> Aha.. looks like the check_mark in callint.c is raising the error even
> before the advice sets the args as the call_interactively's 'r' case is
> activated. That's because indent-region has (interactive "r\nP").
>
> So looks like I'll need to advice the whole interactive? What would be a
> better solution?
>
> On Fri, Feb 5, 2016 at 6:49 PM Kaushal Modi <kaushal.modi@gmail.com>
> wrote:
>
>> Hi,
>>
>> I'd like to advice indent-region so that if a region is not select, it
>> indents between (point-min) and (point-max).
>>
>> So I have this:
>>
>> =====
>>
>> (defun adv/indent-region (args)
>> (when (not mark-active)
>> (setq args (list (point-min) (point-max))))
>> args)
>> (advice-add 'indent-region :filter-args #'adv/indent-region)
>>
>> =====
>>
>> This usually works, unless I have just launched a fresh buffer in which
>> there is no mark set.
>>
>> If I do M-: (mark) in that buffer, I get nil.
>> In that case, if I call M-x indent-region (with no region selected), I
>> get this error backtrace:
>>
>> Debugger entered--Lisp error: (error "The mark is not set now, so there
>> is no region")
>> call-interactively(indent-region nil nil)
>> command-execute(indent-region)
>>
>> If it looks like the error is triggered by call-interactively even before
>> the advice gets to do its thing.
>>
>> How can I resolve this using nadvice?
>>
>> Thanks.
>>
>> Kaushal Modi
>>
>
next prev parent reply other threads:[~2016-02-06 0:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 23:49 Help setting nadvice for indent-region Kaushal Modi
2016-02-05 23:58 ` Kaushal Modi
2016-02-06 0:00 ` Kaushal Modi [this message]
2016-02-06 0:30 ` Emanuel Berg
2016-02-06 3:31 ` Kaushal Modi
2016-02-06 10:43 ` Michael Heerdegen
2016-02-07 3:12 ` Kaushal Modi
2016-02-07 17:46 ` Kaushal Modi
2016-02-07 18:51 ` John Mastro
2016-02-08 0:03 ` Emanuel Berg
2016-02-08 4:22 ` Kaushal Modi
2016-02-08 17:05 ` Eli Zaretskii
2016-02-08 17:27 ` Kaushal Modi
2016-02-09 3:07 ` Emanuel Berg
2016-02-08 20:03 ` John Mastro
2016-02-08 23:13 ` Emanuel Berg
2016-02-11 14:02 ` Stefan Monnier
2016-02-11 17:36 ` Kaushal Modi
2016-02-11 18:10 ` Michael Heerdegen
2016-02-11 18:47 ` Kaushal Modi
2016-02-11 18:56 ` Kaushal Modi
2016-02-11 19:14 ` Michael Heerdegen
2016-02-11 20:15 ` Kaushal Modi
2016-02-11 20:38 ` Kaushal Modi
2016-02-12 14:09 ` Michael Heerdegen
2016-02-12 14:21 ` Michael Heerdegen
2016-02-12 16:02 ` Kaushal Modi
2016-02-12 19:04 ` Michael Heerdegen
2016-02-12 13:57 ` Michael Heerdegen
2016-02-11 19:03 ` Michael Heerdegen
2016-02-07 23:48 ` Emanuel Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFyQvY2pH9yMhfMdr0MN7Px6nQwRUs+8FnVMq2ZC9emPa84OFw@mail.gmail.com \
--to=kaushal.modi@gmail.com \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).